2026-01-05 07:24:51 +01:00
|
|
|
import { describe, expect, it } from "vitest";
|
2026-01-16 22:25:51 +00:00
|
|
|
import {
|
|
|
|
|
listThinkingLevelLabels,
|
|
|
|
|
listThinkingLevels,
|
|
|
|
|
normalizeReasoningLevel,
|
|
|
|
|
normalizeThinkLevel,
|
feat(ui): dashboard-v2 views refactor (slice 3/3 of dashboard-v2) (#41503)
* feat(ui): add chat infrastructure modules (slice 1 of dashboard-v2)
New self-contained chat modules extracted from dashboard-v2-structure:
- chat/slash-commands.ts: slash command definitions and completions
- chat/slash-command-executor.ts: execute slash commands via gateway RPC
- chat/slash-command-executor.node.test.ts: test coverage
- chat/speech.ts: speech-to-text (STT) support
- chat/input-history.ts: per-session input history navigation
- chat/pinned-messages.ts: pinned message management
- chat/deleted-messages.ts: deleted message tracking
- chat/export.ts: shared exportChatMarkdown helper
- chat-export.ts: re-export shim for backwards compat
Gateway fix:
- Restore usage/cost stripping in chat.history sanitization
- Add test coverage for sanitization behavior
These modules are additive and tree-shaken — no existing code
imports them yet. They will be wired in subsequent slices.
* feat(ui): add utilities, theming, and i18n updates (slice 2 of dashboard-v2)
UI utilities and theming improvements extracted from dashboard-v2-structure:
Icons & formatting:
- icons.ts: expanded icon set for new dashboard views
- format.ts: date/number formatting helpers
- tool-labels.ts: human-readable tool name mappings
Theming:
- theme.ts: enhanced theme resolution and system theme support
- theme-transition.ts: simplified transition logic
- storage.ts: theme parsing improvements for settings persistence
Navigation & types:
- navigation.ts: extended tab definitions for dashboard-v2
- app-view-state.ts: expanded view state management
- types.ts: new type definitions (HealthSummary, ModelCatalogEntry, etc.)
Components:
- components/dashboard-header.ts: reusable header component
i18n:
- Updated en, pt-BR, zh-CN, zh-TW locales with new dashboard strings
All changes are additive or backwards-compatible. Build passes.
Part of #36853.
* feat(ui): dashboard-v2 views refactor (slice 3 of dashboard-v2)
Complete views refactor from dashboard-v2-structure, building on
slice 1 (chat infra, #41497) and slice 2 (utilities/theming, #41500).
Core app wiring:
- app.ts: updated host component with new state properties
- app-render.ts: refactored render pipeline for new dashboard layout
- app-render.helpers.ts: extracted render helpers
- app-settings.ts: theme listener lifecycle fix, cron runs on tab load
- app-gateway.ts: refactored chat event handling
- app-chat.ts: slash command integration
New views:
- views/command-palette.ts: command palette (Cmd+K)
- views/login-gate.ts: authentication gate
- views/bottom-tabs.ts: mobile tab navigation
- views/overview-*.ts: modular overview dashboard (cards, attention,
event log, hints, log tail, quick actions)
- views/agents-panels-overview.ts: agent overview panel
Refactored views:
- views/chat.ts: major refactor with STT, slash commands, search,
export, pinned messages, input history
- views/config.ts: restructured config management
- views/agents.ts: streamlined agent management
- views/overview.ts: modular composition from sub-views
- views/sessions.ts: enhanced session management
Controllers:
- controllers/health.ts: new health check controller
- controllers/models.ts: new model catalog controller
- controllers/agents.ts: tools catalog improvements
- controllers/config.ts: config form enhancements
Tests & infrastructure:
- Updated test helpers, browser tests, node tests
- vite.config.ts: build configuration updates
- markdown.ts: rendering improvements
Build passes ✅ | 44 files | +6,626/-1,499
Part of #36853. Depends on #41497 and #41500.
* UI: fix chat review follow-ups
* fix(ui): repair chat clear and attachment regressions
* fix(ui): address remaining chat review comments
* fix(ui): address review follow-ups
* fix(ui): replay queued local slash commands
* fix(ui): repair control-ui type drift
* fix(ui): restore control UI styling
* feat(ui): enhance layout and styling for config and topbar components
- Updated grid layout for the config layout to allow full-width usage.
- Introduced new styles for top tabs and search components to improve usability.
- Added theme mode toggle styling for better visual integration.
- Implemented tests for layout and theme mode components to ensure proper rendering and functionality.
* feat(ui): add config file opening functionality and enhance styles
- Implemented a new handler to open the configuration file using the default application based on the operating system.
- Updated various CSS styles across components for improved visual consistency and usability, including adjustments to padding, margins, and font sizes.
- Introduced new styles for the data table and sidebar components to enhance layout and interaction.
- Added tests for the collapsed navigation rail to ensure proper functionality in different states.
* refactor(ui): update CSS styles for improved layout and consistency
- Simplified font-body declaration in base.css for cleaner code.
- Adjusted transition properties in components.css for better readability.
- Added new .workspace-link class in components.css for enhanced link styling.
- Changed config layout from grid to flex in config.css for better responsiveness.
- Updated related tests to reflect layout changes in config-layout.browser.test.ts.
* feat(ui): enhance theme handling and loading states in chat interface
- Updated CSS to support new theme mode attributes for better styling consistency across light and dark themes.
- Introduced loading skeletons in the chat view to improve user experience during data fetching.
- Refactored command palette to manage focus more effectively, enhancing accessibility.
- Added tests for the appearance theme picker and loading states to ensure proper rendering and functionality.
* refactor(ui): streamline ephemeral state management in chat and config views
- Introduced interfaces for ephemeral state in chat and config views to encapsulate related variables.
- Refactored state management to utilize a single object for better organization and maintainability.
- Removed legacy state variables and updated related functions to reference the new state structure.
- Enhanced readability and consistency across the codebase by standardizing state handling.
* chore: remove test files to reduce PR scope
* fix(ui): resolve type errors in debug props and chat search
* refactor(ui): remove stream mode functionality across various components
- Eliminated stream mode related translations and CSS styles to streamline the user interface.
- Updated multiple components to remove references to stream mode, enhancing code clarity and maintainability.
- Adjusted rendering logic in views to ensure consistent behavior without stream mode.
- Improved overall readability by cleaning up unused variables and props.
* fix(ui): add msg-meta CSS and fix rebase type errors
* fix(ui): add CSS for chat footer action buttons (TTS, delete) and msg-meta
* feat(ui): add delete confirmation with remember-decision checkbox
* fix(ui): delete confirmation with remember, attention icon sizing
* fix(ui): open delete confirm popover to the left (not clipped)
* fix(ui): show all nav items in collapsed sidebar, remove gap
* fix(ui): address P1/P2 review feedback — session queue clear, kill scope, palette guard, stop button
* fix(ui): address Greptile re-review — kill scope, queue flush, idle handling, parallel fetch
- SECURITY: /kill <target> now enforces session tree scope (not just /kill all)
- /kill reports idle sessions gracefully instead of throwing
- Queue continues draining after local slash commands
- /model fetches sessions.list + models.list in parallel (perf fix)
* fix(ui): style update banner close button — SVG stroke + sizing
* fix(ui): update layout styles for sidebar and content spacing
* UI: restore colon slash command parsing
* UI: restore slash command session queries
* Refactor thinking resolution: Introduce resolveThinkingDefaultForModel function and update model-selection to utilize it. Add tests for new functionality in thinking.test.ts.
* fix(ui): constrain welcome state logo size, add missing CSS for new session view
---------
Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
2026-03-12 12:46:19 -05:00
|
|
|
resolveThinkingDefaultForModel,
|
2026-01-16 22:25:51 +00:00
|
|
|
} from "./thinking.js";
|
2026-01-05 07:24:51 +01:00
|
|
|
|
|
|
|
|
describe("normalizeThinkLevel", () => {
|
|
|
|
|
it("accepts mid as medium", () => {
|
|
|
|
|
expect(normalizeThinkLevel("mid")).toBe("medium");
|
|
|
|
|
});
|
2026-01-07 17:17:38 -08:00
|
|
|
|
2026-02-05 15:56:26 -08:00
|
|
|
it("accepts xhigh aliases", () => {
|
2026-01-07 17:17:38 -08:00
|
|
|
expect(normalizeThinkLevel("xhigh")).toBe("xhigh");
|
2026-02-05 15:56:26 -08:00
|
|
|
expect(normalizeThinkLevel("x-high")).toBe("xhigh");
|
|
|
|
|
expect(normalizeThinkLevel("x_high")).toBe("xhigh");
|
|
|
|
|
expect(normalizeThinkLevel("x high")).toBe("xhigh");
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("accepts extra-high aliases as xhigh", () => {
|
|
|
|
|
expect(normalizeThinkLevel("extra-high")).toBe("xhigh");
|
|
|
|
|
expect(normalizeThinkLevel("extra high")).toBe("xhigh");
|
|
|
|
|
expect(normalizeThinkLevel("extra_high")).toBe("xhigh");
|
|
|
|
|
expect(normalizeThinkLevel(" extra high ")).toBe("xhigh");
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("does not over-match nearby xhigh words", () => {
|
|
|
|
|
expect(normalizeThinkLevel("extra-highest")).toBeUndefined();
|
|
|
|
|
expect(normalizeThinkLevel("xhigher")).toBeUndefined();
|
2026-01-07 17:17:38 -08:00
|
|
|
});
|
2026-01-16 22:25:51 +00:00
|
|
|
|
|
|
|
|
it("accepts on as low", () => {
|
|
|
|
|
expect(normalizeThinkLevel("on")).toBe("low");
|
|
|
|
|
});
|
2026-03-02 11:52:02 +08:00
|
|
|
|
|
|
|
|
it("accepts adaptive and auto aliases", () => {
|
|
|
|
|
expect(normalizeThinkLevel("adaptive")).toBe("adaptive");
|
|
|
|
|
expect(normalizeThinkLevel("auto")).toBe("adaptive");
|
|
|
|
|
expect(normalizeThinkLevel("Adaptive")).toBe("adaptive");
|
|
|
|
|
});
|
2026-01-07 17:17:38 -08:00
|
|
|
});
|
|
|
|
|
|
|
|
|
|
describe("listThinkingLevels", () => {
|
|
|
|
|
it("includes xhigh for codex models", () => {
|
|
|
|
|
expect(listThinkingLevels(undefined, "gpt-5.2-codex")).toContain("xhigh");
|
2026-02-05 16:54:44 -05:00
|
|
|
expect(listThinkingLevels(undefined, "gpt-5.3-codex")).toContain("xhigh");
|
2026-02-13 12:39:22 +01:00
|
|
|
expect(listThinkingLevels(undefined, "gpt-5.3-codex-spark")).toContain("xhigh");
|
2026-01-07 17:17:38 -08:00
|
|
|
});
|
|
|
|
|
|
2026-03-06 08:01:37 +03:00
|
|
|
it("includes xhigh for openai gpt-5.2 and gpt-5.4 variants", () => {
|
2026-01-07 17:17:38 -08:00
|
|
|
expect(listThinkingLevels("openai", "gpt-5.2")).toContain("xhigh");
|
2026-03-06 08:01:37 +03:00
|
|
|
expect(listThinkingLevels("openai", "gpt-5.4")).toContain("xhigh");
|
|
|
|
|
expect(listThinkingLevels("openai", "gpt-5.4-pro")).toContain("xhigh");
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("includes xhigh for openai-codex gpt-5.4", () => {
|
|
|
|
|
expect(listThinkingLevels("openai-codex", "gpt-5.4")).toContain("xhigh");
|
2026-01-07 17:17:38 -08:00
|
|
|
});
|
|
|
|
|
|
2026-02-08 08:45:59 -05:00
|
|
|
it("includes xhigh for github-copilot gpt-5.2 refs", () => {
|
|
|
|
|
expect(listThinkingLevels("github-copilot", "gpt-5.2")).toContain("xhigh");
|
|
|
|
|
expect(listThinkingLevels("github-copilot", "gpt-5.2-codex")).toContain("xhigh");
|
|
|
|
|
});
|
|
|
|
|
|
2026-01-07 17:17:38 -08:00
|
|
|
it("excludes xhigh for non-codex models", () => {
|
2026-01-14 14:31:43 +00:00
|
|
|
expect(listThinkingLevels(undefined, "gpt-4.1-mini")).not.toContain("xhigh");
|
2026-01-07 17:17:38 -08:00
|
|
|
});
|
2026-03-02 11:52:02 +08:00
|
|
|
|
|
|
|
|
it("always includes adaptive", () => {
|
|
|
|
|
expect(listThinkingLevels(undefined, "gpt-4.1-mini")).toContain("adaptive");
|
|
|
|
|
expect(listThinkingLevels("anthropic", "claude-opus-4-6")).toContain("adaptive");
|
|
|
|
|
});
|
2026-01-05 07:24:51 +01:00
|
|
|
});
|
2026-01-07 06:16:38 +01:00
|
|
|
|
2026-01-16 22:25:51 +00:00
|
|
|
describe("listThinkingLevelLabels", () => {
|
|
|
|
|
it("returns on/off for ZAI", () => {
|
|
|
|
|
expect(listThinkingLevelLabels("zai", "glm-4.7")).toEqual(["off", "on"]);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("returns full levels for non-ZAI", () => {
|
|
|
|
|
expect(listThinkingLevelLabels("openai", "gpt-4.1-mini")).toContain("low");
|
|
|
|
|
expect(listThinkingLevelLabels("openai", "gpt-4.1-mini")).not.toContain("on");
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
feat(ui): dashboard-v2 views refactor (slice 3/3 of dashboard-v2) (#41503)
* feat(ui): add chat infrastructure modules (slice 1 of dashboard-v2)
New self-contained chat modules extracted from dashboard-v2-structure:
- chat/slash-commands.ts: slash command definitions and completions
- chat/slash-command-executor.ts: execute slash commands via gateway RPC
- chat/slash-command-executor.node.test.ts: test coverage
- chat/speech.ts: speech-to-text (STT) support
- chat/input-history.ts: per-session input history navigation
- chat/pinned-messages.ts: pinned message management
- chat/deleted-messages.ts: deleted message tracking
- chat/export.ts: shared exportChatMarkdown helper
- chat-export.ts: re-export shim for backwards compat
Gateway fix:
- Restore usage/cost stripping in chat.history sanitization
- Add test coverage for sanitization behavior
These modules are additive and tree-shaken — no existing code
imports them yet. They will be wired in subsequent slices.
* feat(ui): add utilities, theming, and i18n updates (slice 2 of dashboard-v2)
UI utilities and theming improvements extracted from dashboard-v2-structure:
Icons & formatting:
- icons.ts: expanded icon set for new dashboard views
- format.ts: date/number formatting helpers
- tool-labels.ts: human-readable tool name mappings
Theming:
- theme.ts: enhanced theme resolution and system theme support
- theme-transition.ts: simplified transition logic
- storage.ts: theme parsing improvements for settings persistence
Navigation & types:
- navigation.ts: extended tab definitions for dashboard-v2
- app-view-state.ts: expanded view state management
- types.ts: new type definitions (HealthSummary, ModelCatalogEntry, etc.)
Components:
- components/dashboard-header.ts: reusable header component
i18n:
- Updated en, pt-BR, zh-CN, zh-TW locales with new dashboard strings
All changes are additive or backwards-compatible. Build passes.
Part of #36853.
* feat(ui): dashboard-v2 views refactor (slice 3 of dashboard-v2)
Complete views refactor from dashboard-v2-structure, building on
slice 1 (chat infra, #41497) and slice 2 (utilities/theming, #41500).
Core app wiring:
- app.ts: updated host component with new state properties
- app-render.ts: refactored render pipeline for new dashboard layout
- app-render.helpers.ts: extracted render helpers
- app-settings.ts: theme listener lifecycle fix, cron runs on tab load
- app-gateway.ts: refactored chat event handling
- app-chat.ts: slash command integration
New views:
- views/command-palette.ts: command palette (Cmd+K)
- views/login-gate.ts: authentication gate
- views/bottom-tabs.ts: mobile tab navigation
- views/overview-*.ts: modular overview dashboard (cards, attention,
event log, hints, log tail, quick actions)
- views/agents-panels-overview.ts: agent overview panel
Refactored views:
- views/chat.ts: major refactor with STT, slash commands, search,
export, pinned messages, input history
- views/config.ts: restructured config management
- views/agents.ts: streamlined agent management
- views/overview.ts: modular composition from sub-views
- views/sessions.ts: enhanced session management
Controllers:
- controllers/health.ts: new health check controller
- controllers/models.ts: new model catalog controller
- controllers/agents.ts: tools catalog improvements
- controllers/config.ts: config form enhancements
Tests & infrastructure:
- Updated test helpers, browser tests, node tests
- vite.config.ts: build configuration updates
- markdown.ts: rendering improvements
Build passes ✅ | 44 files | +6,626/-1,499
Part of #36853. Depends on #41497 and #41500.
* UI: fix chat review follow-ups
* fix(ui): repair chat clear and attachment regressions
* fix(ui): address remaining chat review comments
* fix(ui): address review follow-ups
* fix(ui): replay queued local slash commands
* fix(ui): repair control-ui type drift
* fix(ui): restore control UI styling
* feat(ui): enhance layout and styling for config and topbar components
- Updated grid layout for the config layout to allow full-width usage.
- Introduced new styles for top tabs and search components to improve usability.
- Added theme mode toggle styling for better visual integration.
- Implemented tests for layout and theme mode components to ensure proper rendering and functionality.
* feat(ui): add config file opening functionality and enhance styles
- Implemented a new handler to open the configuration file using the default application based on the operating system.
- Updated various CSS styles across components for improved visual consistency and usability, including adjustments to padding, margins, and font sizes.
- Introduced new styles for the data table and sidebar components to enhance layout and interaction.
- Added tests for the collapsed navigation rail to ensure proper functionality in different states.
* refactor(ui): update CSS styles for improved layout and consistency
- Simplified font-body declaration in base.css for cleaner code.
- Adjusted transition properties in components.css for better readability.
- Added new .workspace-link class in components.css for enhanced link styling.
- Changed config layout from grid to flex in config.css for better responsiveness.
- Updated related tests to reflect layout changes in config-layout.browser.test.ts.
* feat(ui): enhance theme handling and loading states in chat interface
- Updated CSS to support new theme mode attributes for better styling consistency across light and dark themes.
- Introduced loading skeletons in the chat view to improve user experience during data fetching.
- Refactored command palette to manage focus more effectively, enhancing accessibility.
- Added tests for the appearance theme picker and loading states to ensure proper rendering and functionality.
* refactor(ui): streamline ephemeral state management in chat and config views
- Introduced interfaces for ephemeral state in chat and config views to encapsulate related variables.
- Refactored state management to utilize a single object for better organization and maintainability.
- Removed legacy state variables and updated related functions to reference the new state structure.
- Enhanced readability and consistency across the codebase by standardizing state handling.
* chore: remove test files to reduce PR scope
* fix(ui): resolve type errors in debug props and chat search
* refactor(ui): remove stream mode functionality across various components
- Eliminated stream mode related translations and CSS styles to streamline the user interface.
- Updated multiple components to remove references to stream mode, enhancing code clarity and maintainability.
- Adjusted rendering logic in views to ensure consistent behavior without stream mode.
- Improved overall readability by cleaning up unused variables and props.
* fix(ui): add msg-meta CSS and fix rebase type errors
* fix(ui): add CSS for chat footer action buttons (TTS, delete) and msg-meta
* feat(ui): add delete confirmation with remember-decision checkbox
* fix(ui): delete confirmation with remember, attention icon sizing
* fix(ui): open delete confirm popover to the left (not clipped)
* fix(ui): show all nav items in collapsed sidebar, remove gap
* fix(ui): address P1/P2 review feedback — session queue clear, kill scope, palette guard, stop button
* fix(ui): address Greptile re-review — kill scope, queue flush, idle handling, parallel fetch
- SECURITY: /kill <target> now enforces session tree scope (not just /kill all)
- /kill reports idle sessions gracefully instead of throwing
- Queue continues draining after local slash commands
- /model fetches sessions.list + models.list in parallel (perf fix)
* fix(ui): style update banner close button — SVG stroke + sizing
* fix(ui): update layout styles for sidebar and content spacing
* UI: restore colon slash command parsing
* UI: restore slash command session queries
* Refactor thinking resolution: Introduce resolveThinkingDefaultForModel function and update model-selection to utilize it. Add tests for new functionality in thinking.test.ts.
* fix(ui): constrain welcome state logo size, add missing CSS for new session view
---------
Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
2026-03-12 12:46:19 -05:00
|
|
|
describe("resolveThinkingDefaultForModel", () => {
|
|
|
|
|
it("defaults Claude 4.6 models to adaptive", () => {
|
|
|
|
|
expect(
|
|
|
|
|
resolveThinkingDefaultForModel({ provider: "anthropic", model: "claude-opus-4-6" }),
|
|
|
|
|
).toBe("adaptive");
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("treats Bedrock Anthropic aliases as adaptive", () => {
|
|
|
|
|
expect(
|
|
|
|
|
resolveThinkingDefaultForModel({ provider: "aws-bedrock", model: "claude-sonnet-4-6" }),
|
|
|
|
|
).toBe("adaptive");
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("defaults reasoning-capable catalog models to low", () => {
|
|
|
|
|
expect(
|
|
|
|
|
resolveThinkingDefaultForModel({
|
|
|
|
|
provider: "openai",
|
|
|
|
|
model: "gpt-5.4",
|
|
|
|
|
catalog: [{ provider: "openai", id: "gpt-5.4", reasoning: true }],
|
|
|
|
|
}),
|
|
|
|
|
).toBe("low");
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("defaults to off when no adaptive or reasoning hint is present", () => {
|
|
|
|
|
expect(
|
|
|
|
|
resolveThinkingDefaultForModel({
|
|
|
|
|
provider: "openai",
|
|
|
|
|
model: "gpt-4.1-mini",
|
|
|
|
|
catalog: [{ provider: "openai", id: "gpt-4.1-mini", reasoning: false }],
|
|
|
|
|
}),
|
|
|
|
|
).toBe("off");
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
2026-01-07 06:16:38 +01:00
|
|
|
describe("normalizeReasoningLevel", () => {
|
|
|
|
|
it("accepts on/off", () => {
|
|
|
|
|
expect(normalizeReasoningLevel("on")).toBe("on");
|
|
|
|
|
expect(normalizeReasoningLevel("off")).toBe("off");
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("accepts show/hide", () => {
|
|
|
|
|
expect(normalizeReasoningLevel("show")).toBe("on");
|
|
|
|
|
expect(normalizeReasoningLevel("hide")).toBe("off");
|
|
|
|
|
});
|
2026-01-07 11:08:11 +01:00
|
|
|
|
|
|
|
|
it("accepts stream", () => {
|
|
|
|
|
expect(normalizeReasoningLevel("stream")).toBe("stream");
|
|
|
|
|
expect(normalizeReasoningLevel("streaming")).toBe("stream");
|
|
|
|
|
});
|
2026-01-07 06:16:38 +01:00
|
|
|
});
|