2026-02-14 22:54:16 +00:00
import type { AgentTool , AgentToolResult } from "@mariozechner/pi-agent-core" ;
2026-01-14 05:39:59 +00:00
import { Type } from "@sinclair/typebox" ;
2026-02-08 04:53:31 -08:00
import { formatDurationCompact } from "../infra/format-time/format-duration.ts" ;
2026-02-16 14:03:40 -08:00
import { getDiagnosticSessionState } from "../logging/diagnostic-session-state.js" ;
2026-02-16 09:32:05 +08:00
import { killProcessTree } from "../process/kill-tree.js" ;
import { getProcessSupervisor } from "../process/supervisor/index.js" ;
2026-01-14 05:39:59 +00:00
import {
2026-02-16 09:32:05 +08:00
type ProcessSession ,
2026-01-14 05:39:59 +00:00
deleteSession ,
drainSession ,
getFinishedSession ,
getSession ,
listFinishedSessions ,
listRunningSessions ,
markExited ,
setJobTtlMs ,
} from "./bash-process-registry.js" ;
2026-03-04 08:52:05 -05:00
import {
clampWithDefault ,
deriveSessionName ,
pad ,
readEnvInt ,
sliceLogLines ,
truncateMiddle ,
} from "./bash-tools.shared.js" ;
2026-02-16 14:17:42 -08:00
import { recordCommandPoll , resetCommandPollCount } from "./command-poll-backoff.js" ;
2026-01-17 06:12:25 +00:00
import { encodeKeySequence , encodePaste } from "./pty-keys.js" ;
2026-01-14 05:39:59 +00:00
export type ProcessToolDefaults = {
cleanupMs? : number ;
scopeKey? : string ;
2026-03-04 08:52:05 -05:00
inputWaitIdleMs? : number ;
2026-01-14 05:39:59 +00:00
} ;
2026-02-14 22:54:16 +00:00
type WritableStdin = {
write : ( data : string , cb ? : ( err? : Error | null ) = > void ) = > void ;
end : ( ) = > void ;
destroyed? : boolean ;
} ;
2026-02-14 18:32:45 -05:00
const DEFAULT_LOG_TAIL_LINES = 200 ;
function resolveLogSliceWindow ( offset? : number , limit? : number ) {
const usingDefaultTail = offset === undefined && limit === undefined ;
const effectiveLimit =
typeof limit === "number" && Number . isFinite ( limit )
? limit
: usingDefaultTail
? DEFAULT_LOG_TAIL_LINES
: undefined ;
return { effectiveOffset : offset , effectiveLimit , usingDefaultTail } ;
}
function defaultTailNote ( totalLines : number , usingDefaultTail : boolean ) {
if ( ! usingDefaultTail || totalLines <= DEFAULT_LOG_TAIL_LINES ) {
return "" ;
}
return ` \ n \ n[showing last ${ DEFAULT_LOG_TAIL_LINES } of ${ totalLines } lines; pass offset/limit to page] ` ;
}
2026-02-14 22:54:16 +00:00
2026-01-14 05:39:59 +00:00
const processSchema = Type . Object ( {
2026-03-04 08:52:05 -05:00
action : Type.String ( {
description :
"Process action (list|attach|poll|log|write|send-keys|submit|paste|kill|clear|remove)" ,
} ) ,
2026-01-14 14:31:43 +00:00
sessionId : Type.Optional ( Type . String ( { description : "Session id for actions other than list" } ) ) ,
2026-01-14 05:39:59 +00:00
data : Type.Optional ( Type . String ( { description : "Data to write for write" } ) ) ,
2026-01-17 06:12:25 +00:00
keys : Type.Optional (
Type . Array ( Type . String ( ) , { description : "Key tokens to send for send-keys" } ) ,
) ,
2026-01-17 07:59:53 +00:00
hex : Type.Optional ( Type . Array ( Type . String ( ) , { description : "Hex bytes to send for send-keys" } ) ) ,
2026-01-17 06:12:25 +00:00
literal : Type.Optional ( Type . String ( { description : "Literal string for send-keys" } ) ) ,
text : Type.Optional ( Type . String ( { description : "Text to paste for paste" } ) ) ,
bracketed : Type.Optional ( Type . Boolean ( { description : "Wrap paste in bracketed mode" } ) ) ,
2026-01-14 05:39:59 +00:00
eof : Type.Optional ( Type . Boolean ( { description : "Close stdin after write" } ) ) ,
offset : Type.Optional ( Type . Number ( { description : "Log offset" } ) ) ,
limit : Type.Optional ( Type . Number ( { description : "Log length" } ) ) ,
Agents: add nested subagent orchestration controls and reduce subagent token waste (#14447)
* Agents: add subagent orchestration controls
* Agents: add subagent orchestration controls (WIP uncommitted changes)
* feat(subagents): add depth-based spawn gating for sub-sub-agents
* feat(subagents): tool policy, registry, and announce chain for nested agents
* feat(subagents): system prompt, docs, changelog for nested sub-agents
* fix(subagents): prevent model fallback override, show model during active runs, and block context overflow fallback
Bug 1: When a session has an explicit model override (e.g., gpt/openai-codex),
the fallback candidate logic in resolveFallbackCandidates silently appended the
global primary model (opus) as a backstop. On reinjection/steer with a transient
error, the session could fall back to opus which has a smaller context window
and crash. Fix: when storedModelOverride is set, pass fallbacksOverride ?? []
instead of undefined, preventing the implicit primary backstop.
Bug 2: Active subagents showed 'model n/a' in /subagents list because
resolveModelDisplay only read entry.model/modelProvider (populated after run
completes). Fix: fall back to modelOverride/providerOverride fields which are
populated at spawn time via sessions.patch.
Bug 3: Context overflow errors (prompt too long, context_length_exceeded) could
theoretically escape runEmbeddedPiAgent and be treated as failover candidates
in runWithModelFallback, causing a switch to a model with a smaller context
window. Fix: in runWithModelFallback, detect context overflow errors via
isLikelyContextOverflowError and rethrow them immediately instead of trying the
next model candidate.
* fix(subagents): track spawn depth in session store and fix announce routing for nested agents
* Fix compaction status tracking and dedupe overflow compaction triggers
* fix(subagents): enforce depth block via session store and implement cascade kill
* fix: inject group chat context into system prompt
* fix(subagents): always write model to session store at spawn time
* Preserve spawnDepth when agent handler rewrites session entry
* fix(subagents): suppress announce on steer-restart
* fix(subagents): fallback spawned session model to runtime default
* fix(subagents): enforce spawn depth when caller key resolves by sessionId
* feat(subagents): implement active-first ordering for numeric targets and enhance task display
- Added a test to verify that subagents with numeric targets follow an active-first list ordering.
- Updated `resolveSubagentTarget` to sort subagent runs based on active status and recent activity.
- Enhanced task display in command responses to prevent truncation of long task descriptions.
- Introduced new utility functions for compacting task text and managing subagent run states.
* fix(subagents): show model for active runs via run record fallback
When the spawned model matches the agent's default model, the session
store's override fields are intentionally cleared (isDefault: true).
The model/modelProvider fields are only populated after the run
completes. This left active subagents showing 'model n/a'.
Fix: store the resolved model on SubagentRunRecord at registration
time, and use it as a fallback in both display paths (subagents tool
and /subagents command) when the session store entry has no model info.
Changes:
- SubagentRunRecord: add optional model field
- registerSubagentRun: accept and persist model param
- sessions-spawn-tool: pass resolvedModel to registerSubagentRun
- subagents-tool: pass run record model as fallback to resolveModelDisplay
- commands-subagents: pass run record model as fallback to resolveModelDisplay
* feat(chat): implement session key resolution and reset on sidebar navigation
- Added functions to resolve the main session key and reset chat state when switching sessions from the sidebar.
- Updated the `renderTab` function to handle session key changes when navigating to the chat tab.
- Introduced a test to verify that the session resets to "main" when opening chat from the sidebar navigation.
* fix: subagent timeout=0 passthrough and fallback prompt duplication
Bug 1: runTimeoutSeconds=0 now means 'no timeout' instead of applying 600s default
- sessions-spawn-tool: default to undefined (not 0) when neither timeout param
is provided; use != null check so explicit 0 passes through to gateway
- agent.ts: accept 0 as valid timeout (resolveAgentTimeoutMs already handles
0 → MAX_SAFE_TIMEOUT_MS)
Bug 2: model fallback no longer re-injects the original prompt as a duplicate
- agent.ts: track fallback attempt index; on retries use a short continuation
message instead of the full original prompt since the session file already
contains it from the first attempt
- Also skip re-sending images on fallback retries (already in session)
* feat(subagents): truncate long task descriptions in subagents command output
- Introduced a new utility function to format task previews, limiting their length to improve readability.
- Updated the command handler to use the new formatting function, ensuring task descriptions are truncated appropriately.
- Adjusted related tests to verify that long task descriptions are now truncated in the output.
* refactor(subagents): update subagent registry path resolution and improve command output formatting
- Replaced direct import of STATE_DIR with a utility function to resolve the state directory dynamically.
- Enhanced the formatting of command output for active and recent subagents, adding separators for better readability.
- Updated related tests to reflect changes in command output structure.
* fix(subagent): default sessions_spawn to no timeout when runTimeoutSeconds omitted
The previous fix (75a791106) correctly handled the case where
runTimeoutSeconds was explicitly set to 0 ("no timeout"). However,
when models omit the parameter entirely (which is common since the
schema marks it as optional), runTimeoutSeconds resolved to undefined.
undefined flowed through the chain as:
sessions_spawn → timeout: undefined (since undefined != null is false)
→ gateway agent handler → agentCommand opts.timeout: undefined
→ resolveAgentTimeoutMs({ overrideSeconds: undefined })
→ DEFAULT_AGENT_TIMEOUT_SECONDS (600s = 10 minutes)
This caused subagents to be killed at exactly 10 minutes even though
the user's intent (via TOOLS.md) was for subagents to run without a
timeout.
Fix: default runTimeoutSeconds to 0 (no timeout) when neither
runTimeoutSeconds nor timeoutSeconds is provided by the caller.
Subagent spawns are long-running by design and should not inherit the
600s agent-command default timeout.
* fix(subagent): accept timeout=0 in agent-via-gateway path (second 600s default)
* fix: thread timeout override through getReplyFromConfig dispatch path
getReplyFromConfig called resolveAgentTimeoutMs({ cfg }) with no override,
always falling back to the config default (600s). Add timeoutOverrideSeconds
to GetReplyOptions and pass it through as overrideSeconds so callers of the
dispatch chain can specify a custom timeout (0 = no timeout).
This complements the existing timeout threading in agentCommand and the
cron isolated-agent runner, which already pass overrideSeconds correctly.
* feat(model-fallback): normalize OpenAI Codex model references and enhance fallback handling
- Added normalization for OpenAI Codex model references, specifically converting "gpt-5.3-codex" to "openai-codex" before execution.
- Updated the `resolveFallbackCandidates` function to utilize the new normalization logic.
- Enhanced tests to verify the correct behavior of model normalization and fallback mechanisms.
- Introduced a new test case to ensure that the normalization process works as expected for various input formats.
* feat(tests): add unit tests for steer failure behavior in openclaw-tools
- Introduced a new test file to validate the behavior of subagents when steer replacement dispatch fails.
- Implemented tests to ensure that the announce behavior is restored correctly and that the suppression reason is cleared as expected.
- Enhanced the subagent registry with a new function to clear steer restart suppression.
- Updated related components to support the new test scenarios.
* fix(subagents): replace stop command with kill in slash commands and documentation
- Updated the `/subagents` command to replace `stop` with `kill` for consistency in controlling sub-agent runs.
- Modified related documentation to reflect the change in command usage.
- Removed legacy timeoutSeconds references from the sessions-spawn-tool schema and tests to streamline timeout handling.
- Enhanced tests to ensure correct behavior of the updated commands and their interactions.
* feat(tests): add unit tests for readLatestAssistantReply function
- Introduced a new test file for the `readLatestAssistantReply` function to validate its behavior with various message scenarios.
- Implemented tests to ensure the function correctly retrieves the latest assistant message and handles cases where the latest message has no text.
- Mocked the gateway call to simulate different message histories for comprehensive testing.
* feat(tests): enhance subagent kill-all cascade tests and announce formatting
- Added a new test to verify that the `kill-all` command cascades through ended parents to active descendants in subagents.
- Updated the subagent announce formatting tests to reflect changes in message structure, including the replacement of "Findings:" with "Result:" and the addition of new expectations for message content.
- Improved the handling of long findings and stats in the announce formatting logic to ensure concise output.
- Refactored related functions to enhance clarity and maintainability in the subagent registry and tools.
* refactor(subagent): update announce formatting and remove unused constants
- Modified the subagent announce formatting to replace "Findings:" with "Result:" and adjusted related expectations in tests.
- Removed constants for maximum announce findings characters and summary words, simplifying the announcement logic.
- Updated the handling of findings to retain full content instead of truncating, ensuring more informative outputs.
- Cleaned up unused imports in the commands-subagents file to enhance code clarity.
* feat(tests): enhance billing error handling in user-facing text
- Added tests to ensure that normal text mentioning billing plans is not rewritten, preserving user context.
- Updated the `isBillingErrorMessage` and `sanitizeUserFacingText` functions to improve handling of billing-related messages.
- Introduced new test cases for various scenarios involving billing messages to ensure accurate processing and output.
- Enhanced the subagent announce flow to correctly manage active descendant runs, preventing premature announcements.
* feat(subagent): enhance workflow guidance and auto-announcement clarity
- Added a new guideline in the subagent system prompt to emphasize trust in push-based completion, discouraging busy polling for status updates.
- Updated documentation to clarify that sub-agents will automatically announce their results, improving user understanding of the workflow.
- Enhanced tests to verify the new guidance on avoiding polling loops and to ensure the accuracy of the updated prompts.
* fix(cron): avoid announcing interim subagent spawn acks
* chore: clean post-rebase imports
* fix(cron): fall back to child replies when parent stays interim
* fix(subagents): make active-run guidance advisory
* fix(subagents): update announce flow to handle active descendants and enhance test coverage
- Modified the announce flow to defer announcements when active descendant runs are present, ensuring accurate status reporting.
- Updated tests to verify the new behavior, including scenarios where no fallback requester is available and ensuring proper handling of finished subagents.
- Enhanced the announce formatting to include an `expectFinal` flag for better clarity in the announcement process.
* fix(subagents): enhance announce flow and formatting for user updates
- Updated the announce flow to provide clearer instructions for user updates based on active subagent runs and requester context.
- Refactored the announcement logic to improve clarity and ensure internal context remains private.
- Enhanced tests to verify the new message expectations and formatting, including updated prompts for user-facing updates.
- Introduced a new function to build reply instructions based on session context, improving the overall announcement process.
* fix: resolve prep blockers and changelog placement (#14447) (thanks @tyler6204)
* fix: restore cron delivery-plan import after rebase (#14447) (thanks @tyler6204)
* fix: resolve test failures from rebase conflicts (#14447) (thanks @tyler6204)
* fix: apply formatting after rebase (#14447) (thanks @tyler6204)
2026-02-14 22:03:45 -08:00
timeout : Type.Optional (
2026-02-15 22:45:44 +00:00
Type . Number ( {
Agents: add nested subagent orchestration controls and reduce subagent token waste (#14447)
* Agents: add subagent orchestration controls
* Agents: add subagent orchestration controls (WIP uncommitted changes)
* feat(subagents): add depth-based spawn gating for sub-sub-agents
* feat(subagents): tool policy, registry, and announce chain for nested agents
* feat(subagents): system prompt, docs, changelog for nested sub-agents
* fix(subagents): prevent model fallback override, show model during active runs, and block context overflow fallback
Bug 1: When a session has an explicit model override (e.g., gpt/openai-codex),
the fallback candidate logic in resolveFallbackCandidates silently appended the
global primary model (opus) as a backstop. On reinjection/steer with a transient
error, the session could fall back to opus which has a smaller context window
and crash. Fix: when storedModelOverride is set, pass fallbacksOverride ?? []
instead of undefined, preventing the implicit primary backstop.
Bug 2: Active subagents showed 'model n/a' in /subagents list because
resolveModelDisplay only read entry.model/modelProvider (populated after run
completes). Fix: fall back to modelOverride/providerOverride fields which are
populated at spawn time via sessions.patch.
Bug 3: Context overflow errors (prompt too long, context_length_exceeded) could
theoretically escape runEmbeddedPiAgent and be treated as failover candidates
in runWithModelFallback, causing a switch to a model with a smaller context
window. Fix: in runWithModelFallback, detect context overflow errors via
isLikelyContextOverflowError and rethrow them immediately instead of trying the
next model candidate.
* fix(subagents): track spawn depth in session store and fix announce routing for nested agents
* Fix compaction status tracking and dedupe overflow compaction triggers
* fix(subagents): enforce depth block via session store and implement cascade kill
* fix: inject group chat context into system prompt
* fix(subagents): always write model to session store at spawn time
* Preserve spawnDepth when agent handler rewrites session entry
* fix(subagents): suppress announce on steer-restart
* fix(subagents): fallback spawned session model to runtime default
* fix(subagents): enforce spawn depth when caller key resolves by sessionId
* feat(subagents): implement active-first ordering for numeric targets and enhance task display
- Added a test to verify that subagents with numeric targets follow an active-first list ordering.
- Updated `resolveSubagentTarget` to sort subagent runs based on active status and recent activity.
- Enhanced task display in command responses to prevent truncation of long task descriptions.
- Introduced new utility functions for compacting task text and managing subagent run states.
* fix(subagents): show model for active runs via run record fallback
When the spawned model matches the agent's default model, the session
store's override fields are intentionally cleared (isDefault: true).
The model/modelProvider fields are only populated after the run
completes. This left active subagents showing 'model n/a'.
Fix: store the resolved model on SubagentRunRecord at registration
time, and use it as a fallback in both display paths (subagents tool
and /subagents command) when the session store entry has no model info.
Changes:
- SubagentRunRecord: add optional model field
- registerSubagentRun: accept and persist model param
- sessions-spawn-tool: pass resolvedModel to registerSubagentRun
- subagents-tool: pass run record model as fallback to resolveModelDisplay
- commands-subagents: pass run record model as fallback to resolveModelDisplay
* feat(chat): implement session key resolution and reset on sidebar navigation
- Added functions to resolve the main session key and reset chat state when switching sessions from the sidebar.
- Updated the `renderTab` function to handle session key changes when navigating to the chat tab.
- Introduced a test to verify that the session resets to "main" when opening chat from the sidebar navigation.
* fix: subagent timeout=0 passthrough and fallback prompt duplication
Bug 1: runTimeoutSeconds=0 now means 'no timeout' instead of applying 600s default
- sessions-spawn-tool: default to undefined (not 0) when neither timeout param
is provided; use != null check so explicit 0 passes through to gateway
- agent.ts: accept 0 as valid timeout (resolveAgentTimeoutMs already handles
0 → MAX_SAFE_TIMEOUT_MS)
Bug 2: model fallback no longer re-injects the original prompt as a duplicate
- agent.ts: track fallback attempt index; on retries use a short continuation
message instead of the full original prompt since the session file already
contains it from the first attempt
- Also skip re-sending images on fallback retries (already in session)
* feat(subagents): truncate long task descriptions in subagents command output
- Introduced a new utility function to format task previews, limiting their length to improve readability.
- Updated the command handler to use the new formatting function, ensuring task descriptions are truncated appropriately.
- Adjusted related tests to verify that long task descriptions are now truncated in the output.
* refactor(subagents): update subagent registry path resolution and improve command output formatting
- Replaced direct import of STATE_DIR with a utility function to resolve the state directory dynamically.
- Enhanced the formatting of command output for active and recent subagents, adding separators for better readability.
- Updated related tests to reflect changes in command output structure.
* fix(subagent): default sessions_spawn to no timeout when runTimeoutSeconds omitted
The previous fix (75a791106) correctly handled the case where
runTimeoutSeconds was explicitly set to 0 ("no timeout"). However,
when models omit the parameter entirely (which is common since the
schema marks it as optional), runTimeoutSeconds resolved to undefined.
undefined flowed through the chain as:
sessions_spawn → timeout: undefined (since undefined != null is false)
→ gateway agent handler → agentCommand opts.timeout: undefined
→ resolveAgentTimeoutMs({ overrideSeconds: undefined })
→ DEFAULT_AGENT_TIMEOUT_SECONDS (600s = 10 minutes)
This caused subagents to be killed at exactly 10 minutes even though
the user's intent (via TOOLS.md) was for subagents to run without a
timeout.
Fix: default runTimeoutSeconds to 0 (no timeout) when neither
runTimeoutSeconds nor timeoutSeconds is provided by the caller.
Subagent spawns are long-running by design and should not inherit the
600s agent-command default timeout.
* fix(subagent): accept timeout=0 in agent-via-gateway path (second 600s default)
* fix: thread timeout override through getReplyFromConfig dispatch path
getReplyFromConfig called resolveAgentTimeoutMs({ cfg }) with no override,
always falling back to the config default (600s). Add timeoutOverrideSeconds
to GetReplyOptions and pass it through as overrideSeconds so callers of the
dispatch chain can specify a custom timeout (0 = no timeout).
This complements the existing timeout threading in agentCommand and the
cron isolated-agent runner, which already pass overrideSeconds correctly.
* feat(model-fallback): normalize OpenAI Codex model references and enhance fallback handling
- Added normalization for OpenAI Codex model references, specifically converting "gpt-5.3-codex" to "openai-codex" before execution.
- Updated the `resolveFallbackCandidates` function to utilize the new normalization logic.
- Enhanced tests to verify the correct behavior of model normalization and fallback mechanisms.
- Introduced a new test case to ensure that the normalization process works as expected for various input formats.
* feat(tests): add unit tests for steer failure behavior in openclaw-tools
- Introduced a new test file to validate the behavior of subagents when steer replacement dispatch fails.
- Implemented tests to ensure that the announce behavior is restored correctly and that the suppression reason is cleared as expected.
- Enhanced the subagent registry with a new function to clear steer restart suppression.
- Updated related components to support the new test scenarios.
* fix(subagents): replace stop command with kill in slash commands and documentation
- Updated the `/subagents` command to replace `stop` with `kill` for consistency in controlling sub-agent runs.
- Modified related documentation to reflect the change in command usage.
- Removed legacy timeoutSeconds references from the sessions-spawn-tool schema and tests to streamline timeout handling.
- Enhanced tests to ensure correct behavior of the updated commands and their interactions.
* feat(tests): add unit tests for readLatestAssistantReply function
- Introduced a new test file for the `readLatestAssistantReply` function to validate its behavior with various message scenarios.
- Implemented tests to ensure the function correctly retrieves the latest assistant message and handles cases where the latest message has no text.
- Mocked the gateway call to simulate different message histories for comprehensive testing.
* feat(tests): enhance subagent kill-all cascade tests and announce formatting
- Added a new test to verify that the `kill-all` command cascades through ended parents to active descendants in subagents.
- Updated the subagent announce formatting tests to reflect changes in message structure, including the replacement of "Findings:" with "Result:" and the addition of new expectations for message content.
- Improved the handling of long findings and stats in the announce formatting logic to ensure concise output.
- Refactored related functions to enhance clarity and maintainability in the subagent registry and tools.
* refactor(subagent): update announce formatting and remove unused constants
- Modified the subagent announce formatting to replace "Findings:" with "Result:" and adjusted related expectations in tests.
- Removed constants for maximum announce findings characters and summary words, simplifying the announcement logic.
- Updated the handling of findings to retain full content instead of truncating, ensuring more informative outputs.
- Cleaned up unused imports in the commands-subagents file to enhance code clarity.
* feat(tests): enhance billing error handling in user-facing text
- Added tests to ensure that normal text mentioning billing plans is not rewritten, preserving user context.
- Updated the `isBillingErrorMessage` and `sanitizeUserFacingText` functions to improve handling of billing-related messages.
- Introduced new test cases for various scenarios involving billing messages to ensure accurate processing and output.
- Enhanced the subagent announce flow to correctly manage active descendant runs, preventing premature announcements.
* feat(subagent): enhance workflow guidance and auto-announcement clarity
- Added a new guideline in the subagent system prompt to emphasize trust in push-based completion, discouraging busy polling for status updates.
- Updated documentation to clarify that sub-agents will automatically announce their results, improving user understanding of the workflow.
- Enhanced tests to verify the new guidance on avoiding polling loops and to ensure the accuracy of the updated prompts.
* fix(cron): avoid announcing interim subagent spawn acks
* chore: clean post-rebase imports
* fix(cron): fall back to child replies when parent stays interim
* fix(subagents): make active-run guidance advisory
* fix(subagents): update announce flow to handle active descendants and enhance test coverage
- Modified the announce flow to defer announcements when active descendant runs are present, ensuring accurate status reporting.
- Updated tests to verify the new behavior, including scenarios where no fallback requester is available and ensuring proper handling of finished subagents.
- Enhanced the announce formatting to include an `expectFinal` flag for better clarity in the announcement process.
* fix(subagents): enhance announce flow and formatting for user updates
- Updated the announce flow to provide clearer instructions for user updates based on active subagent runs and requester context.
- Refactored the announcement logic to improve clarity and ensure internal context remains private.
- Enhanced tests to verify the new message expectations and formatting, including updated prompts for user-facing updates.
- Introduced a new function to build reply instructions based on session context, improving the overall announcement process.
* fix: resolve prep blockers and changelog placement (#14447) (thanks @tyler6204)
* fix: restore cron delivery-plan import after rebase (#14447) (thanks @tyler6204)
* fix: resolve test failures from rebase conflicts (#14447) (thanks @tyler6204)
* fix: apply formatting after rebase (#14447) (thanks @tyler6204)
2026-02-14 22:03:45 -08:00
description : "For poll: wait up to this many milliseconds before returning" ,
2026-02-15 22:45:44 +00:00
minimum : 0 ,
Agents: add nested subagent orchestration controls and reduce subagent token waste (#14447)
* Agents: add subagent orchestration controls
* Agents: add subagent orchestration controls (WIP uncommitted changes)
* feat(subagents): add depth-based spawn gating for sub-sub-agents
* feat(subagents): tool policy, registry, and announce chain for nested agents
* feat(subagents): system prompt, docs, changelog for nested sub-agents
* fix(subagents): prevent model fallback override, show model during active runs, and block context overflow fallback
Bug 1: When a session has an explicit model override (e.g., gpt/openai-codex),
the fallback candidate logic in resolveFallbackCandidates silently appended the
global primary model (opus) as a backstop. On reinjection/steer with a transient
error, the session could fall back to opus which has a smaller context window
and crash. Fix: when storedModelOverride is set, pass fallbacksOverride ?? []
instead of undefined, preventing the implicit primary backstop.
Bug 2: Active subagents showed 'model n/a' in /subagents list because
resolveModelDisplay only read entry.model/modelProvider (populated after run
completes). Fix: fall back to modelOverride/providerOverride fields which are
populated at spawn time via sessions.patch.
Bug 3: Context overflow errors (prompt too long, context_length_exceeded) could
theoretically escape runEmbeddedPiAgent and be treated as failover candidates
in runWithModelFallback, causing a switch to a model with a smaller context
window. Fix: in runWithModelFallback, detect context overflow errors via
isLikelyContextOverflowError and rethrow them immediately instead of trying the
next model candidate.
* fix(subagents): track spawn depth in session store and fix announce routing for nested agents
* Fix compaction status tracking and dedupe overflow compaction triggers
* fix(subagents): enforce depth block via session store and implement cascade kill
* fix: inject group chat context into system prompt
* fix(subagents): always write model to session store at spawn time
* Preserve spawnDepth when agent handler rewrites session entry
* fix(subagents): suppress announce on steer-restart
* fix(subagents): fallback spawned session model to runtime default
* fix(subagents): enforce spawn depth when caller key resolves by sessionId
* feat(subagents): implement active-first ordering for numeric targets and enhance task display
- Added a test to verify that subagents with numeric targets follow an active-first list ordering.
- Updated `resolveSubagentTarget` to sort subagent runs based on active status and recent activity.
- Enhanced task display in command responses to prevent truncation of long task descriptions.
- Introduced new utility functions for compacting task text and managing subagent run states.
* fix(subagents): show model for active runs via run record fallback
When the spawned model matches the agent's default model, the session
store's override fields are intentionally cleared (isDefault: true).
The model/modelProvider fields are only populated after the run
completes. This left active subagents showing 'model n/a'.
Fix: store the resolved model on SubagentRunRecord at registration
time, and use it as a fallback in both display paths (subagents tool
and /subagents command) when the session store entry has no model info.
Changes:
- SubagentRunRecord: add optional model field
- registerSubagentRun: accept and persist model param
- sessions-spawn-tool: pass resolvedModel to registerSubagentRun
- subagents-tool: pass run record model as fallback to resolveModelDisplay
- commands-subagents: pass run record model as fallback to resolveModelDisplay
* feat(chat): implement session key resolution and reset on sidebar navigation
- Added functions to resolve the main session key and reset chat state when switching sessions from the sidebar.
- Updated the `renderTab` function to handle session key changes when navigating to the chat tab.
- Introduced a test to verify that the session resets to "main" when opening chat from the sidebar navigation.
* fix: subagent timeout=0 passthrough and fallback prompt duplication
Bug 1: runTimeoutSeconds=0 now means 'no timeout' instead of applying 600s default
- sessions-spawn-tool: default to undefined (not 0) when neither timeout param
is provided; use != null check so explicit 0 passes through to gateway
- agent.ts: accept 0 as valid timeout (resolveAgentTimeoutMs already handles
0 → MAX_SAFE_TIMEOUT_MS)
Bug 2: model fallback no longer re-injects the original prompt as a duplicate
- agent.ts: track fallback attempt index; on retries use a short continuation
message instead of the full original prompt since the session file already
contains it from the first attempt
- Also skip re-sending images on fallback retries (already in session)
* feat(subagents): truncate long task descriptions in subagents command output
- Introduced a new utility function to format task previews, limiting their length to improve readability.
- Updated the command handler to use the new formatting function, ensuring task descriptions are truncated appropriately.
- Adjusted related tests to verify that long task descriptions are now truncated in the output.
* refactor(subagents): update subagent registry path resolution and improve command output formatting
- Replaced direct import of STATE_DIR with a utility function to resolve the state directory dynamically.
- Enhanced the formatting of command output for active and recent subagents, adding separators for better readability.
- Updated related tests to reflect changes in command output structure.
* fix(subagent): default sessions_spawn to no timeout when runTimeoutSeconds omitted
The previous fix (75a791106) correctly handled the case where
runTimeoutSeconds was explicitly set to 0 ("no timeout"). However,
when models omit the parameter entirely (which is common since the
schema marks it as optional), runTimeoutSeconds resolved to undefined.
undefined flowed through the chain as:
sessions_spawn → timeout: undefined (since undefined != null is false)
→ gateway agent handler → agentCommand opts.timeout: undefined
→ resolveAgentTimeoutMs({ overrideSeconds: undefined })
→ DEFAULT_AGENT_TIMEOUT_SECONDS (600s = 10 minutes)
This caused subagents to be killed at exactly 10 minutes even though
the user's intent (via TOOLS.md) was for subagents to run without a
timeout.
Fix: default runTimeoutSeconds to 0 (no timeout) when neither
runTimeoutSeconds nor timeoutSeconds is provided by the caller.
Subagent spawns are long-running by design and should not inherit the
600s agent-command default timeout.
* fix(subagent): accept timeout=0 in agent-via-gateway path (second 600s default)
* fix: thread timeout override through getReplyFromConfig dispatch path
getReplyFromConfig called resolveAgentTimeoutMs({ cfg }) with no override,
always falling back to the config default (600s). Add timeoutOverrideSeconds
to GetReplyOptions and pass it through as overrideSeconds so callers of the
dispatch chain can specify a custom timeout (0 = no timeout).
This complements the existing timeout threading in agentCommand and the
cron isolated-agent runner, which already pass overrideSeconds correctly.
* feat(model-fallback): normalize OpenAI Codex model references and enhance fallback handling
- Added normalization for OpenAI Codex model references, specifically converting "gpt-5.3-codex" to "openai-codex" before execution.
- Updated the `resolveFallbackCandidates` function to utilize the new normalization logic.
- Enhanced tests to verify the correct behavior of model normalization and fallback mechanisms.
- Introduced a new test case to ensure that the normalization process works as expected for various input formats.
* feat(tests): add unit tests for steer failure behavior in openclaw-tools
- Introduced a new test file to validate the behavior of subagents when steer replacement dispatch fails.
- Implemented tests to ensure that the announce behavior is restored correctly and that the suppression reason is cleared as expected.
- Enhanced the subagent registry with a new function to clear steer restart suppression.
- Updated related components to support the new test scenarios.
* fix(subagents): replace stop command with kill in slash commands and documentation
- Updated the `/subagents` command to replace `stop` with `kill` for consistency in controlling sub-agent runs.
- Modified related documentation to reflect the change in command usage.
- Removed legacy timeoutSeconds references from the sessions-spawn-tool schema and tests to streamline timeout handling.
- Enhanced tests to ensure correct behavior of the updated commands and their interactions.
* feat(tests): add unit tests for readLatestAssistantReply function
- Introduced a new test file for the `readLatestAssistantReply` function to validate its behavior with various message scenarios.
- Implemented tests to ensure the function correctly retrieves the latest assistant message and handles cases where the latest message has no text.
- Mocked the gateway call to simulate different message histories for comprehensive testing.
* feat(tests): enhance subagent kill-all cascade tests and announce formatting
- Added a new test to verify that the `kill-all` command cascades through ended parents to active descendants in subagents.
- Updated the subagent announce formatting tests to reflect changes in message structure, including the replacement of "Findings:" with "Result:" and the addition of new expectations for message content.
- Improved the handling of long findings and stats in the announce formatting logic to ensure concise output.
- Refactored related functions to enhance clarity and maintainability in the subagent registry and tools.
* refactor(subagent): update announce formatting and remove unused constants
- Modified the subagent announce formatting to replace "Findings:" with "Result:" and adjusted related expectations in tests.
- Removed constants for maximum announce findings characters and summary words, simplifying the announcement logic.
- Updated the handling of findings to retain full content instead of truncating, ensuring more informative outputs.
- Cleaned up unused imports in the commands-subagents file to enhance code clarity.
* feat(tests): enhance billing error handling in user-facing text
- Added tests to ensure that normal text mentioning billing plans is not rewritten, preserving user context.
- Updated the `isBillingErrorMessage` and `sanitizeUserFacingText` functions to improve handling of billing-related messages.
- Introduced new test cases for various scenarios involving billing messages to ensure accurate processing and output.
- Enhanced the subagent announce flow to correctly manage active descendant runs, preventing premature announcements.
* feat(subagent): enhance workflow guidance and auto-announcement clarity
- Added a new guideline in the subagent system prompt to emphasize trust in push-based completion, discouraging busy polling for status updates.
- Updated documentation to clarify that sub-agents will automatically announce their results, improving user understanding of the workflow.
- Enhanced tests to verify the new guidance on avoiding polling loops and to ensure the accuracy of the updated prompts.
* fix(cron): avoid announcing interim subagent spawn acks
* chore: clean post-rebase imports
* fix(cron): fall back to child replies when parent stays interim
* fix(subagents): make active-run guidance advisory
* fix(subagents): update announce flow to handle active descendants and enhance test coverage
- Modified the announce flow to defer announcements when active descendant runs are present, ensuring accurate status reporting.
- Updated tests to verify the new behavior, including scenarios where no fallback requester is available and ensuring proper handling of finished subagents.
- Enhanced the announce formatting to include an `expectFinal` flag for better clarity in the announcement process.
* fix(subagents): enhance announce flow and formatting for user updates
- Updated the announce flow to provide clearer instructions for user updates based on active subagent runs and requester context.
- Refactored the announcement logic to improve clarity and ensure internal context remains private.
- Enhanced tests to verify the new message expectations and formatting, including updated prompts for user-facing updates.
- Introduced a new function to build reply instructions based on session context, improving the overall announcement process.
* fix: resolve prep blockers and changelog placement (#14447) (thanks @tyler6204)
* fix: restore cron delivery-plan import after rebase (#14447) (thanks @tyler6204)
* fix: resolve test failures from rebase conflicts (#14447) (thanks @tyler6204)
* fix: apply formatting after rebase (#14447) (thanks @tyler6204)
2026-02-14 22:03:45 -08:00
} ) ,
) ,
2026-01-14 05:39:59 +00:00
} ) ;
Agents: add nested subagent orchestration controls and reduce subagent token waste (#14447)
* Agents: add subagent orchestration controls
* Agents: add subagent orchestration controls (WIP uncommitted changes)
* feat(subagents): add depth-based spawn gating for sub-sub-agents
* feat(subagents): tool policy, registry, and announce chain for nested agents
* feat(subagents): system prompt, docs, changelog for nested sub-agents
* fix(subagents): prevent model fallback override, show model during active runs, and block context overflow fallback
Bug 1: When a session has an explicit model override (e.g., gpt/openai-codex),
the fallback candidate logic in resolveFallbackCandidates silently appended the
global primary model (opus) as a backstop. On reinjection/steer with a transient
error, the session could fall back to opus which has a smaller context window
and crash. Fix: when storedModelOverride is set, pass fallbacksOverride ?? []
instead of undefined, preventing the implicit primary backstop.
Bug 2: Active subagents showed 'model n/a' in /subagents list because
resolveModelDisplay only read entry.model/modelProvider (populated after run
completes). Fix: fall back to modelOverride/providerOverride fields which are
populated at spawn time via sessions.patch.
Bug 3: Context overflow errors (prompt too long, context_length_exceeded) could
theoretically escape runEmbeddedPiAgent and be treated as failover candidates
in runWithModelFallback, causing a switch to a model with a smaller context
window. Fix: in runWithModelFallback, detect context overflow errors via
isLikelyContextOverflowError and rethrow them immediately instead of trying the
next model candidate.
* fix(subagents): track spawn depth in session store and fix announce routing for nested agents
* Fix compaction status tracking and dedupe overflow compaction triggers
* fix(subagents): enforce depth block via session store and implement cascade kill
* fix: inject group chat context into system prompt
* fix(subagents): always write model to session store at spawn time
* Preserve spawnDepth when agent handler rewrites session entry
* fix(subagents): suppress announce on steer-restart
* fix(subagents): fallback spawned session model to runtime default
* fix(subagents): enforce spawn depth when caller key resolves by sessionId
* feat(subagents): implement active-first ordering for numeric targets and enhance task display
- Added a test to verify that subagents with numeric targets follow an active-first list ordering.
- Updated `resolveSubagentTarget` to sort subagent runs based on active status and recent activity.
- Enhanced task display in command responses to prevent truncation of long task descriptions.
- Introduced new utility functions for compacting task text and managing subagent run states.
* fix(subagents): show model for active runs via run record fallback
When the spawned model matches the agent's default model, the session
store's override fields are intentionally cleared (isDefault: true).
The model/modelProvider fields are only populated after the run
completes. This left active subagents showing 'model n/a'.
Fix: store the resolved model on SubagentRunRecord at registration
time, and use it as a fallback in both display paths (subagents tool
and /subagents command) when the session store entry has no model info.
Changes:
- SubagentRunRecord: add optional model field
- registerSubagentRun: accept and persist model param
- sessions-spawn-tool: pass resolvedModel to registerSubagentRun
- subagents-tool: pass run record model as fallback to resolveModelDisplay
- commands-subagents: pass run record model as fallback to resolveModelDisplay
* feat(chat): implement session key resolution and reset on sidebar navigation
- Added functions to resolve the main session key and reset chat state when switching sessions from the sidebar.
- Updated the `renderTab` function to handle session key changes when navigating to the chat tab.
- Introduced a test to verify that the session resets to "main" when opening chat from the sidebar navigation.
* fix: subagent timeout=0 passthrough and fallback prompt duplication
Bug 1: runTimeoutSeconds=0 now means 'no timeout' instead of applying 600s default
- sessions-spawn-tool: default to undefined (not 0) when neither timeout param
is provided; use != null check so explicit 0 passes through to gateway
- agent.ts: accept 0 as valid timeout (resolveAgentTimeoutMs already handles
0 → MAX_SAFE_TIMEOUT_MS)
Bug 2: model fallback no longer re-injects the original prompt as a duplicate
- agent.ts: track fallback attempt index; on retries use a short continuation
message instead of the full original prompt since the session file already
contains it from the first attempt
- Also skip re-sending images on fallback retries (already in session)
* feat(subagents): truncate long task descriptions in subagents command output
- Introduced a new utility function to format task previews, limiting their length to improve readability.
- Updated the command handler to use the new formatting function, ensuring task descriptions are truncated appropriately.
- Adjusted related tests to verify that long task descriptions are now truncated in the output.
* refactor(subagents): update subagent registry path resolution and improve command output formatting
- Replaced direct import of STATE_DIR with a utility function to resolve the state directory dynamically.
- Enhanced the formatting of command output for active and recent subagents, adding separators for better readability.
- Updated related tests to reflect changes in command output structure.
* fix(subagent): default sessions_spawn to no timeout when runTimeoutSeconds omitted
The previous fix (75a791106) correctly handled the case where
runTimeoutSeconds was explicitly set to 0 ("no timeout"). However,
when models omit the parameter entirely (which is common since the
schema marks it as optional), runTimeoutSeconds resolved to undefined.
undefined flowed through the chain as:
sessions_spawn → timeout: undefined (since undefined != null is false)
→ gateway agent handler → agentCommand opts.timeout: undefined
→ resolveAgentTimeoutMs({ overrideSeconds: undefined })
→ DEFAULT_AGENT_TIMEOUT_SECONDS (600s = 10 minutes)
This caused subagents to be killed at exactly 10 minutes even though
the user's intent (via TOOLS.md) was for subagents to run without a
timeout.
Fix: default runTimeoutSeconds to 0 (no timeout) when neither
runTimeoutSeconds nor timeoutSeconds is provided by the caller.
Subagent spawns are long-running by design and should not inherit the
600s agent-command default timeout.
* fix(subagent): accept timeout=0 in agent-via-gateway path (second 600s default)
* fix: thread timeout override through getReplyFromConfig dispatch path
getReplyFromConfig called resolveAgentTimeoutMs({ cfg }) with no override,
always falling back to the config default (600s). Add timeoutOverrideSeconds
to GetReplyOptions and pass it through as overrideSeconds so callers of the
dispatch chain can specify a custom timeout (0 = no timeout).
This complements the existing timeout threading in agentCommand and the
cron isolated-agent runner, which already pass overrideSeconds correctly.
* feat(model-fallback): normalize OpenAI Codex model references and enhance fallback handling
- Added normalization for OpenAI Codex model references, specifically converting "gpt-5.3-codex" to "openai-codex" before execution.
- Updated the `resolveFallbackCandidates` function to utilize the new normalization logic.
- Enhanced tests to verify the correct behavior of model normalization and fallback mechanisms.
- Introduced a new test case to ensure that the normalization process works as expected for various input formats.
* feat(tests): add unit tests for steer failure behavior in openclaw-tools
- Introduced a new test file to validate the behavior of subagents when steer replacement dispatch fails.
- Implemented tests to ensure that the announce behavior is restored correctly and that the suppression reason is cleared as expected.
- Enhanced the subagent registry with a new function to clear steer restart suppression.
- Updated related components to support the new test scenarios.
* fix(subagents): replace stop command with kill in slash commands and documentation
- Updated the `/subagents` command to replace `stop` with `kill` for consistency in controlling sub-agent runs.
- Modified related documentation to reflect the change in command usage.
- Removed legacy timeoutSeconds references from the sessions-spawn-tool schema and tests to streamline timeout handling.
- Enhanced tests to ensure correct behavior of the updated commands and their interactions.
* feat(tests): add unit tests for readLatestAssistantReply function
- Introduced a new test file for the `readLatestAssistantReply` function to validate its behavior with various message scenarios.
- Implemented tests to ensure the function correctly retrieves the latest assistant message and handles cases where the latest message has no text.
- Mocked the gateway call to simulate different message histories for comprehensive testing.
* feat(tests): enhance subagent kill-all cascade tests and announce formatting
- Added a new test to verify that the `kill-all` command cascades through ended parents to active descendants in subagents.
- Updated the subagent announce formatting tests to reflect changes in message structure, including the replacement of "Findings:" with "Result:" and the addition of new expectations for message content.
- Improved the handling of long findings and stats in the announce formatting logic to ensure concise output.
- Refactored related functions to enhance clarity and maintainability in the subagent registry and tools.
* refactor(subagent): update announce formatting and remove unused constants
- Modified the subagent announce formatting to replace "Findings:" with "Result:" and adjusted related expectations in tests.
- Removed constants for maximum announce findings characters and summary words, simplifying the announcement logic.
- Updated the handling of findings to retain full content instead of truncating, ensuring more informative outputs.
- Cleaned up unused imports in the commands-subagents file to enhance code clarity.
* feat(tests): enhance billing error handling in user-facing text
- Added tests to ensure that normal text mentioning billing plans is not rewritten, preserving user context.
- Updated the `isBillingErrorMessage` and `sanitizeUserFacingText` functions to improve handling of billing-related messages.
- Introduced new test cases for various scenarios involving billing messages to ensure accurate processing and output.
- Enhanced the subagent announce flow to correctly manage active descendant runs, preventing premature announcements.
* feat(subagent): enhance workflow guidance and auto-announcement clarity
- Added a new guideline in the subagent system prompt to emphasize trust in push-based completion, discouraging busy polling for status updates.
- Updated documentation to clarify that sub-agents will automatically announce their results, improving user understanding of the workflow.
- Enhanced tests to verify the new guidance on avoiding polling loops and to ensure the accuracy of the updated prompts.
* fix(cron): avoid announcing interim subagent spawn acks
* chore: clean post-rebase imports
* fix(cron): fall back to child replies when parent stays interim
* fix(subagents): make active-run guidance advisory
* fix(subagents): update announce flow to handle active descendants and enhance test coverage
- Modified the announce flow to defer announcements when active descendant runs are present, ensuring accurate status reporting.
- Updated tests to verify the new behavior, including scenarios where no fallback requester is available and ensuring proper handling of finished subagents.
- Enhanced the announce formatting to include an `expectFinal` flag for better clarity in the announcement process.
* fix(subagents): enhance announce flow and formatting for user updates
- Updated the announce flow to provide clearer instructions for user updates based on active subagent runs and requester context.
- Refactored the announcement logic to improve clarity and ensure internal context remains private.
- Enhanced tests to verify the new message expectations and formatting, including updated prompts for user-facing updates.
- Introduced a new function to build reply instructions based on session context, improving the overall announcement process.
* fix: resolve prep blockers and changelog placement (#14447) (thanks @tyler6204)
* fix: restore cron delivery-plan import after rebase (#14447) (thanks @tyler6204)
* fix: resolve test failures from rebase conflicts (#14447) (thanks @tyler6204)
* fix: apply formatting after rebase (#14447) (thanks @tyler6204)
2026-02-14 22:03:45 -08:00
const MAX_POLL_WAIT_MS = 120 _000 ;
2026-03-04 08:52:05 -05:00
const DEFAULT_INPUT_WAIT_IDLE_MS = 15 _000 ;
const MIN_INPUT_WAIT_IDLE_MS = 1 _000 ;
const MAX_INPUT_WAIT_IDLE_MS = 10 * 60 * 1000 ;
Agents: add nested subagent orchestration controls and reduce subagent token waste (#14447)
* Agents: add subagent orchestration controls
* Agents: add subagent orchestration controls (WIP uncommitted changes)
* feat(subagents): add depth-based spawn gating for sub-sub-agents
* feat(subagents): tool policy, registry, and announce chain for nested agents
* feat(subagents): system prompt, docs, changelog for nested sub-agents
* fix(subagents): prevent model fallback override, show model during active runs, and block context overflow fallback
Bug 1: When a session has an explicit model override (e.g., gpt/openai-codex),
the fallback candidate logic in resolveFallbackCandidates silently appended the
global primary model (opus) as a backstop. On reinjection/steer with a transient
error, the session could fall back to opus which has a smaller context window
and crash. Fix: when storedModelOverride is set, pass fallbacksOverride ?? []
instead of undefined, preventing the implicit primary backstop.
Bug 2: Active subagents showed 'model n/a' in /subagents list because
resolveModelDisplay only read entry.model/modelProvider (populated after run
completes). Fix: fall back to modelOverride/providerOverride fields which are
populated at spawn time via sessions.patch.
Bug 3: Context overflow errors (prompt too long, context_length_exceeded) could
theoretically escape runEmbeddedPiAgent and be treated as failover candidates
in runWithModelFallback, causing a switch to a model with a smaller context
window. Fix: in runWithModelFallback, detect context overflow errors via
isLikelyContextOverflowError and rethrow them immediately instead of trying the
next model candidate.
* fix(subagents): track spawn depth in session store and fix announce routing for nested agents
* Fix compaction status tracking and dedupe overflow compaction triggers
* fix(subagents): enforce depth block via session store and implement cascade kill
* fix: inject group chat context into system prompt
* fix(subagents): always write model to session store at spawn time
* Preserve spawnDepth when agent handler rewrites session entry
* fix(subagents): suppress announce on steer-restart
* fix(subagents): fallback spawned session model to runtime default
* fix(subagents): enforce spawn depth when caller key resolves by sessionId
* feat(subagents): implement active-first ordering for numeric targets and enhance task display
- Added a test to verify that subagents with numeric targets follow an active-first list ordering.
- Updated `resolveSubagentTarget` to sort subagent runs based on active status and recent activity.
- Enhanced task display in command responses to prevent truncation of long task descriptions.
- Introduced new utility functions for compacting task text and managing subagent run states.
* fix(subagents): show model for active runs via run record fallback
When the spawned model matches the agent's default model, the session
store's override fields are intentionally cleared (isDefault: true).
The model/modelProvider fields are only populated after the run
completes. This left active subagents showing 'model n/a'.
Fix: store the resolved model on SubagentRunRecord at registration
time, and use it as a fallback in both display paths (subagents tool
and /subagents command) when the session store entry has no model info.
Changes:
- SubagentRunRecord: add optional model field
- registerSubagentRun: accept and persist model param
- sessions-spawn-tool: pass resolvedModel to registerSubagentRun
- subagents-tool: pass run record model as fallback to resolveModelDisplay
- commands-subagents: pass run record model as fallback to resolveModelDisplay
* feat(chat): implement session key resolution and reset on sidebar navigation
- Added functions to resolve the main session key and reset chat state when switching sessions from the sidebar.
- Updated the `renderTab` function to handle session key changes when navigating to the chat tab.
- Introduced a test to verify that the session resets to "main" when opening chat from the sidebar navigation.
* fix: subagent timeout=0 passthrough and fallback prompt duplication
Bug 1: runTimeoutSeconds=0 now means 'no timeout' instead of applying 600s default
- sessions-spawn-tool: default to undefined (not 0) when neither timeout param
is provided; use != null check so explicit 0 passes through to gateway
- agent.ts: accept 0 as valid timeout (resolveAgentTimeoutMs already handles
0 → MAX_SAFE_TIMEOUT_MS)
Bug 2: model fallback no longer re-injects the original prompt as a duplicate
- agent.ts: track fallback attempt index; on retries use a short continuation
message instead of the full original prompt since the session file already
contains it from the first attempt
- Also skip re-sending images on fallback retries (already in session)
* feat(subagents): truncate long task descriptions in subagents command output
- Introduced a new utility function to format task previews, limiting their length to improve readability.
- Updated the command handler to use the new formatting function, ensuring task descriptions are truncated appropriately.
- Adjusted related tests to verify that long task descriptions are now truncated in the output.
* refactor(subagents): update subagent registry path resolution and improve command output formatting
- Replaced direct import of STATE_DIR with a utility function to resolve the state directory dynamically.
- Enhanced the formatting of command output for active and recent subagents, adding separators for better readability.
- Updated related tests to reflect changes in command output structure.
* fix(subagent): default sessions_spawn to no timeout when runTimeoutSeconds omitted
The previous fix (75a791106) correctly handled the case where
runTimeoutSeconds was explicitly set to 0 ("no timeout"). However,
when models omit the parameter entirely (which is common since the
schema marks it as optional), runTimeoutSeconds resolved to undefined.
undefined flowed through the chain as:
sessions_spawn → timeout: undefined (since undefined != null is false)
→ gateway agent handler → agentCommand opts.timeout: undefined
→ resolveAgentTimeoutMs({ overrideSeconds: undefined })
→ DEFAULT_AGENT_TIMEOUT_SECONDS (600s = 10 minutes)
This caused subagents to be killed at exactly 10 minutes even though
the user's intent (via TOOLS.md) was for subagents to run without a
timeout.
Fix: default runTimeoutSeconds to 0 (no timeout) when neither
runTimeoutSeconds nor timeoutSeconds is provided by the caller.
Subagent spawns are long-running by design and should not inherit the
600s agent-command default timeout.
* fix(subagent): accept timeout=0 in agent-via-gateway path (second 600s default)
* fix: thread timeout override through getReplyFromConfig dispatch path
getReplyFromConfig called resolveAgentTimeoutMs({ cfg }) with no override,
always falling back to the config default (600s). Add timeoutOverrideSeconds
to GetReplyOptions and pass it through as overrideSeconds so callers of the
dispatch chain can specify a custom timeout (0 = no timeout).
This complements the existing timeout threading in agentCommand and the
cron isolated-agent runner, which already pass overrideSeconds correctly.
* feat(model-fallback): normalize OpenAI Codex model references and enhance fallback handling
- Added normalization for OpenAI Codex model references, specifically converting "gpt-5.3-codex" to "openai-codex" before execution.
- Updated the `resolveFallbackCandidates` function to utilize the new normalization logic.
- Enhanced tests to verify the correct behavior of model normalization and fallback mechanisms.
- Introduced a new test case to ensure that the normalization process works as expected for various input formats.
* feat(tests): add unit tests for steer failure behavior in openclaw-tools
- Introduced a new test file to validate the behavior of subagents when steer replacement dispatch fails.
- Implemented tests to ensure that the announce behavior is restored correctly and that the suppression reason is cleared as expected.
- Enhanced the subagent registry with a new function to clear steer restart suppression.
- Updated related components to support the new test scenarios.
* fix(subagents): replace stop command with kill in slash commands and documentation
- Updated the `/subagents` command to replace `stop` with `kill` for consistency in controlling sub-agent runs.
- Modified related documentation to reflect the change in command usage.
- Removed legacy timeoutSeconds references from the sessions-spawn-tool schema and tests to streamline timeout handling.
- Enhanced tests to ensure correct behavior of the updated commands and their interactions.
* feat(tests): add unit tests for readLatestAssistantReply function
- Introduced a new test file for the `readLatestAssistantReply` function to validate its behavior with various message scenarios.
- Implemented tests to ensure the function correctly retrieves the latest assistant message and handles cases where the latest message has no text.
- Mocked the gateway call to simulate different message histories for comprehensive testing.
* feat(tests): enhance subagent kill-all cascade tests and announce formatting
- Added a new test to verify that the `kill-all` command cascades through ended parents to active descendants in subagents.
- Updated the subagent announce formatting tests to reflect changes in message structure, including the replacement of "Findings:" with "Result:" and the addition of new expectations for message content.
- Improved the handling of long findings and stats in the announce formatting logic to ensure concise output.
- Refactored related functions to enhance clarity and maintainability in the subagent registry and tools.
* refactor(subagent): update announce formatting and remove unused constants
- Modified the subagent announce formatting to replace "Findings:" with "Result:" and adjusted related expectations in tests.
- Removed constants for maximum announce findings characters and summary words, simplifying the announcement logic.
- Updated the handling of findings to retain full content instead of truncating, ensuring more informative outputs.
- Cleaned up unused imports in the commands-subagents file to enhance code clarity.
* feat(tests): enhance billing error handling in user-facing text
- Added tests to ensure that normal text mentioning billing plans is not rewritten, preserving user context.
- Updated the `isBillingErrorMessage` and `sanitizeUserFacingText` functions to improve handling of billing-related messages.
- Introduced new test cases for various scenarios involving billing messages to ensure accurate processing and output.
- Enhanced the subagent announce flow to correctly manage active descendant runs, preventing premature announcements.
* feat(subagent): enhance workflow guidance and auto-announcement clarity
- Added a new guideline in the subagent system prompt to emphasize trust in push-based completion, discouraging busy polling for status updates.
- Updated documentation to clarify that sub-agents will automatically announce their results, improving user understanding of the workflow.
- Enhanced tests to verify the new guidance on avoiding polling loops and to ensure the accuracy of the updated prompts.
* fix(cron): avoid announcing interim subagent spawn acks
* chore: clean post-rebase imports
* fix(cron): fall back to child replies when parent stays interim
* fix(subagents): make active-run guidance advisory
* fix(subagents): update announce flow to handle active descendants and enhance test coverage
- Modified the announce flow to defer announcements when active descendant runs are present, ensuring accurate status reporting.
- Updated tests to verify the new behavior, including scenarios where no fallback requester is available and ensuring proper handling of finished subagents.
- Enhanced the announce formatting to include an `expectFinal` flag for better clarity in the announcement process.
* fix(subagents): enhance announce flow and formatting for user updates
- Updated the announce flow to provide clearer instructions for user updates based on active subagent runs and requester context.
- Refactored the announcement logic to improve clarity and ensure internal context remains private.
- Enhanced tests to verify the new message expectations and formatting, including updated prompts for user-facing updates.
- Introduced a new function to build reply instructions based on session context, improving the overall announcement process.
* fix: resolve prep blockers and changelog placement (#14447) (thanks @tyler6204)
* fix: restore cron delivery-plan import after rebase (#14447) (thanks @tyler6204)
* fix: resolve test failures from rebase conflicts (#14447) (thanks @tyler6204)
* fix: apply formatting after rebase (#14447) (thanks @tyler6204)
2026-02-14 22:03:45 -08:00
function resolvePollWaitMs ( value : unknown ) {
if ( typeof value === "number" && Number . isFinite ( value ) ) {
return Math . max ( 0 , Math . min ( MAX_POLL_WAIT_MS , Math . floor ( value ) ) ) ;
}
if ( typeof value === "string" ) {
const parsed = Number . parseInt ( value . trim ( ) , 10 ) ;
if ( Number . isFinite ( parsed ) ) {
return Math . max ( 0 , Math . min ( MAX_POLL_WAIT_MS , parsed ) ) ;
}
}
return 0 ;
}
2026-02-15 14:28:55 +00:00
function failText ( text : string ) : AgentToolResult < unknown > {
return {
content : [
{
type : "text" ,
text ,
} ,
] ,
details : { status : "failed" } ,
} ;
}
2026-02-16 14:03:40 -08:00
function recordPollRetrySuggestion ( sessionId : string , hasNewOutput : boolean ) : number | undefined {
try {
const sessionState = getDiagnosticSessionState ( { sessionId } ) ;
return recordCommandPoll ( sessionState , sessionId , hasNewOutput ) ;
} catch {
return undefined ;
}
}
function resetPollRetrySuggestion ( sessionId : string ) : void {
try {
const sessionState = getDiagnosticSessionState ( { sessionId } ) ;
resetCommandPollCount ( sessionState , sessionId ) ;
} catch {
// Ignore diagnostics state failures for process tool behavior.
}
}
2026-01-14 05:39:59 +00:00
export function createProcessTool (
defaults? : ProcessToolDefaults ,
2026-02-02 15:45:05 +09:00
// oxlint-disable-next-line typescript/no-explicit-any
2026-02-14 22:54:16 +00:00
) : AgentTool < any , unknown > {
2026-01-14 05:39:59 +00:00
if ( defaults ? . cleanupMs !== undefined ) {
setJobTtlMs ( defaults . cleanupMs ) ;
}
const scopeKey = defaults ? . scopeKey ;
2026-03-04 08:52:05 -05:00
const inputWaitIdleMs = clampWithDefault (
defaults ? . inputWaitIdleMs ? ? readEnvInt ( "OPENCLAW_PROCESS_INPUT_WAIT_IDLE_MS" ) ,
DEFAULT_INPUT_WAIT_IDLE_MS ,
MIN_INPUT_WAIT_IDLE_MS ,
MAX_INPUT_WAIT_IDLE_MS ,
) ;
2026-02-16 09:32:05 +08:00
const supervisor = getProcessSupervisor ( ) ;
2026-01-14 05:39:59 +00:00
const isInScope = ( session ? : { scopeKey? : string } | null ) = >
! scopeKey || session ? . scopeKey === scopeKey ;
2026-03-04 08:52:05 -05:00
const resolveStdinWritable = ( session : ProcessSession ) = > {
const stdin = session . stdin ? ? session . child ? . stdin ;
return Boolean ( stdin && ! stdin . destroyed ) ;
} ;
const describeRunningSession = ( session : ProcessSession ) = > {
const record = supervisor . getRecord ( session . id ) ;
const lastOutputAt = record ? . lastOutputAtMs ? ? session . startedAt ;
const idleMs = Math . max ( 0 , Date . now ( ) - lastOutputAt ) ;
const stdinWritable = resolveStdinWritable ( session ) ;
const waitingForInput = stdinWritable && idleMs >= inputWaitIdleMs ;
return {
stdinWritable ,
waitingForInput ,
lastOutputAt ,
idleMs ,
} ;
} ;
const buildInputWaitHint = ( hints : { waitingForInput : boolean ; idleMs : number } ) = > {
if ( ! hints . waitingForInput ) {
return "" ;
}
const idleLabel = formatDurationCompact ( hints . idleMs ) ? ? ` ${ Math . round ( hints . idleMs / 1000 ) } s ` ;
return ` \ n \ nNo new output for ${ idleLabel } ; this session may be waiting for input. Use process attach, then process write/send-keys/submit to continue. ` ;
} ;
2026-01-14 05:39:59 +00:00
2026-02-16 09:32:05 +08:00
const cancelManagedSession = ( sessionId : string ) = > {
const record = supervisor . getRecord ( sessionId ) ;
if ( ! record || record . state === "exited" ) {
return false ;
}
supervisor . cancel ( sessionId , "manual-cancel" ) ;
return true ;
} ;
const terminateSessionFallback = ( session : ProcessSession ) = > {
const pid = session . pid ? ? session . child ? . pid ;
if ( typeof pid !== "number" || ! Number . isFinite ( pid ) || pid <= 0 ) {
return false ;
}
killProcessTree ( pid ) ;
return true ;
} ;
2026-01-14 05:39:59 +00:00
return {
name : "process" ,
label : "process" ,
2026-01-17 06:38:47 +00:00
description :
2026-03-04 08:52:05 -05:00
"Manage running exec sessions: list, attach, poll, log, write, send-keys, submit, paste, kill." ,
2026-01-14 05:39:59 +00:00
parameters : processSchema ,
2026-02-14 22:54:16 +00:00
execute : async ( _toolCallId , args , _signal , _onUpdate ) : Promise < AgentToolResult < unknown > > = > {
2026-01-14 05:39:59 +00:00
const params = args as {
2026-01-17 06:38:47 +00:00
action :
| "list"
2026-03-04 08:52:05 -05:00
| "attach"
2026-01-17 06:38:47 +00:00
| "poll"
| "log"
| "write"
| "send-keys"
| "submit"
| "paste"
| "kill"
| "clear"
| "remove" ;
2026-01-14 05:39:59 +00:00
sessionId? : string ;
data? : string ;
2026-01-17 06:12:25 +00:00
keys? : string [ ] ;
hex? : string [ ] ;
literal? : string ;
text? : string ;
bracketed? : boolean ;
2026-01-14 05:39:59 +00:00
eof? : boolean ;
offset? : number ;
limit? : number ;
2026-02-15 22:45:44 +00:00
timeout? : unknown ;
2026-01-14 05:39:59 +00:00
} ;
if ( params . action === "list" ) {
const running = listRunningSessions ( )
. filter ( ( s ) = > isInScope ( s ) )
2026-03-04 08:52:05 -05:00
. map ( ( s ) = > {
const runtime = describeRunningSession ( s ) ;
return {
sessionId : s.id ,
status : "running" ,
pid : s.pid ? ? undefined ,
startedAt : s.startedAt ,
runtimeMs : Date.now ( ) - s . startedAt ,
cwd : s.cwd ,
command : s.command ,
name : deriveSessionName ( s . command ) ,
tail : s.tail ,
truncated : s.truncated ,
stdinWritable : runtime.stdinWritable ,
waitingForInput : runtime.waitingForInput ,
lastOutputAt : runtime.lastOutputAt ,
idleMs : runtime.idleMs ,
} ;
} ) ;
2026-01-14 05:39:59 +00:00
const finished = listFinishedSessions ( )
. filter ( ( s ) = > isInScope ( s ) )
. map ( ( s ) = > ( {
sessionId : s.id ,
status : s.status ,
startedAt : s.startedAt ,
endedAt : s.endedAt ,
runtimeMs : s.endedAt - s . startedAt ,
cwd : s.cwd ,
command : s.command ,
name : deriveSessionName ( s . command ) ,
tail : s.tail ,
truncated : s.truncated ,
exitCode : s.exitCode ? ? undefined ,
exitSignal : s.exitSignal ? ? undefined ,
} ) ) ;
const lines = [ . . . running , . . . finished ]
2026-01-31 16:03:28 +09:00
. toSorted ( ( a , b ) = > b . startedAt - a . startedAt )
2026-01-14 05:39:59 +00:00
. map ( ( s ) = > {
2026-01-14 14:31:43 +00:00
const label = s . name ? truncateMiddle ( s . name , 80 ) : truncateMiddle ( s . command , 120 ) ;
2026-03-04 08:52:05 -05:00
const inputWaitTag =
s . status === "running" && "waitingForInput" in s && s . waitingForInput
? " [input-wait]"
: "" ;
return ` ${ s . sessionId } ${ pad ( s . status , 9 ) } ${ formatDurationCompact ( s . runtimeMs ) ? ? "n/a" } :: ${ label } ${ inputWaitTag } ` ;
2026-01-14 05:39:59 +00:00
} ) ;
return {
content : [
{
type : "text" ,
text : lines.join ( "\n" ) || "No running or recent sessions." ,
} ,
] ,
details : { status : "completed" , sessions : [ . . . running , . . . finished ] } ,
} ;
}
if ( ! params . sessionId ) {
return {
2026-01-14 14:31:43 +00:00
content : [ { type : "text" , text : "sessionId is required for this action." } ] ,
2026-01-14 05:39:59 +00:00
details : { status : "failed" } ,
} ;
}
const session = getSession ( params . sessionId ) ;
const finished = getFinishedSession ( params . sessionId ) ;
const scopedSession = isInScope ( session ) ? session : undefined ;
const scopedFinished = isInScope ( finished ) ? finished : undefined ;
2026-02-14 22:54:16 +00:00
const failedResult = ( text : string ) : AgentToolResult < unknown > = > ( {
2026-02-14 22:38:23 +00:00
content : [ { type : "text" , text } ] ,
details : { status : "failed" } ,
} ) ;
const resolveBackgroundedWritableStdin = ( ) = > {
if ( ! scopedSession ) {
return {
ok : false as const ,
result : failedResult ( ` No active session found for ${ params . sessionId } ` ) ,
} ;
}
if ( ! scopedSession . backgrounded ) {
return {
ok : false as const ,
result : failedResult ( ` Session ${ params . sessionId } is not backgrounded. ` ) ,
} ;
}
const stdin = scopedSession . stdin ? ? scopedSession . child ? . stdin ;
if ( ! stdin || stdin . destroyed ) {
return {
ok : false as const ,
result : failedResult ( ` Session ${ params . sessionId } stdin is not writable. ` ) ,
} ;
}
2026-02-14 22:54:16 +00:00
return { ok : true as const , session : scopedSession , stdin : stdin as WritableStdin } ;
2026-02-14 22:38:23 +00:00
} ;
2026-02-14 22:54:16 +00:00
const writeToStdin = async ( stdin : WritableStdin , data : string ) = > {
2026-02-14 22:38:23 +00:00
await new Promise < void > ( ( resolve , reject ) = > {
stdin . write ( data , ( err ) = > {
if ( err ) {
reject ( err ) ;
} else {
resolve ( ) ;
}
} ) ;
} ) ;
} ;
2026-02-22 11:29:10 +00:00
const runningSessionResult = (
session : ProcessSession ,
text : string ,
) : AgentToolResult < unknown > = > ( {
content : [ { type : "text" , text } ] ,
details : {
status : "running" ,
sessionId : params.sessionId ,
name : deriveSessionName ( session . command ) ,
} ,
} ) ;
2026-01-14 05:39:59 +00:00
switch ( params . action ) {
2026-03-04 08:52:05 -05:00
case "attach" : {
if ( scopedSession ) {
if ( ! scopedSession . backgrounded ) {
return failText ( ` Session ${ params . sessionId } is not backgrounded. ` ) ;
}
const runtime = describeRunningSession ( scopedSession ) ;
const window = resolveLogSliceWindow ( params . offset , params . limit ) ;
const { slice , totalLines , totalChars } = sliceLogLines (
scopedSession . aggregated ,
window . effectiveOffset ,
window . effectiveLimit ,
) ;
const logDefaultTailNote = defaultTailNote ( totalLines , window . usingDefaultTail ) ;
const waitingHint = buildInputWaitHint ( runtime ) ;
const controlHint = runtime . stdinWritable
? "\n\nInteractive controls: process write, process send-keys, process submit."
: "" ;
return {
content : [
{
type : "text" ,
text :
( slice || "(no output yet)" ) + logDefaultTailNote + waitingHint + controlHint ,
} ,
] ,
details : {
status : "running" ,
sessionId : params.sessionId ,
total : totalLines ,
totalLines ,
totalChars ,
truncated : scopedSession.truncated ,
name : deriveSessionName ( scopedSession . command ) ,
stdinWritable : runtime.stdinWritable ,
waitingForInput : runtime.waitingForInput ,
idleMs : runtime.idleMs ,
lastOutputAt : runtime.lastOutputAt ,
} ,
} ;
}
if ( scopedFinished ) {
const window = resolveLogSliceWindow ( params . offset , params . limit ) ;
const { slice , totalLines , totalChars } = sliceLogLines (
scopedFinished . aggregated ,
window . effectiveOffset ,
window . effectiveLimit ,
) ;
const status = scopedFinished . status === "completed" ? "completed" : "failed" ;
const logDefaultTailNote = defaultTailNote ( totalLines , window . usingDefaultTail ) ;
return {
content : [
{
type : "text" ,
text :
( slice || "(no output recorded)" ) +
logDefaultTailNote +
"\n\nSession already exited." ,
} ,
] ,
details : {
status ,
sessionId : params.sessionId ,
total : totalLines ,
totalLines ,
totalChars ,
truncated : scopedFinished.truncated ,
exitCode : scopedFinished.exitCode ? ? undefined ,
exitSignal : scopedFinished.exitSignal ? ? undefined ,
name : deriveSessionName ( scopedFinished . command ) ,
} ,
} ;
}
return failText ( ` No session found for ${ params . sessionId } ` ) ;
}
2026-01-14 05:39:59 +00:00
case "poll" : {
if ( ! scopedSession ) {
if ( scopedFinished ) {
2026-02-16 14:03:40 -08:00
resetPollRetrySuggestion ( params . sessionId ) ;
2026-01-14 05:39:59 +00:00
return {
content : [
{
type : "text" ,
text :
( scopedFinished . tail ||
` (no output recorded ${
scopedFinished . truncated ? " — truncated to cap" : ""
} ) ` ) +
` \ n \ nProcess exited with ${
scopedFinished . exitSignal
? ` signal ${ scopedFinished . exitSignal } `
: ` code ${ scopedFinished . exitCode ? ? 0 } `
} . ` ,
} ,
] ,
details : {
2026-01-14 14:31:43 +00:00
status : scopedFinished.status === "completed" ? "completed" : "failed" ,
2026-01-14 05:39:59 +00:00
sessionId : params.sessionId ,
exitCode : scopedFinished.exitCode ? ? undefined ,
aggregated : scopedFinished.aggregated ,
name : deriveSessionName ( scopedFinished . command ) ,
} ,
} ;
}
2026-02-16 14:03:40 -08:00
resetPollRetrySuggestion ( params . sessionId ) ;
2026-02-15 14:28:55 +00:00
return failText ( ` No session found for ${ params . sessionId } ` ) ;
2026-01-14 05:39:59 +00:00
}
if ( ! scopedSession . backgrounded ) {
2026-02-15 14:28:55 +00:00
return failText ( ` Session ${ params . sessionId } is not backgrounded. ` ) ;
2026-01-14 05:39:59 +00:00
}
Agents: add nested subagent orchestration controls and reduce subagent token waste (#14447)
* Agents: add subagent orchestration controls
* Agents: add subagent orchestration controls (WIP uncommitted changes)
* feat(subagents): add depth-based spawn gating for sub-sub-agents
* feat(subagents): tool policy, registry, and announce chain for nested agents
* feat(subagents): system prompt, docs, changelog for nested sub-agents
* fix(subagents): prevent model fallback override, show model during active runs, and block context overflow fallback
Bug 1: When a session has an explicit model override (e.g., gpt/openai-codex),
the fallback candidate logic in resolveFallbackCandidates silently appended the
global primary model (opus) as a backstop. On reinjection/steer with a transient
error, the session could fall back to opus which has a smaller context window
and crash. Fix: when storedModelOverride is set, pass fallbacksOverride ?? []
instead of undefined, preventing the implicit primary backstop.
Bug 2: Active subagents showed 'model n/a' in /subagents list because
resolveModelDisplay only read entry.model/modelProvider (populated after run
completes). Fix: fall back to modelOverride/providerOverride fields which are
populated at spawn time via sessions.patch.
Bug 3: Context overflow errors (prompt too long, context_length_exceeded) could
theoretically escape runEmbeddedPiAgent and be treated as failover candidates
in runWithModelFallback, causing a switch to a model with a smaller context
window. Fix: in runWithModelFallback, detect context overflow errors via
isLikelyContextOverflowError and rethrow them immediately instead of trying the
next model candidate.
* fix(subagents): track spawn depth in session store and fix announce routing for nested agents
* Fix compaction status tracking and dedupe overflow compaction triggers
* fix(subagents): enforce depth block via session store and implement cascade kill
* fix: inject group chat context into system prompt
* fix(subagents): always write model to session store at spawn time
* Preserve spawnDepth when agent handler rewrites session entry
* fix(subagents): suppress announce on steer-restart
* fix(subagents): fallback spawned session model to runtime default
* fix(subagents): enforce spawn depth when caller key resolves by sessionId
* feat(subagents): implement active-first ordering for numeric targets and enhance task display
- Added a test to verify that subagents with numeric targets follow an active-first list ordering.
- Updated `resolveSubagentTarget` to sort subagent runs based on active status and recent activity.
- Enhanced task display in command responses to prevent truncation of long task descriptions.
- Introduced new utility functions for compacting task text and managing subagent run states.
* fix(subagents): show model for active runs via run record fallback
When the spawned model matches the agent's default model, the session
store's override fields are intentionally cleared (isDefault: true).
The model/modelProvider fields are only populated after the run
completes. This left active subagents showing 'model n/a'.
Fix: store the resolved model on SubagentRunRecord at registration
time, and use it as a fallback in both display paths (subagents tool
and /subagents command) when the session store entry has no model info.
Changes:
- SubagentRunRecord: add optional model field
- registerSubagentRun: accept and persist model param
- sessions-spawn-tool: pass resolvedModel to registerSubagentRun
- subagents-tool: pass run record model as fallback to resolveModelDisplay
- commands-subagents: pass run record model as fallback to resolveModelDisplay
* feat(chat): implement session key resolution and reset on sidebar navigation
- Added functions to resolve the main session key and reset chat state when switching sessions from the sidebar.
- Updated the `renderTab` function to handle session key changes when navigating to the chat tab.
- Introduced a test to verify that the session resets to "main" when opening chat from the sidebar navigation.
* fix: subagent timeout=0 passthrough and fallback prompt duplication
Bug 1: runTimeoutSeconds=0 now means 'no timeout' instead of applying 600s default
- sessions-spawn-tool: default to undefined (not 0) when neither timeout param
is provided; use != null check so explicit 0 passes through to gateway
- agent.ts: accept 0 as valid timeout (resolveAgentTimeoutMs already handles
0 → MAX_SAFE_TIMEOUT_MS)
Bug 2: model fallback no longer re-injects the original prompt as a duplicate
- agent.ts: track fallback attempt index; on retries use a short continuation
message instead of the full original prompt since the session file already
contains it from the first attempt
- Also skip re-sending images on fallback retries (already in session)
* feat(subagents): truncate long task descriptions in subagents command output
- Introduced a new utility function to format task previews, limiting their length to improve readability.
- Updated the command handler to use the new formatting function, ensuring task descriptions are truncated appropriately.
- Adjusted related tests to verify that long task descriptions are now truncated in the output.
* refactor(subagents): update subagent registry path resolution and improve command output formatting
- Replaced direct import of STATE_DIR with a utility function to resolve the state directory dynamically.
- Enhanced the formatting of command output for active and recent subagents, adding separators for better readability.
- Updated related tests to reflect changes in command output structure.
* fix(subagent): default sessions_spawn to no timeout when runTimeoutSeconds omitted
The previous fix (75a791106) correctly handled the case where
runTimeoutSeconds was explicitly set to 0 ("no timeout"). However,
when models omit the parameter entirely (which is common since the
schema marks it as optional), runTimeoutSeconds resolved to undefined.
undefined flowed through the chain as:
sessions_spawn → timeout: undefined (since undefined != null is false)
→ gateway agent handler → agentCommand opts.timeout: undefined
→ resolveAgentTimeoutMs({ overrideSeconds: undefined })
→ DEFAULT_AGENT_TIMEOUT_SECONDS (600s = 10 minutes)
This caused subagents to be killed at exactly 10 minutes even though
the user's intent (via TOOLS.md) was for subagents to run without a
timeout.
Fix: default runTimeoutSeconds to 0 (no timeout) when neither
runTimeoutSeconds nor timeoutSeconds is provided by the caller.
Subagent spawns are long-running by design and should not inherit the
600s agent-command default timeout.
* fix(subagent): accept timeout=0 in agent-via-gateway path (second 600s default)
* fix: thread timeout override through getReplyFromConfig dispatch path
getReplyFromConfig called resolveAgentTimeoutMs({ cfg }) with no override,
always falling back to the config default (600s). Add timeoutOverrideSeconds
to GetReplyOptions and pass it through as overrideSeconds so callers of the
dispatch chain can specify a custom timeout (0 = no timeout).
This complements the existing timeout threading in agentCommand and the
cron isolated-agent runner, which already pass overrideSeconds correctly.
* feat(model-fallback): normalize OpenAI Codex model references and enhance fallback handling
- Added normalization for OpenAI Codex model references, specifically converting "gpt-5.3-codex" to "openai-codex" before execution.
- Updated the `resolveFallbackCandidates` function to utilize the new normalization logic.
- Enhanced tests to verify the correct behavior of model normalization and fallback mechanisms.
- Introduced a new test case to ensure that the normalization process works as expected for various input formats.
* feat(tests): add unit tests for steer failure behavior in openclaw-tools
- Introduced a new test file to validate the behavior of subagents when steer replacement dispatch fails.
- Implemented tests to ensure that the announce behavior is restored correctly and that the suppression reason is cleared as expected.
- Enhanced the subagent registry with a new function to clear steer restart suppression.
- Updated related components to support the new test scenarios.
* fix(subagents): replace stop command with kill in slash commands and documentation
- Updated the `/subagents` command to replace `stop` with `kill` for consistency in controlling sub-agent runs.
- Modified related documentation to reflect the change in command usage.
- Removed legacy timeoutSeconds references from the sessions-spawn-tool schema and tests to streamline timeout handling.
- Enhanced tests to ensure correct behavior of the updated commands and their interactions.
* feat(tests): add unit tests for readLatestAssistantReply function
- Introduced a new test file for the `readLatestAssistantReply` function to validate its behavior with various message scenarios.
- Implemented tests to ensure the function correctly retrieves the latest assistant message and handles cases where the latest message has no text.
- Mocked the gateway call to simulate different message histories for comprehensive testing.
* feat(tests): enhance subagent kill-all cascade tests and announce formatting
- Added a new test to verify that the `kill-all` command cascades through ended parents to active descendants in subagents.
- Updated the subagent announce formatting tests to reflect changes in message structure, including the replacement of "Findings:" with "Result:" and the addition of new expectations for message content.
- Improved the handling of long findings and stats in the announce formatting logic to ensure concise output.
- Refactored related functions to enhance clarity and maintainability in the subagent registry and tools.
* refactor(subagent): update announce formatting and remove unused constants
- Modified the subagent announce formatting to replace "Findings:" with "Result:" and adjusted related expectations in tests.
- Removed constants for maximum announce findings characters and summary words, simplifying the announcement logic.
- Updated the handling of findings to retain full content instead of truncating, ensuring more informative outputs.
- Cleaned up unused imports in the commands-subagents file to enhance code clarity.
* feat(tests): enhance billing error handling in user-facing text
- Added tests to ensure that normal text mentioning billing plans is not rewritten, preserving user context.
- Updated the `isBillingErrorMessage` and `sanitizeUserFacingText` functions to improve handling of billing-related messages.
- Introduced new test cases for various scenarios involving billing messages to ensure accurate processing and output.
- Enhanced the subagent announce flow to correctly manage active descendant runs, preventing premature announcements.
* feat(subagent): enhance workflow guidance and auto-announcement clarity
- Added a new guideline in the subagent system prompt to emphasize trust in push-based completion, discouraging busy polling for status updates.
- Updated documentation to clarify that sub-agents will automatically announce their results, improving user understanding of the workflow.
- Enhanced tests to verify the new guidance on avoiding polling loops and to ensure the accuracy of the updated prompts.
* fix(cron): avoid announcing interim subagent spawn acks
* chore: clean post-rebase imports
* fix(cron): fall back to child replies when parent stays interim
* fix(subagents): make active-run guidance advisory
* fix(subagents): update announce flow to handle active descendants and enhance test coverage
- Modified the announce flow to defer announcements when active descendant runs are present, ensuring accurate status reporting.
- Updated tests to verify the new behavior, including scenarios where no fallback requester is available and ensuring proper handling of finished subagents.
- Enhanced the announce formatting to include an `expectFinal` flag for better clarity in the announcement process.
* fix(subagents): enhance announce flow and formatting for user updates
- Updated the announce flow to provide clearer instructions for user updates based on active subagent runs and requester context.
- Refactored the announcement logic to improve clarity and ensure internal context remains private.
- Enhanced tests to verify the new message expectations and formatting, including updated prompts for user-facing updates.
- Introduced a new function to build reply instructions based on session context, improving the overall announcement process.
* fix: resolve prep blockers and changelog placement (#14447) (thanks @tyler6204)
* fix: restore cron delivery-plan import after rebase (#14447) (thanks @tyler6204)
* fix: resolve test failures from rebase conflicts (#14447) (thanks @tyler6204)
* fix: apply formatting after rebase (#14447) (thanks @tyler6204)
2026-02-14 22:03:45 -08:00
const pollWaitMs = resolvePollWaitMs ( params . timeout ) ;
if ( pollWaitMs > 0 && ! scopedSession . exited ) {
const deadline = Date . now ( ) + pollWaitMs ;
while ( ! scopedSession . exited && Date . now ( ) < deadline ) {
await new Promise ( ( resolve ) = >
2026-02-23 19:22:58 -08:00
setTimeout ( resolve , Math . max ( 0 , Math . min ( 250 , deadline - Date . now ( ) ) ) ) ,
Agents: add nested subagent orchestration controls and reduce subagent token waste (#14447)
* Agents: add subagent orchestration controls
* Agents: add subagent orchestration controls (WIP uncommitted changes)
* feat(subagents): add depth-based spawn gating for sub-sub-agents
* feat(subagents): tool policy, registry, and announce chain for nested agents
* feat(subagents): system prompt, docs, changelog for nested sub-agents
* fix(subagents): prevent model fallback override, show model during active runs, and block context overflow fallback
Bug 1: When a session has an explicit model override (e.g., gpt/openai-codex),
the fallback candidate logic in resolveFallbackCandidates silently appended the
global primary model (opus) as a backstop. On reinjection/steer with a transient
error, the session could fall back to opus which has a smaller context window
and crash. Fix: when storedModelOverride is set, pass fallbacksOverride ?? []
instead of undefined, preventing the implicit primary backstop.
Bug 2: Active subagents showed 'model n/a' in /subagents list because
resolveModelDisplay only read entry.model/modelProvider (populated after run
completes). Fix: fall back to modelOverride/providerOverride fields which are
populated at spawn time via sessions.patch.
Bug 3: Context overflow errors (prompt too long, context_length_exceeded) could
theoretically escape runEmbeddedPiAgent and be treated as failover candidates
in runWithModelFallback, causing a switch to a model with a smaller context
window. Fix: in runWithModelFallback, detect context overflow errors via
isLikelyContextOverflowError and rethrow them immediately instead of trying the
next model candidate.
* fix(subagents): track spawn depth in session store and fix announce routing for nested agents
* Fix compaction status tracking and dedupe overflow compaction triggers
* fix(subagents): enforce depth block via session store and implement cascade kill
* fix: inject group chat context into system prompt
* fix(subagents): always write model to session store at spawn time
* Preserve spawnDepth when agent handler rewrites session entry
* fix(subagents): suppress announce on steer-restart
* fix(subagents): fallback spawned session model to runtime default
* fix(subagents): enforce spawn depth when caller key resolves by sessionId
* feat(subagents): implement active-first ordering for numeric targets and enhance task display
- Added a test to verify that subagents with numeric targets follow an active-first list ordering.
- Updated `resolveSubagentTarget` to sort subagent runs based on active status and recent activity.
- Enhanced task display in command responses to prevent truncation of long task descriptions.
- Introduced new utility functions for compacting task text and managing subagent run states.
* fix(subagents): show model for active runs via run record fallback
When the spawned model matches the agent's default model, the session
store's override fields are intentionally cleared (isDefault: true).
The model/modelProvider fields are only populated after the run
completes. This left active subagents showing 'model n/a'.
Fix: store the resolved model on SubagentRunRecord at registration
time, and use it as a fallback in both display paths (subagents tool
and /subagents command) when the session store entry has no model info.
Changes:
- SubagentRunRecord: add optional model field
- registerSubagentRun: accept and persist model param
- sessions-spawn-tool: pass resolvedModel to registerSubagentRun
- subagents-tool: pass run record model as fallback to resolveModelDisplay
- commands-subagents: pass run record model as fallback to resolveModelDisplay
* feat(chat): implement session key resolution and reset on sidebar navigation
- Added functions to resolve the main session key and reset chat state when switching sessions from the sidebar.
- Updated the `renderTab` function to handle session key changes when navigating to the chat tab.
- Introduced a test to verify that the session resets to "main" when opening chat from the sidebar navigation.
* fix: subagent timeout=0 passthrough and fallback prompt duplication
Bug 1: runTimeoutSeconds=0 now means 'no timeout' instead of applying 600s default
- sessions-spawn-tool: default to undefined (not 0) when neither timeout param
is provided; use != null check so explicit 0 passes through to gateway
- agent.ts: accept 0 as valid timeout (resolveAgentTimeoutMs already handles
0 → MAX_SAFE_TIMEOUT_MS)
Bug 2: model fallback no longer re-injects the original prompt as a duplicate
- agent.ts: track fallback attempt index; on retries use a short continuation
message instead of the full original prompt since the session file already
contains it from the first attempt
- Also skip re-sending images on fallback retries (already in session)
* feat(subagents): truncate long task descriptions in subagents command output
- Introduced a new utility function to format task previews, limiting their length to improve readability.
- Updated the command handler to use the new formatting function, ensuring task descriptions are truncated appropriately.
- Adjusted related tests to verify that long task descriptions are now truncated in the output.
* refactor(subagents): update subagent registry path resolution and improve command output formatting
- Replaced direct import of STATE_DIR with a utility function to resolve the state directory dynamically.
- Enhanced the formatting of command output for active and recent subagents, adding separators for better readability.
- Updated related tests to reflect changes in command output structure.
* fix(subagent): default sessions_spawn to no timeout when runTimeoutSeconds omitted
The previous fix (75a791106) correctly handled the case where
runTimeoutSeconds was explicitly set to 0 ("no timeout"). However,
when models omit the parameter entirely (which is common since the
schema marks it as optional), runTimeoutSeconds resolved to undefined.
undefined flowed through the chain as:
sessions_spawn → timeout: undefined (since undefined != null is false)
→ gateway agent handler → agentCommand opts.timeout: undefined
→ resolveAgentTimeoutMs({ overrideSeconds: undefined })
→ DEFAULT_AGENT_TIMEOUT_SECONDS (600s = 10 minutes)
This caused subagents to be killed at exactly 10 minutes even though
the user's intent (via TOOLS.md) was for subagents to run without a
timeout.
Fix: default runTimeoutSeconds to 0 (no timeout) when neither
runTimeoutSeconds nor timeoutSeconds is provided by the caller.
Subagent spawns are long-running by design and should not inherit the
600s agent-command default timeout.
* fix(subagent): accept timeout=0 in agent-via-gateway path (second 600s default)
* fix: thread timeout override through getReplyFromConfig dispatch path
getReplyFromConfig called resolveAgentTimeoutMs({ cfg }) with no override,
always falling back to the config default (600s). Add timeoutOverrideSeconds
to GetReplyOptions and pass it through as overrideSeconds so callers of the
dispatch chain can specify a custom timeout (0 = no timeout).
This complements the existing timeout threading in agentCommand and the
cron isolated-agent runner, which already pass overrideSeconds correctly.
* feat(model-fallback): normalize OpenAI Codex model references and enhance fallback handling
- Added normalization for OpenAI Codex model references, specifically converting "gpt-5.3-codex" to "openai-codex" before execution.
- Updated the `resolveFallbackCandidates` function to utilize the new normalization logic.
- Enhanced tests to verify the correct behavior of model normalization and fallback mechanisms.
- Introduced a new test case to ensure that the normalization process works as expected for various input formats.
* feat(tests): add unit tests for steer failure behavior in openclaw-tools
- Introduced a new test file to validate the behavior of subagents when steer replacement dispatch fails.
- Implemented tests to ensure that the announce behavior is restored correctly and that the suppression reason is cleared as expected.
- Enhanced the subagent registry with a new function to clear steer restart suppression.
- Updated related components to support the new test scenarios.
* fix(subagents): replace stop command with kill in slash commands and documentation
- Updated the `/subagents` command to replace `stop` with `kill` for consistency in controlling sub-agent runs.
- Modified related documentation to reflect the change in command usage.
- Removed legacy timeoutSeconds references from the sessions-spawn-tool schema and tests to streamline timeout handling.
- Enhanced tests to ensure correct behavior of the updated commands and their interactions.
* feat(tests): add unit tests for readLatestAssistantReply function
- Introduced a new test file for the `readLatestAssistantReply` function to validate its behavior with various message scenarios.
- Implemented tests to ensure the function correctly retrieves the latest assistant message and handles cases where the latest message has no text.
- Mocked the gateway call to simulate different message histories for comprehensive testing.
* feat(tests): enhance subagent kill-all cascade tests and announce formatting
- Added a new test to verify that the `kill-all` command cascades through ended parents to active descendants in subagents.
- Updated the subagent announce formatting tests to reflect changes in message structure, including the replacement of "Findings:" with "Result:" and the addition of new expectations for message content.
- Improved the handling of long findings and stats in the announce formatting logic to ensure concise output.
- Refactored related functions to enhance clarity and maintainability in the subagent registry and tools.
* refactor(subagent): update announce formatting and remove unused constants
- Modified the subagent announce formatting to replace "Findings:" with "Result:" and adjusted related expectations in tests.
- Removed constants for maximum announce findings characters and summary words, simplifying the announcement logic.
- Updated the handling of findings to retain full content instead of truncating, ensuring more informative outputs.
- Cleaned up unused imports in the commands-subagents file to enhance code clarity.
* feat(tests): enhance billing error handling in user-facing text
- Added tests to ensure that normal text mentioning billing plans is not rewritten, preserving user context.
- Updated the `isBillingErrorMessage` and `sanitizeUserFacingText` functions to improve handling of billing-related messages.
- Introduced new test cases for various scenarios involving billing messages to ensure accurate processing and output.
- Enhanced the subagent announce flow to correctly manage active descendant runs, preventing premature announcements.
* feat(subagent): enhance workflow guidance and auto-announcement clarity
- Added a new guideline in the subagent system prompt to emphasize trust in push-based completion, discouraging busy polling for status updates.
- Updated documentation to clarify that sub-agents will automatically announce their results, improving user understanding of the workflow.
- Enhanced tests to verify the new guidance on avoiding polling loops and to ensure the accuracy of the updated prompts.
* fix(cron): avoid announcing interim subagent spawn acks
* chore: clean post-rebase imports
* fix(cron): fall back to child replies when parent stays interim
* fix(subagents): make active-run guidance advisory
* fix(subagents): update announce flow to handle active descendants and enhance test coverage
- Modified the announce flow to defer announcements when active descendant runs are present, ensuring accurate status reporting.
- Updated tests to verify the new behavior, including scenarios where no fallback requester is available and ensuring proper handling of finished subagents.
- Enhanced the announce formatting to include an `expectFinal` flag for better clarity in the announcement process.
* fix(subagents): enhance announce flow and formatting for user updates
- Updated the announce flow to provide clearer instructions for user updates based on active subagent runs and requester context.
- Refactored the announcement logic to improve clarity and ensure internal context remains private.
- Enhanced tests to verify the new message expectations and formatting, including updated prompts for user-facing updates.
- Introduced a new function to build reply instructions based on session context, improving the overall announcement process.
* fix: resolve prep blockers and changelog placement (#14447) (thanks @tyler6204)
* fix: restore cron delivery-plan import after rebase (#14447) (thanks @tyler6204)
* fix: resolve test failures from rebase conflicts (#14447) (thanks @tyler6204)
* fix: apply formatting after rebase (#14447) (thanks @tyler6204)
2026-02-14 22:03:45 -08:00
) ;
}
}
2026-01-14 05:39:59 +00:00
const { stdout , stderr } = drainSession ( scopedSession ) ;
const exited = scopedSession . exited ;
const exitCode = scopedSession . exitCode ? ? 0 ;
const exitSignal = scopedSession . exitSignal ? ? undefined ;
if ( exited ) {
2026-01-14 14:31:43 +00:00
const status = exitCode === 0 && exitSignal == null ? "completed" : "failed" ;
2026-01-14 05:39:59 +00:00
markExited (
scopedSession ,
scopedSession . exitCode ? ? null ,
scopedSession . exitSignal ? ? null ,
status ,
) ;
}
const status = exited
? exitCode === 0 && exitSignal == null
? "completed"
: "failed"
: "running" ;
2026-03-04 08:52:05 -05:00
const runtime = describeRunningSession ( scopedSession ) ;
2026-01-14 14:31:43 +00:00
const output = [ stdout . trimEnd ( ) , stderr . trimEnd ( ) ] . filter ( Boolean ) . join ( "\n" ) . trim ( ) ;
2026-02-16 14:03:40 -08:00
const hasNewOutput = output . length > 0 ;
const retryInMs = exited
? undefined
: recordPollRetrySuggestion ( params . sessionId , hasNewOutput ) ;
if ( exited ) {
resetPollRetrySuggestion ( params . sessionId ) ;
}
2026-01-14 05:39:59 +00:00
return {
content : [
{
type : "text" ,
text :
( output || "(no new output)" ) +
( exited
? ` \ n \ nProcess exited with ${
exitSignal ? ` signal ${ exitSignal } ` : ` code ${ exitCode } `
} . `
2026-03-04 08:52:05 -05:00
: buildInputWaitHint ( runtime ) || "\n\nProcess still running." ) ,
2026-01-14 05:39:59 +00:00
} ,
] ,
details : {
status ,
sessionId : params.sessionId ,
exitCode : exited ? exitCode : undefined ,
aggregated : scopedSession.aggregated ,
name : deriveSessionName ( scopedSession . command ) ,
2026-03-04 08:52:05 -05:00
stdinWritable : runtime.stdinWritable ,
waitingForInput : runtime.waitingForInput ,
idleMs : runtime.idleMs ,
lastOutputAt : runtime.lastOutputAt ,
2026-02-16 14:03:40 -08:00
. . . ( typeof retryInMs === "number" ? { retryInMs } : { } ) ,
2026-01-14 05:39:59 +00:00
} ,
} ;
}
case "log" : {
if ( scopedSession ) {
if ( ! scopedSession . backgrounded ) {
return {
content : [
{
type : "text" ,
text : ` Session ${ params . sessionId } is not backgrounded. ` ,
} ,
] ,
details : { status : "failed" } ,
} ;
}
2026-02-14 18:32:45 -05:00
const window = resolveLogSliceWindow ( params . offset , params . limit ) ;
2026-01-14 05:39:59 +00:00
const { slice , totalLines , totalChars } = sliceLogLines (
scopedSession . aggregated ,
2026-02-14 18:32:45 -05:00
window . effectiveOffset ,
window . effectiveLimit ,
2026-01-14 05:39:59 +00:00
) ;
2026-02-14 18:32:45 -05:00
const logDefaultTailNote = defaultTailNote ( totalLines , window . usingDefaultTail ) ;
2026-03-04 08:52:05 -05:00
const runtime = describeRunningSession ( scopedSession ) ;
2026-01-14 05:39:59 +00:00
return {
2026-02-14 18:32:45 -05:00
content : [ { type : "text" , text : ( slice || "(no output yet)" ) + logDefaultTailNote } ] ,
2026-01-14 05:39:59 +00:00
details : {
status : scopedSession.exited ? "completed" : "running" ,
sessionId : params.sessionId ,
total : totalLines ,
totalLines ,
totalChars ,
truncated : scopedSession.truncated ,
name : deriveSessionName ( scopedSession . command ) ,
2026-03-04 08:52:05 -05:00
stdinWritable : runtime.stdinWritable ,
waitingForInput : runtime.waitingForInput ,
idleMs : runtime.idleMs ,
lastOutputAt : runtime.lastOutputAt ,
2026-01-14 05:39:59 +00:00
} ,
} ;
}
if ( scopedFinished ) {
2026-02-14 18:32:45 -05:00
const window = resolveLogSliceWindow ( params . offset , params . limit ) ;
2026-01-14 05:39:59 +00:00
const { slice , totalLines , totalChars } = sliceLogLines (
scopedFinished . aggregated ,
2026-02-14 18:32:45 -05:00
window . effectiveOffset ,
window . effectiveLimit ,
2026-01-14 05:39:59 +00:00
) ;
2026-01-14 14:31:43 +00:00
const status = scopedFinished . status === "completed" ? "completed" : "failed" ;
2026-02-14 18:32:45 -05:00
const logDefaultTailNote = defaultTailNote ( totalLines , window . usingDefaultTail ) ;
2026-01-14 05:39:59 +00:00
return {
2026-02-14 18:32:45 -05:00
content : [
{ type : "text" , text : ( slice || "(no output recorded)" ) + logDefaultTailNote } ,
] ,
2026-01-14 05:39:59 +00:00
details : {
status ,
sessionId : params.sessionId ,
total : totalLines ,
totalLines ,
totalChars ,
truncated : scopedFinished.truncated ,
exitCode : scopedFinished.exitCode ? ? undefined ,
exitSignal : scopedFinished.exitSignal ? ? undefined ,
name : deriveSessionName ( scopedFinished . command ) ,
} ,
} ;
}
return {
content : [
{
type : "text" ,
text : ` No session found for ${ params . sessionId } ` ,
} ,
] ,
details : { status : "failed" } ,
} ;
}
case "write" : {
2026-02-14 22:38:23 +00:00
const resolved = resolveBackgroundedWritableStdin ( ) ;
if ( ! resolved . ok ) {
return resolved . result ;
2026-01-14 05:39:59 +00:00
}
2026-02-14 22:38:23 +00:00
await writeToStdin ( resolved . stdin , params . data ? ? "" ) ;
2026-01-14 05:39:59 +00:00
if ( params . eof ) {
2026-02-14 22:38:23 +00:00
resolved . stdin . end ( ) ;
2026-01-14 05:39:59 +00:00
}
2026-02-22 11:29:10 +00:00
return runningSessionResult (
resolved . session ,
` Wrote ${ ( params . data ? ? "" ) . length } bytes to session ${ params . sessionId } ${
params . eof ? " (stdin closed)" : ""
} . ` ,
) ;
2026-01-14 05:39:59 +00:00
}
2026-01-17 06:12:25 +00:00
case "send-keys" : {
2026-02-14 22:38:23 +00:00
const resolved = resolveBackgroundedWritableStdin ( ) ;
if ( ! resolved . ok ) {
return resolved . result ;
2026-01-17 06:12:25 +00:00
}
const { data , warnings } = encodeKeySequence ( {
keys : params.keys ,
hex : params.hex ,
literal : params.literal ,
} ) ;
if ( ! data ) {
return {
content : [
{
type : "text" ,
text : "No key data provided." ,
} ,
] ,
details : { status : "failed" } ,
} ;
}
2026-02-14 22:38:23 +00:00
await writeToStdin ( resolved . stdin , data ) ;
2026-02-22 11:29:10 +00:00
return runningSessionResult (
resolved . session ,
` Sent ${ data . length } bytes to session ${ params . sessionId } . ` +
( warnings . length ? ` \ nWarnings: \ n- ${ warnings . join ( "\n- " ) } ` : "" ) ,
) ;
2026-01-17 06:38:47 +00:00
}
case "submit" : {
2026-02-14 22:38:23 +00:00
const resolved = resolveBackgroundedWritableStdin ( ) ;
if ( ! resolved . ok ) {
return resolved . result ;
2026-01-17 06:38:47 +00:00
}
2026-02-14 22:38:23 +00:00
await writeToStdin ( resolved . stdin , "\r" ) ;
2026-02-22 11:29:10 +00:00
return runningSessionResult (
resolved . session ,
` Submitted session ${ params . sessionId } (sent CR). ` ,
) ;
2026-01-17 06:12:25 +00:00
}
case "paste" : {
2026-02-14 22:38:23 +00:00
const resolved = resolveBackgroundedWritableStdin ( ) ;
if ( ! resolved . ok ) {
return resolved . result ;
2026-01-17 06:12:25 +00:00
}
const payload = encodePaste ( params . text ? ? "" , params . bracketed !== false ) ;
if ( ! payload ) {
return {
content : [
{
type : "text" ,
text : "No paste text provided." ,
} ,
] ,
details : { status : "failed" } ,
} ;
}
2026-02-14 22:38:23 +00:00
await writeToStdin ( resolved . stdin , payload ) ;
2026-02-22 11:29:10 +00:00
return runningSessionResult (
resolved . session ,
` Pasted ${ params . text ? . length ? ? 0 } chars to session ${ params . sessionId } . ` ,
) ;
2026-01-17 06:12:25 +00:00
}
2026-01-14 05:39:59 +00:00
case "kill" : {
if ( ! scopedSession ) {
2026-02-15 14:28:55 +00:00
return failText ( ` No active session found for ${ params . sessionId } ` ) ;
2026-01-14 05:39:59 +00:00
}
if ( ! scopedSession . backgrounded ) {
2026-02-15 14:28:55 +00:00
return failText ( ` Session ${ params . sessionId } is not backgrounded. ` ) ;
2026-01-14 05:39:59 +00:00
}
2026-02-16 09:32:05 +08:00
const canceled = cancelManagedSession ( scopedSession . id ) ;
if ( ! canceled ) {
const terminated = terminateSessionFallback ( scopedSession ) ;
if ( ! terminated ) {
return failText (
` Unable to terminate session ${ params . sessionId } : no active supervisor run or process id. ` ,
) ;
}
markExited ( scopedSession , null , "SIGKILL" , "failed" ) ;
}
2026-02-16 14:03:40 -08:00
resetPollRetrySuggestion ( params . sessionId ) ;
2026-01-14 05:39:59 +00:00
return {
2026-02-16 09:32:05 +08:00
content : [
{
type : "text" ,
text : canceled
? ` Termination requested for session ${ params . sessionId } . `
: ` Killed session ${ params . sessionId } . ` ,
} ,
] ,
2026-01-14 05:39:59 +00:00
details : {
status : "failed" ,
2026-01-14 14:31:43 +00:00
name : scopedSession ? deriveSessionName ( scopedSession . command ) : undefined ,
2026-01-14 05:39:59 +00:00
} ,
} ;
}
case "clear" : {
if ( scopedFinished ) {
2026-02-16 14:03:40 -08:00
resetPollRetrySuggestion ( params . sessionId ) ;
2026-01-14 05:39:59 +00:00
deleteSession ( params . sessionId ) ;
return {
2026-01-14 14:31:43 +00:00
content : [ { type : "text" , text : ` Cleared session ${ params . sessionId } . ` } ] ,
2026-01-14 05:39:59 +00:00
details : { status : "completed" } ,
} ;
}
return {
content : [
{
type : "text" ,
text : ` No finished session found for ${ params . sessionId } ` ,
} ,
] ,
details : { status : "failed" } ,
} ;
}
case "remove" : {
if ( scopedSession ) {
2026-02-16 09:32:05 +08:00
const canceled = cancelManagedSession ( scopedSession . id ) ;
if ( canceled ) {
// Keep remove semantics deterministic: drop from process registry now.
scopedSession . backgrounded = false ;
deleteSession ( params . sessionId ) ;
} else {
const terminated = terminateSessionFallback ( scopedSession ) ;
if ( ! terminated ) {
return failText (
` Unable to remove session ${ params . sessionId } : no active supervisor run or process id. ` ,
) ;
}
markExited ( scopedSession , null , "SIGKILL" , "failed" ) ;
deleteSession ( params . sessionId ) ;
}
2026-02-16 14:03:40 -08:00
resetPollRetrySuggestion ( params . sessionId ) ;
2026-01-14 05:39:59 +00:00
return {
2026-02-16 09:32:05 +08:00
content : [
{
type : "text" ,
text : canceled
? ` Removed session ${ params . sessionId } (termination requested). `
: ` Removed session ${ params . sessionId } . ` ,
} ,
] ,
2026-01-14 05:39:59 +00:00
details : {
status : "failed" ,
2026-01-14 14:31:43 +00:00
name : scopedSession ? deriveSessionName ( scopedSession . command ) : undefined ,
2026-01-14 05:39:59 +00:00
} ,
} ;
}
if ( scopedFinished ) {
2026-02-16 14:03:40 -08:00
resetPollRetrySuggestion ( params . sessionId ) ;
2026-01-14 05:39:59 +00:00
deleteSession ( params . sessionId ) ;
return {
2026-01-14 14:31:43 +00:00
content : [ { type : "text" , text : ` Removed session ${ params . sessionId } . ` } ] ,
2026-01-14 05:39:59 +00:00
details : { status : "completed" } ,
} ;
}
return {
content : [
{
type : "text" ,
text : ` No session found for ${ params . sessionId } ` ,
} ,
] ,
details : { status : "failed" } ,
} ;
}
}
return {
2026-01-14 14:31:43 +00:00
content : [ { type : "text" , text : ` Unknown action ${ params . action as string } ` } ] ,
2026-01-14 05:39:59 +00:00
details : { status : "failed" } ,
} ;
} ,
} ;
}
export const processTool = createProcessTool ( ) ;