From 68838cdd9c4e29105c0aa9af3d9adfd77e1889f9 Mon Sep 17 00:00:00 2001 From: biefan <70761325+biefan@users.noreply.github.com> Date: Tue, 17 Mar 2026 16:40:01 +0000 Subject: [PATCH] fix(tools): remove cron from coding profile --- src/agents/tool-catalog.ts | 2 +- src/agents/tool-policy.test.ts | 2 +- src/gateway/tools-invoke-http.cron-regression.test.ts | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/agents/tool-catalog.ts b/src/agents/tool-catalog.ts index 0d58c066928..f9213a99e64 100644 --- a/src/agents/tool-catalog.ts +++ b/src/agents/tool-catalog.ts @@ -198,7 +198,7 @@ const CORE_TOOL_DEFINITIONS: CoreToolDefinition[] = [ label: "cron", description: "Schedule tasks", sectionId: "automation", - profiles: ["coding"], + profiles: [], includeInOpenClawGroup: true, }, { diff --git a/src/agents/tool-policy.test.ts b/src/agents/tool-policy.test.ts index 963c703a409..b75ad38f963 100644 --- a/src/agents/tool-policy.test.ts +++ b/src/agents/tool-policy.test.ts @@ -56,7 +56,7 @@ describe("tool-policy", () => { it("resolves known profiles and ignores unknown ones", () => { const coding = resolveToolProfilePolicy("coding"); expect(coding?.allow).toContain("read"); - expect(coding?.allow).toContain("cron"); + expect(coding?.allow).not.toContain("cron"); expect(coding?.allow).not.toContain("gateway"); expect(resolveToolProfilePolicy("nope")).toBeUndefined(); }); diff --git a/src/gateway/tools-invoke-http.cron-regression.test.ts b/src/gateway/tools-invoke-http.cron-regression.test.ts index dfee9be2c20..6b7a11fbef3 100644 --- a/src/gateway/tools-invoke-http.cron-regression.test.ts +++ b/src/gateway/tools-invoke-http.cron-regression.test.ts @@ -125,10 +125,11 @@ describe("tools invoke HTTP denylist", () => { expect(cronRes.status).toBe(200); }); - it("keeps cron available under coding profile without exposing gateway", async () => { + it("requires an explicit tool allow override to expose cron under coding profile", async () => { cfg = { tools: { profile: "coding", + allow: ["cron"], }, gateway: { tools: {