Ayuriel/openclaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge fb35d46f9d9842aa85185a0c135dd6e94ff0db35 into 598f1826d8b2bc969aace2c6459824737667218c

Browse Source
This commit is contained in:
kn1ghtc 2026-03-20 23:15:33 -04:00 committed by GitHub
commit 0f82a5b7b0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/gateway/server-methods/exec-approval.ts
View File

@ -316,6 +316,24 @@ export function createExecApprovalHandlers(
}
const approvalId = resolvedId.id;
const snapshot = manager.getSnapshot(approvalId);
// Security: prevent self-approval — the connection that submitted the request
// cannot also resolve it. This blocks prompt-injected agents from immediately
// approving their own dangerous command requests without human oversight.
if (
snapshot?.requestedByConnId != null &&
client?.connId != null &&
client.connId === snapshot.requestedByConnId
) {
respond(
false,
undefined,
errorShape(
ErrorCodes.INVALID_REQUEST,
"requester cannot approve their own exec request",
),
);
return;
}
const resolvedBy = client?.connect?.client?.displayName ?? client?.connect?.client?.id;
const ok = manager.resolve(approvalId, decision, resolvedBy ?? null);
if (!ok) {