Ayuriel/openclaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(plugin-tests): share binding approval resolution

Browse Source
This commit is contained in:
Peter Steinberger 2026-03-17 06:59:57 +00:00
parent c08d556ae4
commit 282e336243
1 changed files with 24 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

62
src/plugins/conversation-binding.test.ts
View File

@ -102,6 +102,8 @@ const {
const { registerSessionBindingAdapter, unregisterSessionBindingAdapter } =
await import("../infra/outbound/session-binding-service.js");
type PluginBindingRequest = Awaited<ReturnType<typeof requestPluginConversationBinding>>;
function createAdapter(channel: string, accountId: string): SessionBindingAdapter {
return {
channel,
@ -119,6 +121,26 @@ function createAdapter(channel: string, accountId: string): SessionBindingAdapte
};
}
async function resolveRequestedBinding(request: PluginBindingRequest) {
expect(["pending", "bound"]).toContain(request.status);
if (request.status === "pending") {
const approved = await resolvePluginConversationBindingApproval({
approvalId: request.approvalId,
decision: "allow-once",
senderId: "user-1",
});
expect(approved.status).toBe("approved");
if (approved.status !== "approved") {
throw new Error("expected approved bind result");
}
return approved.binding;
}
if (request.status === "bound") {
return request.binding;
}
throw new Error("expected pending or bound bind result");
}
describe("plugin conversation binding approvals", () => {
beforeEach(() => {
sessionBindingState.reset();
@ -485,25 +507,7 @@ describe("plugin conversation binding approvals", () => {
binding: { summary: "Bind this conversation to Codex thread abc." },
});
expect(["pending", "bound"]).toContain(request.status);
const binding =
request.status === "pending"
? await resolvePluginConversationBindingApproval({
approvalId: request.approvalId,
decision: "allow-once",
senderId: "user-1",
}).then((approved) => {
expect(approved.status).toBe("approved");
if (approved.status !== "approved") {
throw new Error("expected approved bind result");
}
return approved.binding;
})
: request.status === "bound"
? request.binding
: (() => {
throw new Error("expected pending or bound bind result");
})();
const binding = await resolveRequestedBinding(request);
expect(binding).toEqual(
expect.objectContaining({
@ -546,25 +550,7 @@ describe("plugin conversation binding approvals", () => {
},
});
expect(["pending", "bound"]).toContain(request.status);
const binding =
request.status === "pending"
? await resolvePluginConversationBindingApproval({
approvalId: request.approvalId,
decision: "allow-once",
senderId: "user-1",
}).then((approved) => {
expect(approved.status).toBe("approved");
if (approved.status !== "approved") {
throw new Error("expected approved bind result");
}
return approved.binding;
})
: request.status === "bound"
? request.binding
: (() => {
throw new Error("expected pending or bound bind result");
})();
const binding = await resolveRequestedBinding(request);
expect(binding).toEqual(
expect.objectContaining({