From 3f69db6eff25f9490a9c0d42976fb7f0e471266f Mon Sep 17 00:00:00 2001
From: Keren <steveclear2020@gmail.com>
Date: Tue, 10 Mar 2026 00:00:22 +0100
Subject: [PATCH] test: rename misleading test, add global_circuit_breaker
 regression
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Address greptile review feedback:
- Rename "blocks repeated exec calls at critical threshold" to
  "warns for exec calls repeated past warning threshold" (it asserts
  "warning", not "critical")
- Add dedicated test for GLOBAL_CIRCUIT_BREAKER_THRESHOLD (30
  iterations) — the most impactful code path fixed by this PR,
  asserting level: "critical" and detector: "global_circuit_breaker"

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 src/agents/tool-loop-detection.test.ts | 34 +++++++++++++++++++++++++-
 1 file changed, 33 insertions(+), 1 deletion(-)

diff --git a/src/agents/tool-loop-detection.test.ts b/src/agents/tool-loop-detection.test.ts
index 0d6f0199509..894d3b75eec 100644
--- a/src/agents/tool-loop-detection.test.ts
+++ b/src/agents/tool-loop-detection.test.ts
@@ -608,7 +608,7 @@ describe("tool-loop-detection", () => {
       expect(loopResult.stuck).toBe(false);
     });
 
-    it("blocks repeated exec calls at critical threshold (#34574)", () => {
+    it("warns for exec calls repeated past warning threshold (#34574)", () => {
       const state = createState();
       const execParams = { command: "cat /tmp/status", cwd: "/workspace" };
 
@@ -639,6 +639,38 @@ describe("tool-loop-detection", () => {
       }
     });
 
+    it("triggers global circuit breaker for exec at 30 repetitions (#34574)", () => {
+      const state = createState();
+      const execParams = { command: "cat /tmp/status", cwd: "/workspace" };
+
+      for (let i = 0; i < GLOBAL_CIRCUIT_BREAKER_THRESHOLD; i += 1) {
+        const toolCallId = `exec-gcb-${i}`;
+        recordToolCall(state, "exec", execParams, toolCallId);
+        recordToolCallOutcome(state, {
+          toolName: "exec",
+          toolParams: execParams,
+          toolCallId,
+          result: {
+            content: [{ type: "text", text: "same output" }],
+            details: {
+              status: "completed",
+              exitCode: 0,
+              durationMs: 300 + i * 5,
+              aggregated: "same output",
+              cwd: "/workspace",
+            },
+          },
+        });
+      }
+
+      const loopResult = detectToolCallLoop(state, "exec", execParams, enabledLoopDetectionConfig);
+      expect(loopResult.stuck).toBe(true);
+      if (loopResult.stuck) {
+        expect(loopResult.level).toBe("critical");
+        expect(loopResult.detector).toBe("global_circuit_breaker");
+      }
+    });
+
     it("detects exec loop even with varying pid and startedAt (#34574)", () => {
       const state = createState();
       const execParams = { command: "sleep 1 &", cwd: "/workspace" };