From 412c1d0af17e6ee9cb72a5b04945cc68234b112d Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Mon, 16 Feb 2026 00:21:05 +0000
Subject: [PATCH] perf(test): fold logger import side-effects test into
 diagnostic suite

---
 src/logging/diagnostic.test.ts                | 19 +++++++++++++++++++
 .../logger.import-side-effects.test.ts        | 16 ----------------
 2 files changed, 19 insertions(+), 16 deletions(-)
 delete mode 100644 src/logging/logger.import-side-effects.test.ts

diff --git a/src/logging/diagnostic.test.ts b/src/logging/diagnostic.test.ts
index c7cd72f5c08..10c666432c1 100644
--- a/src/logging/diagnostic.test.ts
+++ b/src/logging/diagnostic.test.ts
@@ -1,3 +1,4 @@
+import fs from "node:fs";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 import {
   getDiagnosticSessionStateCountForTest,
@@ -34,3 +35,21 @@ describe("diagnostic session state pruning", () => {
     expect(getDiagnosticSessionStateCountForTest()).toBe(2000);
   });
 });
+
+describe("logger import side effects", () => {
+  afterEach(() => {
+    vi.restoreAllMocks();
+    vi.useRealTimers();
+  });
+
+  it("does not mkdir at import time", async () => {
+    vi.useRealTimers();
+    vi.resetModules();
+
+    const mkdirSpy = vi.spyOn(fs, "mkdirSync");
+
+    await import("./logger.js");
+
+    expect(mkdirSpy).not.toHaveBeenCalled();
+  });
+});
diff --git a/src/logging/logger.import-side-effects.test.ts b/src/logging/logger.import-side-effects.test.ts
deleted file mode 100644
index b0e8c2b9729..00000000000
--- a/src/logging/logger.import-side-effects.test.ts
+++ /dev/null
@@ -1,16 +0,0 @@
-import fs from "node:fs";
-import { afterEach, describe, expect, it, vi } from "vitest";
-
-describe("logger import side effects", () => {
-  afterEach(() => {
-    vi.restoreAllMocks();
-  });
-
-  it("does not mkdir at import time", async () => {
-    const mkdirSpy = vi.spyOn(fs, "mkdirSync");
-
-    await import("./logger.js");
-
-    expect(mkdirSpy).not.toHaveBeenCalled();
-  });
-});