From 55fd88e96712504f8217f3116ffe2c4b1de0ab18 Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Sun, 15 Feb 2026 23:52:16 +0000
Subject: [PATCH] perf(test): consolidate utils parsing helpers

---
 src/utils/boolean.test.ts        | 41 --------------
 src/utils/provider-utils.test.ts | 39 -------------
 src/utils/shell-argv.test.ts     | 19 -------
 src/utils/utils-misc.test.ts     | 97 ++++++++++++++++++++++++++++++++
 4 files changed, 97 insertions(+), 99 deletions(-)
 delete mode 100644 src/utils/boolean.test.ts
 delete mode 100644 src/utils/provider-utils.test.ts
 delete mode 100644 src/utils/shell-argv.test.ts
 create mode 100644 src/utils/utils-misc.test.ts

diff --git a/src/utils/boolean.test.ts b/src/utils/boolean.test.ts
deleted file mode 100644
index 04c1dd52f5e..00000000000
--- a/src/utils/boolean.test.ts
+++ /dev/null
@@ -1,41 +0,0 @@
-import { describe, expect, it } from "vitest";
-import { parseBooleanValue } from "./boolean.js";
-
-describe("parseBooleanValue", () => {
-  it("handles boolean inputs", () => {
-    expect(parseBooleanValue(true)).toBe(true);
-    expect(parseBooleanValue(false)).toBe(false);
-  });
-
-  it("parses default truthy/falsy strings", () => {
-    expect(parseBooleanValue("true")).toBe(true);
-    expect(parseBooleanValue("1")).toBe(true);
-    expect(parseBooleanValue("yes")).toBe(true);
-    expect(parseBooleanValue("on")).toBe(true);
-    expect(parseBooleanValue("false")).toBe(false);
-    expect(parseBooleanValue("0")).toBe(false);
-    expect(parseBooleanValue("no")).toBe(false);
-    expect(parseBooleanValue("off")).toBe(false);
-  });
-
-  it("respects custom truthy/falsy lists", () => {
-    expect(
-      parseBooleanValue("on", {
-        truthy: ["true"],
-        falsy: ["false"],
-      }),
-    ).toBeUndefined();
-    expect(
-      parseBooleanValue("yes", {
-        truthy: ["yes"],
-        falsy: ["no"],
-      }),
-    ).toBe(true);
-  });
-
-  it("returns undefined for unsupported values", () => {
-    expect(parseBooleanValue("")).toBeUndefined();
-    expect(parseBooleanValue("maybe")).toBeUndefined();
-    expect(parseBooleanValue(1)).toBeUndefined();
-  });
-});
diff --git a/src/utils/provider-utils.test.ts b/src/utils/provider-utils.test.ts
deleted file mode 100644
index d00324f5903..00000000000
--- a/src/utils/provider-utils.test.ts
+++ /dev/null
@@ -1,39 +0,0 @@
-import { describe, expect, it } from "vitest";
-import { isReasoningTagProvider } from "./provider-utils.js";
-
-describe("isReasoningTagProvider", () => {
-  it("returns false for ollama - native reasoning field, no tags needed (#2279)", () => {
-    expect(isReasoningTagProvider("ollama")).toBe(false);
-    expect(isReasoningTagProvider("Ollama")).toBe(false);
-  });
-
-  it("returns true for google-gemini-cli", () => {
-    expect(isReasoningTagProvider("google-gemini-cli")).toBe(true);
-  });
-
-  it("returns true for google-generative-ai", () => {
-    expect(isReasoningTagProvider("google-generative-ai")).toBe(true);
-  });
-
-  it("returns true for google-antigravity", () => {
-    expect(isReasoningTagProvider("google-antigravity")).toBe(true);
-    expect(isReasoningTagProvider("google-antigravity/gemini-3")).toBe(true);
-  });
-
-  it("returns true for minimax", () => {
-    expect(isReasoningTagProvider("minimax")).toBe(true);
-    expect(isReasoningTagProvider("minimax-cn")).toBe(true);
-  });
-
-  it("returns false for null/undefined/empty", () => {
-    expect(isReasoningTagProvider(null)).toBe(false);
-    expect(isReasoningTagProvider(undefined)).toBe(false);
-    expect(isReasoningTagProvider("")).toBe(false);
-  });
-
-  it("returns false for standard providers", () => {
-    expect(isReasoningTagProvider("anthropic")).toBe(false);
-    expect(isReasoningTagProvider("openai")).toBe(false);
-    expect(isReasoningTagProvider("openrouter")).toBe(false);
-  });
-});
diff --git a/src/utils/shell-argv.test.ts b/src/utils/shell-argv.test.ts
deleted file mode 100644
index 156cf1bfdfd..00000000000
--- a/src/utils/shell-argv.test.ts
+++ /dev/null
@@ -1,19 +0,0 @@
-import { describe, expect, it } from "vitest";
-import { splitShellArgs } from "./shell-argv.js";
-
-describe("splitShellArgs", () => {
-  it("splits whitespace and respects quotes", () => {
-    expect(splitShellArgs(`qmd --foo "bar baz"`)).toEqual(["qmd", "--foo", "bar baz"]);
-    expect(splitShellArgs(`qmd --foo 'bar baz'`)).toEqual(["qmd", "--foo", "bar baz"]);
-  });
-
-  it("supports backslash escapes inside double quotes", () => {
-    expect(splitShellArgs(String.raw`echo "a\"b"`)).toEqual(["echo", `a"b`]);
-    expect(splitShellArgs(String.raw`echo "\$HOME"`)).toEqual(["echo", "$HOME"]);
-  });
-
-  it("returns null for unterminated quotes", () => {
-    expect(splitShellArgs(`echo "oops`)).toBeNull();
-    expect(splitShellArgs(`echo 'oops`)).toBeNull();
-  });
-});
diff --git a/src/utils/utils-misc.test.ts b/src/utils/utils-misc.test.ts
new file mode 100644
index 00000000000..1c8a1632285
--- /dev/null
+++ b/src/utils/utils-misc.test.ts
@@ -0,0 +1,97 @@
+import { describe, expect, it } from "vitest";
+import { parseBooleanValue } from "./boolean.js";
+import { isReasoningTagProvider } from "./provider-utils.js";
+import { splitShellArgs } from "./shell-argv.js";
+
+describe("parseBooleanValue", () => {
+  it("handles boolean inputs", () => {
+    expect(parseBooleanValue(true)).toBe(true);
+    expect(parseBooleanValue(false)).toBe(false);
+  });
+
+  it("parses default truthy/falsy strings", () => {
+    expect(parseBooleanValue("true")).toBe(true);
+    expect(parseBooleanValue("1")).toBe(true);
+    expect(parseBooleanValue("yes")).toBe(true);
+    expect(parseBooleanValue("on")).toBe(true);
+    expect(parseBooleanValue("false")).toBe(false);
+    expect(parseBooleanValue("0")).toBe(false);
+    expect(parseBooleanValue("no")).toBe(false);
+    expect(parseBooleanValue("off")).toBe(false);
+  });
+
+  it("respects custom truthy/falsy lists", () => {
+    expect(
+      parseBooleanValue("on", {
+        truthy: ["true"],
+        falsy: ["false"],
+      }),
+    ).toBeUndefined();
+    expect(
+      parseBooleanValue("yes", {
+        truthy: ["yes"],
+        falsy: ["no"],
+      }),
+    ).toBe(true);
+  });
+
+  it("returns undefined for unsupported values", () => {
+    expect(parseBooleanValue("")).toBeUndefined();
+    expect(parseBooleanValue("maybe")).toBeUndefined();
+    expect(parseBooleanValue(1)).toBeUndefined();
+  });
+});
+
+describe("isReasoningTagProvider", () => {
+  it("returns false for ollama - native reasoning field, no tags needed (#2279)", () => {
+    expect(isReasoningTagProvider("ollama")).toBe(false);
+    expect(isReasoningTagProvider("Ollama")).toBe(false);
+  });
+
+  it("returns true for google-gemini-cli", () => {
+    expect(isReasoningTagProvider("google-gemini-cli")).toBe(true);
+  });
+
+  it("returns true for google-generative-ai", () => {
+    expect(isReasoningTagProvider("google-generative-ai")).toBe(true);
+  });
+
+  it("returns true for google-antigravity", () => {
+    expect(isReasoningTagProvider("google-antigravity")).toBe(true);
+    expect(isReasoningTagProvider("google-antigravity/gemini-3")).toBe(true);
+  });
+
+  it("returns true for minimax", () => {
+    expect(isReasoningTagProvider("minimax")).toBe(true);
+    expect(isReasoningTagProvider("minimax-cn")).toBe(true);
+  });
+
+  it("returns false for null/undefined/empty", () => {
+    expect(isReasoningTagProvider(null)).toBe(false);
+    expect(isReasoningTagProvider(undefined)).toBe(false);
+    expect(isReasoningTagProvider("")).toBe(false);
+  });
+
+  it("returns false for standard providers", () => {
+    expect(isReasoningTagProvider("anthropic")).toBe(false);
+    expect(isReasoningTagProvider("openai")).toBe(false);
+    expect(isReasoningTagProvider("openrouter")).toBe(false);
+  });
+});
+
+describe("splitShellArgs", () => {
+  it("splits whitespace and respects quotes", () => {
+    expect(splitShellArgs(`qmd --foo "bar baz"`)).toEqual(["qmd", "--foo", "bar baz"]);
+    expect(splitShellArgs(`qmd --foo 'bar baz'`)).toEqual(["qmd", "--foo", "bar baz"]);
+  });
+
+  it("supports backslash escapes inside double quotes", () => {
+    expect(splitShellArgs(String.raw`echo "a\"b"`)).toEqual(["echo", `a"b`]);
+    expect(splitShellArgs(String.raw`echo "\$HOME"`)).toEqual(["echo", "$HOME"]);
+  });
+
+  it("returns null for unterminated quotes", () => {
+    expect(splitShellArgs(`echo "oops`)).toBeNull();
+    expect(splitShellArgs(`echo 'oops`)).toBeNull();
+  });
+});