Ayuriel/openclaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: merge command owner gating cases

Browse Source
This commit is contained in:
Peter Steinberger 2026-03-17 09:32:04 +00:00
parent f9408e57d2
commit 5a5a66d63d
1 changed files with 57 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

95
src/auto-reply/reply/commands.test.ts
View File

@ -729,32 +729,45 @@ describe("extractMessageText", () => {
});
describe("handleCommands /config owner gating", () => {
it("blocks /config show from authorized non-owner senders", async () => {
it("enforces /config show owner gating", async () => {
const cfg = {
commands: { config: true, text: true },
channels: { whatsapp: { allowFrom: ["*"] } },
} as OpenClawConfig;
const params = buildParams("/config show", cfg);
params.command.senderIsOwner = false;
const result = await handleCommands(params);
expect(result.shouldContinue).toBe(false);
expect(result.reply).toBeUndefined();
});
const cases = [
{
name: "blocks authorized non-owner senders",
text: "/config show",
senderIsOwner: false,
assert: (result: Awaited<ReturnType<typeof handleCommands>>) => {
expect(result.shouldContinue).toBe(false);
expect(result.reply).toBeUndefined();
},
},
{
name: "keeps /config show working for owners",
text: "/config show messages.ackReaction",
senderIsOwner: true,
beforeRun: () => {
readConfigFileSnapshotMock.mockResolvedValueOnce({
valid: true,
parsed: { messages: { ackReaction: ":)" } },
});
},
assert: (result: Awaited<ReturnType<typeof handleCommands>>) => {
expect(result.shouldContinue).toBe(false);
expect(result.reply?.text).toContain("Config messages.ackReaction");
},
},
] as const;
it("keeps /config show working for owners", async () => {
const cfg = {
commands: { config: true, text: true },
channels: { whatsapp: { allowFrom: ["*"] } },
} as OpenClawConfig;
readConfigFileSnapshotMock.mockResolvedValueOnce({
valid: true,
parsed: { messages: { ackReaction: ":)" } },
});
const params = buildParams("/config show messages.ackReaction", cfg);
params.command.senderIsOwner = true;
const result = await handleCommands(params);
expect(result.shouldContinue).toBe(false);
expect(result.reply?.text).toContain("Config messages.ackReaction");
for (const testCase of cases) {
testCase.beforeRun?.();
const params = buildParams(testCase.text, cfg);
params.command.senderIsOwner = testCase.senderIsOwner;
const result = await handleCommands(params);
testCase.assert(result);
}
});
});
@ -932,28 +945,34 @@ describe("handleCommands /config configWrites gating", () => {
});
describe("handleCommands /debug owner gating", () => {
it("blocks /debug show from authorized non-owner senders", async () => {
it("enforces /debug show owner gating", async () => {
const cfg = {
commands: { debug: true, text: true },
channels: { whatsapp: { allowFrom: ["*"] } },
} as OpenClawConfig;
const params = buildParams("/debug show", cfg);
params.command.senderIsOwner = false;
const result = await handleCommands(params);
expect(result.shouldContinue).toBe(false);
expect(result.reply).toBeUndefined();
});
const cases = [
{
senderIsOwner: false,
assert: (result: Awaited<ReturnType<typeof handleCommands>>) => {
expect(result.shouldContinue).toBe(false);
expect(result.reply).toBeUndefined();
},
},
{
senderIsOwner: true,
assert: (result: Awaited<ReturnType<typeof handleCommands>>) => {
expect(result.shouldContinue).toBe(false);
expect(result.reply?.text).toContain("Debug overrides");
},
},
] as const;
it("keeps /debug show working for owners", async () => {
const cfg = {
commands: { debug: true, text: true },
channels: { whatsapp: { allowFrom: ["*"] } },
} as OpenClawConfig;
const params = buildParams("/debug show", cfg);
params.command.senderIsOwner = true;
const result = await handleCommands(params);
expect(result.shouldContinue).toBe(false);
expect(result.reply?.text).toContain("Debug overrides");
for (const testCase of cases) {
const params = buildParams("/debug show", cfg);
params.command.senderIsOwner = testCase.senderIsOwner;
const result = await handleCommands(params);
testCase.assert(result);
}
});
});