From 627743aa3820b5ce4beb727db8c793325d969cd8 Mon Sep 17 00:00:00 2001
From: ShionElia <supercutelulu@hotmail.com>
Date: Wed, 18 Mar 2026 10:05:29 +0000
Subject: [PATCH] fix: trigger model failover for generic provider error
 messages

When Anthropic returns a generic error like 'An unknown error occurred'
without a type field, classifyFailoverReason() now recognizes it as a
transient failure and returns 'timeout' to trigger model failover.

Also handles other generic error patterns: 'an error occurred',
'internal server error', and 'service unavailable'.

Fixes #49706
---
 ...mbedded-helpers.isbillingerrormessage.test.ts | 13 +++++++++++++
 src/agents/pi-embedded-helpers/errors.ts         | 16 ++++++++++++++++
 2 files changed, 29 insertions(+)

diff --git a/src/agents/pi-embedded-helpers.isbillingerrormessage.test.ts b/src/agents/pi-embedded-helpers.isbillingerrormessage.test.ts
index 8c0a0b1994d..141368bf366 100644
--- a/src/agents/pi-embedded-helpers.isbillingerrormessage.test.ts
+++ b/src/agents/pi-embedded-helpers.isbillingerrormessage.test.ts
@@ -860,4 +860,17 @@ describe("classifyFailoverReason", () => {
       ),
     ).toBe("timeout");
   });
+  it("classifies generic provider errors as timeout", () => {
+    expect(classifyFailoverReason("An unknown error occurred")).toBe("timeout");
+    expect(classifyFailoverReason("An error occurred")).toBe("timeout");
+    expect(classifyFailoverReason("Internal server error")).toBe("timeout");
+    expect(classifyFailoverReason("Service unavailable")).toBe("timeout");
+    // Case-insensitive
+    expect(classifyFailoverReason("AN UNKNOWN ERROR OCCURRED")).toBe("timeout");
+    expect(classifyFailoverReason("an error occurred while processing")).toBe("timeout");
+    // Wrapped in provider payload
+    expect(classifyFailoverReason('{"error":{"message":"An unknown error occurred"}}')).toBe(
+      "timeout",
+    );
+  });
 });
diff --git a/src/agents/pi-embedded-helpers/errors.ts b/src/agents/pi-embedded-helpers/errors.ts
index 6e38d831ad9..99adc32149f 100644
--- a/src/agents/pi-embedded-helpers/errors.ts
+++ b/src/agents/pi-embedded-helpers/errors.ts
@@ -846,6 +846,19 @@ export function isBillingAssistantError(msg: AssistantMessage | undefined): bool
   return isBillingErrorMessage(msg.errorMessage ?? "");
 }
 
+function isGenericProviderError(raw: string): boolean {
+  if (!raw) {
+    return false;
+  }
+  const lower = raw.toLowerCase();
+  return (
+    lower.includes("an unknown error occurred") ||
+    lower.includes("an error occurred") ||
+    lower.includes("internal server error") ||
+    lower.includes("service unavailable")
+  );
+}
+
 function isJsonApiInternalServerError(raw: string): boolean {
   if (!raw) {
     return false;
@@ -1024,6 +1037,9 @@ export function classifyFailoverReason(raw: string): FailoverReason | null {
   if (isAuthErrorMessage(raw)) {
     return "auth";
   }
+  if (isGenericProviderError(raw)) {
+    return "timeout";
+  }
   return null;
 }