Ayuriel/openclaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(browser): skip Playwright URL lookup for non-success responses

Browse Source 
Move CDP getPageForTargetId call inside eligibility check so error/4xx
responses don't incur unnecessary connection latency. Also skip when url
is already set (no enrichment needed).

Note: cross-site navigations that trigger renderer swaps may invalidate
the pre-action targetId; documented as known limitation with tab.url
fallback.
This commit is contained in:
zeroaltitude 2026-03-04 16:30:18 -07:00
parent a8c59f3c58
commit 696dcd5ddd
No known key found for this signature in database
GPG Key ID: 77592FB1C703882E
1 changed files with 28 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
src/browser/routes/agent.shared.ts
View File

@ -180,23 +180,37 @@ export async function withRouteTabContext<T>(
// Now enrich and flush the intercepted response body.
if (jsonCalled) {
// Resolve live URL *after* the handler ran, so navigating actions
// report the post-action URL. Try Playwright first (actual page
// state), fall back to tab metadata URL.
// Only resolve the live URL when the response is eligible for
// enrichment (ok: true). Skip the Playwright CDP lookup for error
// responses to avoid unnecessary connection latency.
let postRunUrl: string | undefined;
try {
const pwMod = await getPwAiModuleBase({ mode: "soft" });
if (pwMod?.getPageForTargetId) {
const page = await pwMod.getPageForTargetId({
cdpUrl: profileCtx.profile.cdpUrl,
targetId: tab.targetId,
});
if (page) {
postRunUrl = page.url();
const isEligible =
interceptedBody &&
typeof interceptedBody === "object" &&
!Array.isArray(interceptedBody) &&
(interceptedBody as Record<string, unknown>).ok === true &&
(interceptedBody as Record<string, unknown>).url === undefined;
if (isEligible) {
// Resolve live URL *after* the handler ran, so navigating actions
// report the post-action URL. Try Playwright first (actual page
// state), fall back to tab metadata URL.
// Note: cross-site navigations that trigger a renderer swap may
// invalidate tab.targetId; in that case getPageForTargetId returns
// null and we fall back to the (possibly stale) tab.url.
try {
const pwMod = await getPwAiModuleBase({ mode: "soft" });
if (pwMod?.getPageForTargetId) {
const page = await pwMod.getPageForTargetId({
cdpUrl: profileCtx.profile.cdpUrl,
targetId: tab.targetId,
});
if (page) {
postRunUrl = page.url();
}
}
} catch {
// Playwright unavailable — fall back to tab.url
}
} catch {
// Playwright unavailable — fall back to tab.url
}
enrichTabResponseBody(interceptedBody, tab, postRunUrl);
// Restore res.json before flushing so that if originalJson throws