From 7345a70f8664e4e7487244e1ae504c153ee26b10 Mon Sep 17 00:00:00 2001 From: GodsBoy Date: Fri, 20 Mar 2026 19:01:41 +0200 Subject: [PATCH] fix(install): address review feedback on ensureNvmCaCertsInDotEnv - Make platform/execPath injectable for testability (consistent with service-env builders) - Use regex anchor for NODE_EXTRA_CA_CERTS check so commented-out lines don't prevent writing the active entry --- src/cli/daemon-cli/install.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/cli/daemon-cli/install.ts b/src/cli/daemon-cli/install.ts index 8663133f053..7be6b882643 100644 --- a/src/cli/daemon-cli/install.ts +++ b/src/cli/daemon-cli/install.ts @@ -142,8 +142,12 @@ function ensureNvmCaCertsInDotEnv(params: { env: Record; json: boolean; warnings: string[]; + platform?: NodeJS.Platform; + execPath?: string; }): void { - if (process.platform !== "linux" || !isNvmNode(params.env, process.execPath)) { + const platform = params.platform ?? process.platform; + const execPath = params.execPath ?? process.execPath; + if (platform !== "linux" || !isNvmNode(params.env, execPath)) { return; } if (params.env.NODE_EXTRA_CA_CERTS) { @@ -158,7 +162,7 @@ function ensureNvmCaCertsInDotEnv(params: { const stateDir = resolveGatewayStateDir(params.env); const envFile = path.join(stateDir, ".env"); const existing = fs.existsSync(envFile) ? fs.readFileSync(envFile, "utf8") : ""; - if (existing.includes("NODE_EXTRA_CA_CERTS")) { + if (/^NODE_EXTRA_CA_CERTS=/m.test(existing)) { return; } const line = `NODE_EXTRA_CA_CERTS=${caBundle}\n`;