From 8b135f3b45e66703064c98df923d675aa400172f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=BF=BB=E5=BD=B9?= Date: Fri, 13 Mar 2026 15:01:50 +0800 Subject: [PATCH] fix(image): address review feedback - remove redundant regex and dead code - Remove redundant /qwen-vl/, /qwen2-vl/, /qwen2\.5-vl/ patterns since /\bvl\b/ already matches these models via word boundaries - Add clarifying comment for the non-OpenRouter provider fallback path, explaining that OpenRouter returns early using isLikelyVisionModel --- src/agents/pi-embedded-runner/model.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/agents/pi-embedded-runner/model.ts b/src/agents/pi-embedded-runner/model.ts index 58e08c9160b..f7ebbc8177a 100644 --- a/src/agents/pi-embedded-runner/model.ts +++ b/src/agents/pi-embedded-runner/model.ts @@ -66,9 +66,6 @@ function isLikelyVisionModel(modelId: string): boolean { /llava/, /llama-3\.2.*vision/, /pixtral/, - /qwen-vl/, - /qwen2-vl/, - /qwen2\.5-vl/, ]; return visionPatterns.some((pattern) => pattern.test(lower)); } @@ -337,6 +334,8 @@ export function resolveModelWithRegistry(params: { }); } + // Fallback for non-OpenRouter providers with custom providerConfig or mock models. + // OpenRouter returns early above using isLikelyVisionModel heuristic. const configuredModel = providerConfig?.models?.find((candidate) => candidate.id === modelId); const providerHeaders = sanitizeModelHeaders(providerConfig?.headers, { stripSecretRefMarkers: true,