Ayuriel/openclaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(memory): correct QMD mcporter tool name mapping + add capability validation

Browse Source 
The mcporter bridge mapped searchMode 'query' to MCP tool 'deep_search',
but QMD's MCP server exposes this as 'query'. This mismatch caused all
mcporter-routed queries to fail silently, falling back to builtin BM25.

Changes:
- Fix 'deep_search' → 'query' in tool name mapping and type annotations
- Add startup capability validation: after mcporter daemon starts, run
  'mcporter list <server>' and warn if expected tools are missing

The validation catches tool-name drift between the bridge and QMD MCP
server at startup rather than failing silently at query time.

Fixes #49768
This commit is contained in:
Brian Newman 2026-03-18 13:57:28 -07:00
parent 91d37ccfc3
commit 905076ca1e
1 changed files with 29 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/memory/qmd-manager.ts
View File

@ -749,12 +749,12 @@ export class QmdMemoryManager implements MemorySearchManager {
): Promise<QmdQueryResult[]> => {
try {
if (mcporterEnabled) {
const tool: "search" | "vector_search" | "deep_search" =
const tool: "search" | "vector_search" | "query" =
qmdSearchCommand === "search"
? "search"
: qmdSearchCommand === "vsearch"
? "vector_search"
: "deep_search";
: "query";
const minScore = opts?.minScore ?? 0;
if (collectionNames.length > 1) {
return await this.runMcporterAcrossCollections({
@ -1234,6 +1234,31 @@ export class QmdMemoryManager implements MemorySearchManager {
log.warn(`mcporter daemon start failed: ${String(err)}`);
// Allow future searches to retry daemon start on transient failures.
delete g.__openclawMcporterDaemonStart;
return;
}
// Validate that the QMD MCP server exposes the expected tools.
try {
const expectedTools = ["search", "vector_search", "query"];
const listResult = await this.runMcporter(["list", mcporter.serverName], {
timeoutMs: 10_000,
});
const actualTools = listResult.stdout
.split("\n")
.map((l) => l.trim())
.filter(Boolean);
const missing = expectedTools.filter((t) => !actualTools.some((a) => a.includes(t)));
if (missing.length > 0) {
log.warn(
`mcporter bridge tool mismatch for server "${mcporter.serverName}": ` +
`expected tools [${expectedTools.join(", ")}], ` +
`actual tools [${actualTools.join(", ")}], ` +
`missing [${missing.join(", ")}]`,
);
}
} catch {
// Non-fatal: capability validation is best-effort.
log.warn("mcporter tool capability validation failed; continuing anyway");
}
})();
}
@ -1263,7 +1288,7 @@ export class QmdMemoryManager implements MemorySearchManager {
private async runQmdSearchViaMcporter(params: {
mcporter: ResolvedQmdMcporterConfig;
tool: "search" | "vector_search" | "deep_search";
tool: "search" | "vector_search" | "query";
query: string;
limit: number;
minScore: number;
@ -1997,7 +2022,7 @@ export class QmdMemoryManager implements MemorySearchManager {
}
private async runMcporterAcrossCollections(params: {
tool: "search" | "vector_search" | "deep_search";
tool: "search" | "vector_search" | "query";
query: string;
limit: number;
minScore: number;