From 95b4132674ed531a33fe2124847b8bf21f5c15f0 Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Sat, 14 Mar 2026 02:31:28 +0000
Subject: [PATCH] test: share provider discovery auth fixtures

---
 ...ls-config.providers.discovery-auth.test.ts | 108 +++++++-----------
 1 file changed, 42 insertions(+), 66 deletions(-)

diff --git a/src/agents/models-config.providers.discovery-auth.test.ts b/src/agents/models-config.providers.discovery-auth.test.ts
index e6aebc0d7cb..6fc492c1565 100644
--- a/src/agents/models-config.providers.discovery-auth.test.ts
+++ b/src/agents/models-config.providers.discovery-auth.test.ts
@@ -6,6 +6,11 @@ import { afterEach, describe, expect, it, vi } from "vitest";
 import { NON_ENV_SECRETREF_MARKER } from "./model-auth-markers.js";
 import { resolveImplicitProvidersForTest } from "./models-config.e2e-harness.js";
 
+type AuthProfilesFile = {
+  version: 1;
+  profiles: Record<string, Record<string, unknown>>;
+};
+
 describe("provider discovery auth marker guardrails", () => {
   let originalVitest: string | undefined;
   let originalNodeEnv: string | undefined;
@@ -35,33 +40,35 @@ describe("provider discovery auth marker guardrails", () => {
     delete process.env.NODE_ENV;
   }
 
-  it("does not send marker value as vLLM bearer token during discovery", async () => {
-    enableDiscovery();
-    const fetchMock = vi.fn().mockResolvedValue({
-      ok: true,
-      json: async () => ({ data: [] }),
-    });
+  function installFetchMock(response?: unknown) {
+    const fetchMock =
+      response === undefined
+        ? vi.fn()
+        : vi.fn().mockResolvedValue({ ok: true, json: async () => response });
     globalThis.fetch = fetchMock as unknown as typeof fetch;
+    return fetchMock;
+  }
 
+  async function createAgentDirWithAuthProfiles(profiles: AuthProfilesFile["profiles"]) {
     const agentDir = mkdtempSync(join(tmpdir(), "openclaw-test-"));
     await writeFile(
       join(agentDir, "auth-profiles.json"),
-      JSON.stringify(
-        {
-          version: 1,
-          profiles: {
-            "vllm:default": {
-              type: "api_key",
-              provider: "vllm",
-              keyRef: { source: "file", provider: "vault", id: "/vllm/apiKey" },
-            },
-          },
-        },
-        null,
-        2,
-      ),
+      JSON.stringify({ version: 1, profiles } satisfies AuthProfilesFile, null, 2),
       "utf8",
     );
+    return agentDir;
+  }
+
+  it("does not send marker value as vLLM bearer token during discovery", async () => {
+    enableDiscovery();
+    const fetchMock = installFetchMock({ data: [] });
+    const agentDir = await createAgentDirWithAuthProfiles({
+      "vllm:default": {
+        type: "api_key",
+        provider: "vllm",
+        keyRef: { source: "file", provider: "vault", id: "/vllm/apiKey" },
+      },
+    });
 
     const providers = await resolveImplicitProvidersForTest({ agentDir, env: {} });
     expect(providers?.vllm?.apiKey).toBe(NON_ENV_SECRETREF_MARKER);
@@ -73,28 +80,14 @@ describe("provider discovery auth marker guardrails", () => {
 
   it("does not call Hugging Face discovery with marker-backed credentials", async () => {
     enableDiscovery();
-    const fetchMock = vi.fn();
-    globalThis.fetch = fetchMock as unknown as typeof fetch;
-
-    const agentDir = mkdtempSync(join(tmpdir(), "openclaw-test-"));
-    await writeFile(
-      join(agentDir, "auth-profiles.json"),
-      JSON.stringify(
-        {
-          version: 1,
-          profiles: {
-            "huggingface:default": {
-              type: "api_key",
-              provider: "huggingface",
-              keyRef: { source: "exec", provider: "vault", id: "providers/hf/token" },
-            },
-          },
-        },
-        null,
-        2,
-      ),
-      "utf8",
-    );
+    const fetchMock = installFetchMock();
+    const agentDir = await createAgentDirWithAuthProfiles({
+      "huggingface:default": {
+        type: "api_key",
+        provider: "huggingface",
+        keyRef: { source: "exec", provider: "vault", id: "providers/hf/token" },
+      },
+    });
 
     const providers = await resolveImplicitProvidersForTest({ agentDir, env: {} });
     expect(providers?.huggingface?.apiKey).toBe(NON_ENV_SECRETREF_MARKER);
@@ -106,31 +99,14 @@ describe("provider discovery auth marker guardrails", () => {
 
   it("keeps all-caps plaintext API keys for authenticated discovery", async () => {
     enableDiscovery();
-    const fetchMock = vi.fn().mockResolvedValue({
-      ok: true,
-      json: async () => ({ data: [{ id: "vllm/test-model" }] }),
+    const fetchMock = installFetchMock({ data: [{ id: "vllm/test-model" }] });
+    const agentDir = await createAgentDirWithAuthProfiles({
+      "vllm:default": {
+        type: "api_key",
+        provider: "vllm",
+        key: "ALLCAPS_SAMPLE",
+      },
     });
-    globalThis.fetch = fetchMock as unknown as typeof fetch;
-
-    const agentDir = mkdtempSync(join(tmpdir(), "openclaw-test-"));
-    await writeFile(
-      join(agentDir, "auth-profiles.json"),
-      JSON.stringify(
-        {
-          version: 1,
-          profiles: {
-            "vllm:default": {
-              type: "api_key",
-              provider: "vllm",
-              key: "ALLCAPS_SAMPLE",
-            },
-          },
-        },
-        null,
-        2,
-      ),
-      "utf8",
-    );
 
     await resolveImplicitProvidersForTest({ agentDir, env: {} });
     const vllmCall = fetchMock.mock.calls.find(([url]) => String(url).includes(":8000"));