From 9c1e9c5263c51be6e32a3ed169be2d0a4a0859e6 Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Tue, 17 Mar 2026 07:39:44 +0000
Subject: [PATCH] refactor(payload-tests): share empty payload helper

---
 .../pi-embedded-runner/run/payloads.test.ts   | 21 ++++++++-----------
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/src/agents/pi-embedded-runner/run/payloads.test.ts b/src/agents/pi-embedded-runner/run/payloads.test.ts
index 6c81fb12150..52a88368c50 100644
--- a/src/agents/pi-embedded-runner/run/payloads.test.ts
+++ b/src/agents/pi-embedded-runner/run/payloads.test.ts
@@ -2,13 +2,16 @@ import { describe, expect, it } from "vitest";
 import { buildPayloads, expectSingleToolErrorPayload } from "./payloads.test-helpers.js";
 
 describe("buildEmbeddedRunPayloads tool-error warnings", () => {
+  function expectNoPayloads(params: Parameters<typeof buildPayloads>[0]) {
+    const payloads = buildPayloads(params);
+    expect(payloads).toHaveLength(0);
+  }
+
   it("suppresses exec tool errors when verbose mode is off", () => {
-    const payloads = buildPayloads({
+    expectNoPayloads({
       lastToolError: { toolName: "exec", error: "command failed" },
       verboseLevel: "off",
     });
-
-    expect(payloads).toHaveLength(0);
   });
 
   it("shows exec tool errors when verbose mode is on", () => {
@@ -62,16 +65,14 @@ describe("buildEmbeddedRunPayloads tool-error warnings", () => {
   });
 
   it("suppresses sessions_send errors to avoid leaking transient relay failures", () => {
-    const payloads = buildPayloads({
+    expectNoPayloads({
       lastToolError: { toolName: "sessions_send", error: "delivery timeout" },
       verboseLevel: "on",
     });
-
-    expect(payloads).toHaveLength(0);
   });
 
   it("suppresses sessions_send errors even when marked mutating", () => {
-    const payloads = buildPayloads({
+    expectNoPayloads({
       lastToolError: {
         toolName: "sessions_send",
         error: "delivery timeout",
@@ -79,16 +80,12 @@ describe("buildEmbeddedRunPayloads tool-error warnings", () => {
       },
       verboseLevel: "on",
     });
-
-    expect(payloads).toHaveLength(0);
   });
 
   it("suppresses assistant text when a deterministic exec approval prompt was already delivered", () => {
-    const payloads = buildPayloads({
+    expectNoPayloads({
       assistantTexts: ["Approval is needed. Please run /approve abc allow-once"],
       didSendDeterministicApprovalPrompt: true,
     });
-
-    expect(payloads).toHaveLength(0);
   });
 });