Ayuriel/openclaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

browser: scope wss:// special handling to remote profiles only

Browse Source 
Loopback ws:// profiles are locally-managed and need the normal
launch/attach/probe flow. Only skip throwaway WebSocket probes and
use lazy connection for remote (non-loopback) WebSocket profiles.
This commit is contained in:
ShawnPana 2026-03-11 11:30:08 -07:00
parent 0aeddd8af9
commit a3fdb664d2
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/browser/server-context.availability.ts
View File

@ -62,10 +62,11 @@ export function createProfileAvailability({
}); });
const isReachable = async (timeoutMs?: number) => { const isReachable = async (timeoutMs?: number) => {
// For direct WebSocket endpoints (e.g. Browser Use), each raw CDP health check // For remote WebSocket endpoints (e.g. Browser Use, Browserbase), each raw CDP
// opens a new WebSocket which may provision a new browser session. Check the // health check opens a new WebSocket which may provision a new browser session.
// cached Playwright connection instead — it reflects the actual connection state. // Check the cached Playwright connection instead — it reflects the actual state.
if (isWebSocketUrl(profile.cdpUrl)) { // Loopback ws:// profiles are locally-managed and use normal HTTP-based probes.
if (capabilities.isRemote && isWebSocketUrl(profile.cdpUrl)) {
return hasActivePlaywrightConnection(profile.cdpUrl); return hasActivePlaywrightConnection(profile.cdpUrl);
} }
const { httpTimeoutMs, wsTimeoutMs } = resolveTimeouts(timeoutMs); const { httpTimeoutMs, wsTimeoutMs } = resolveTimeouts(timeoutMs);
@ -73,7 +74,7 @@ export function createProfileAvailability({
}; };
const isHttpReachable = async (timeoutMs?: number) => { const isHttpReachable = async (timeoutMs?: number) => {
if (isWebSocketUrl(profile.cdpUrl)) { if (capabilities.isRemote && isWebSocketUrl(profile.cdpUrl)) {
return hasActivePlaywrightConnection(profile.cdpUrl); return hasActivePlaywrightConnection(profile.cdpUrl);
} }
const { httpTimeoutMs } = resolveTimeouts(timeoutMs); const { httpTimeoutMs } = resolveTimeouts(timeoutMs);
@ -180,10 +181,11 @@ export function createProfileAvailability({
} }
if (!httpReachable) { if (!httpReachable) {
// Direct WebSocket endpoints (e.g. Browser Use) are on-demand — no need to probe // Remote WebSocket endpoints (e.g. Browser Use) are on-demand — no need to probe
// reachability up front. The Playwright connection is established lazily in // reachability up front. The Playwright connection is established lazily in
// connectBrowser when a tab operation actually needs it. // connectBrowser when a tab operation actually needs it.
if (isWebSocketUrl(profile.cdpUrl)) { // Loopback ws:// profiles still need the normal launch/attach flow below.
if (capabilities.isRemote && isWebSocketUrl(profile.cdpUrl)) {
return; return;
} }
if ((attachOnly || remoteCdp) && opts.onEnsureAttachTarget) { if ((attachOnly || remoteCdp) && opts.onEnsureAttachTarget) {
@ -255,9 +257,9 @@ export function createProfileAvailability({
const stopRunningBrowser = async (): Promise<{ stopped: boolean }> => { const stopRunningBrowser = async (): Promise<{ stopped: boolean }> => {
await reconcileProfileRuntime(); await reconcileProfileRuntime();
// For direct WebSocket endpoints (e.g. Browser Use), there's no local Chrome process // For remote WebSocket endpoints (e.g. Browser Use), there's no local Chrome process
// to stop. Instead, close the cached Playwright connection to the cloud provider. // to stop. Instead, close the cached Playwright connection to the cloud provider.
if (isWebSocketUrl(profile.cdpUrl)) { if (capabilities.isRemote && isWebSocketUrl(profile.cdpUrl)) {
await closePlaywrightBrowserConnection({ cdpUrl: profile.cdpUrl }); await closePlaywrightBrowserConnection({ cdpUrl: profile.cdpUrl });
return { stopped: true }; return { stopped: true };
} }