From acd6ddb829d7329514fb582764c27e514adb33f2 Mon Sep 17 00:00:00 2001 From: Onur <2453968+osolmaz@users.noreply.github.com> Date: Sun, 1 Mar 2026 14:41:45 +0100 Subject: [PATCH] ACP: hide tool_call tags by default --- src/auto-reply/reply/acp-projector.test.ts | 13 +++++++++++++ src/auto-reply/reply/acp-stream-settings.test.ts | 3 ++- src/auto-reply/reply/acp-stream-settings.ts | 4 ++-- 3 files changed, 17 insertions(+), 3 deletions(-) diff --git a/src/auto-reply/reply/acp-projector.test.ts b/src/auto-reply/reply/acp-projector.test.ts index 755122e5198..8289800ca8d 100644 --- a/src/auto-reply/reply/acp-projector.test.ts +++ b/src/auto-reply/reply/acp-projector.test.ts @@ -40,6 +40,7 @@ describe("createAcpReplyProjector", () => { deliveryMode: "final_only", tagVisibility: { available_commands_update: true, + tool_call: true, }, }, }, @@ -99,6 +100,7 @@ describe("createAcpReplyProjector", () => { deliveryMode: "final_only", tagVisibility: { available_commands_update: true, + tool_call: true, }, }, }, @@ -231,6 +233,10 @@ describe("createAcpReplyProjector", () => { enabled: true, stream: { deliveryMode: "live", + tagVisibility: { + tool_call: true, + tool_call_update: true, + }, }, }, }), @@ -289,6 +295,10 @@ describe("createAcpReplyProjector", () => { enabled: true, stream: { deliveryMode: "live", + tagVisibility: { + tool_call: true, + tool_call_update: true, + }, }, }, }), @@ -324,6 +334,8 @@ describe("createAcpReplyProjector", () => { repeatSuppression: false, tagVisibility: { available_commands_update: true, + tool_call: true, + tool_call_update: true, }, }, }, @@ -528,6 +540,7 @@ describe("createAcpReplyProjector", () => { maxChunkChars: 256, deliveryMode: "live", tagVisibility: { + tool_call: true, tool_call_update: false, }, }, diff --git a/src/auto-reply/reply/acp-stream-settings.test.ts b/src/auto-reply/reply/acp-stream-settings.test.ts index 918136d852d..3cc63370c2d 100644 --- a/src/auto-reply/reply/acp-stream-settings.test.ts +++ b/src/auto-reply/reply/acp-stream-settings.test.ts @@ -55,7 +55,8 @@ describe("acp stream settings", () => { it("uses default tag visibility when no override is provided", () => { const settings = resolveAcpProjectionSettings(createAcpTestConfig()); - expect(isAcpTagVisible(settings, "tool_call")).toBe(true); + expect(isAcpTagVisible(settings, "tool_call")).toBe(false); + expect(isAcpTagVisible(settings, "tool_call_update")).toBe(false); expect(isAcpTagVisible(settings, "usage_update")).toBe(false); }); diff --git a/src/auto-reply/reply/acp-stream-settings.ts b/src/auto-reply/reply/acp-stream-settings.ts index 634df888dfb..55aaf339fa7 100644 --- a/src/auto-reply/reply/acp-stream-settings.ts +++ b/src/auto-reply/reply/acp-stream-settings.ts @@ -13,8 +13,8 @@ const DEFAULT_ACP_MAX_META_EVENTS_PER_TURN = 64; export const ACP_TAG_VISIBILITY_DEFAULTS: Record = { agent_message_chunk: true, - tool_call: true, - tool_call_update: true, + tool_call: false, + tool_call_update: false, usage_update: false, available_commands_update: false, current_mode_update: false,