From bef0b8c8bb75ea08348d197e7195389398d5f866 Mon Sep 17 00:00:00 2001 From: Raul <77628552+raulvidis@users.noreply.github.com> Date: Tue, 10 Mar 2026 08:48:08 +0200 Subject: [PATCH] Fix unused orphanDeleted variable in mid-stream catch block The variable was assigned but never read since fallback delivery is intentionally unconditional in this path. Fixes lint error. Co-Authored-By: Claude Opus 4.6 --- src/slack/monitor/message-handler/dispatch.ts | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/slack/monitor/message-handler/dispatch.ts b/src/slack/monitor/message-handler/dispatch.ts index bf4d862cbec..09121002a41 100644 --- a/src/slack/monitor/message-handler/dispatch.ts +++ b/src/slack/monitor/message-handler/dispatch.ts @@ -311,11 +311,7 @@ export async function dispatchPreparedSlackMessage(prepared: PreparedSlackMessag // If startStream already created a Slack message, delete it to prevent // the orphaned stream message from persisting alongside the fallback. - // Only deliver the fallback when deletion succeeds (or no orphan - // existed) — if deletion fails the stream message is still visible, so - // sending a normal reply would recreate the duplicate this PR prevents. const orphanedTs = streamSession?.streamMessageTs; - let orphanDeleted = !orphanedTs; // trivially "deleted" if nothing to delete if (orphanedTs) { try { await ctx.app.client.chat.delete({ @@ -324,7 +320,6 @@ export async function dispatchPreparedSlackMessage(prepared: PreparedSlackMessag ts: orphanedTs, }); logVerbose(`slack-stream: deleted orphaned stream message ${orphanedTs}`); - orphanDeleted = true; } catch (deleteErr) { logVerbose( `slack-stream: failed to delete orphaned stream message ${orphanedTs}: ${String(deleteErr)}`,