Ayuriel/openclaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: record cross-turn dedup synchronously before async send

Browse Source 
Move recordDeliveredText() from the async post-delivery callback in
emitBlockReplySafely to the synchronous path in emitBlockChunk, before
the Telegram send. This closes the race window where context compaction
could trigger a new assistant turn while the delivery is still in-flight,
bypassing the dedup cache entirely.

Trade-off: if the send fails transiently the text remains in the cache,
but the 1-hour TTL ensures it won't suppress the same content forever.
This matches the synchronous recording already done in pushAssistantText.

Also fixes the hash comment: Math.imul + >>> 0 produce a 32-bit hash,
not 53-bit.

Addresses review feedback from greptile-apps.
This commit is contained in:
eveiljuice 2026-03-08 06:00:56 +00:00 committed by Vincent Koc
parent 6bee86e618
commit db7c093f07
2 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/agents/pi-embedded-helpers/messaging-dedupe.ts
View File

@ -23,7 +23,7 @@ export type RecentDeliveredEntry = {
* Build a collision-resistant hash from the full normalised text of a
* delivered assistant message. Uses a fast non-cryptographic approach:
* the first 200 normalised chars (for quick prefix screening) combined
* with the total length and a simple 53-bit numeric hash of the full
* with the total length and a simple 32-bit numeric hash of the full
* string. This avoids false positives when two responses share the same
* opening paragraph but diverge later.
*/
@ -32,7 +32,7 @@ export function buildDeliveredTextHash(text: string): string {
if (normalized.length <= 200) {
return normalized;
}
// 53-bit FNV-1a-inspired hash (fits in a JS safe integer).
// 32-bit FNV-1a-inspired hash (Math.imul + >>> 0 operate on 32-bit integers).
let h = 0x811c9dc5;
for (let i = 0; i < normalized.length; i++) {
h ^= normalized.charCodeAt(i);

17
src/agents/pi-embedded-subscribe.ts
View File

@ -114,13 +114,6 @@ export function subscribeEmbeddedPiSession(params: SubscribeEmbeddedPiSessionPar
}
void Promise.resolve()
.then(() => params.onBlockReply?.(payload))
.then(() => {
// Record in cross-turn dedup cache only after successful delivery.
// Recording before send would suppress retries on transient failures.
if (opts?.sourceText) {
recordDeliveredText(opts.sourceText, state.recentDeliveredTexts);
}
})
.catch((err) => {
log.warn(`block reply callback failed: ${String(err)}`);
});
@ -525,10 +518,14 @@ export function subscribeEmbeddedPiSession(params: SubscribeEmbeddedPiSessionPar
state.lastBlockReplyText = chunk;
assistantTexts.push(chunk);
rememberAssistantText(chunk);
// Record in cross-turn dedup cache synchronously — before the async
// delivery — to close the race window where context compaction could
// trigger a new turn while the Telegram send is still in-flight.
// This matches the synchronous recording in pushAssistantText.
// Trade-off: if the send fails transiently the text stays in the cache,
// but the 1-hour TTL ensures it won't suppress the same text forever.
recordDeliveredText(chunk, state.recentDeliveredTexts);
if (!params.onBlockReply) {
// No block reply callback — text is accumulated for final delivery.
// Record now since there's no async send that could fail.
recordDeliveredText(chunk, state.recentDeliveredTexts);
return;
}
const splitResult = replyDirectiveAccumulator.consume(chunk);