Ayuriel/openclaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(acp): reuse normalizeAttachments() for media resolution in dispatch-acp

Browse Source 
Replace custom MediaPaths/MediaTypes parsing with the existing
normalizeAttachments() + normalizeAttachmentPath() from
media-understanding/attachments.normalize, which already handles
all edge cases (file:// URIs, single vs array, MediaUrl fallback).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
lumen claw 2026-03-09 05:49:56 -07:00
parent 6f27dd51a7
commit e57fd4bbb1
1 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/auto-reply/reply/dispatch-acp.ts
View File

@ -1,6 +1,10 @@
import fs from "node:fs/promises";
import { getAcpSessionManager } from "../../acp/control-plane/manager.js";
import type { AcpTurnAttachment } from "../../acp/control-plane/manager.types.js";
import {
normalizeAttachmentPath,
normalizeAttachments,
} from "../../media-understanding/attachments.normalize.js";
import { resolveAcpAgentPolicyError, resolveAcpDispatchPolicyError } from "../../acp/policy.js";
import { formatAcpRuntimeErrorText } from "../../acp/runtime/error-text.js";
import { toAcpRuntimeError } from "../../acp/runtime/errors.js";
@ -60,21 +64,16 @@ function resolveAcpPromptText(ctx: FinalizedMsgContext): string {
}
async function resolveAcpAttachments(ctx: FinalizedMsgContext): Promise<AcpTurnAttachment[]> {
const paths = ctx.MediaPaths;
const types = ctx.MediaTypes;
if (!Array.isArray(paths) || paths.length === 0) {
return [];
}
const mediaAttachments = normalizeAttachments(ctx);
const results: AcpTurnAttachment[] = [];
for (let i = 0; i < paths.length; i++) {
const filePath = paths[i];
const mediaType = Array.isArray(types) ? (types[i] ?? "application/octet-stream") : "application/octet-stream";
if (typeof filePath !== "string" || !filePath.trim()) {
for (const attachment of mediaAttachments) {
const filePath = normalizeAttachmentPath(attachment.path);
if (!filePath) {
continue;
}
try {
const buf = await fs.readFile(filePath);
results.push({ mediaType, data: buf.toString("base64") });
results.push({ mediaType: attachment.mime ?? "application/octet-stream", data: buf.toString("base64") });
} catch {
// Skip unreadable files — do not block the text turn.
}