From ec10de7361e99d32eed200c551f59b975dde2166 Mon Sep 17 00:00:00 2001 From: teconomix Date: Sat, 14 Mar 2026 06:04:44 +0000 Subject: [PATCH] fix(mattermost): inherit agent block-streaming default in button/model-picker paths When account.blockStreaming is unset, pass undefined instead of false for disableBlockStreaming so downstream get-reply-directives inherits the agent-level default rather than forcing block streaming on. Affected paths: button-click interactions (handleInteractiveMenuInteraction) and model picker confirmations (handleModelPickerInteraction). slash-http.ts already used undefined correctly; this brings monitor.ts into alignment. Addresses Codex P2 review: 'Preserve inherited block-streaming default for model picker replies' and 'Preserve default block-streaming behavior for button replies'. --- extensions/mattermost/src/mattermost/monitor.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/extensions/mattermost/src/mattermost/monitor.ts b/extensions/mattermost/src/mattermost/monitor.ts index b187e0cd44b..d374ba60dc8 100644 --- a/extensions/mattermost/src/mattermost/monitor.ts +++ b/extensions/mattermost/src/mattermost/monitor.ts @@ -518,7 +518,7 @@ export async function monitorMattermostProvider(opts: MonitorMattermostOpts = {} replyOptions: { ...replyOptions, disableBlockStreaming: - typeof account.blockStreaming === "boolean" ? !account.blockStreaming : false, + typeof account.blockStreaming === "boolean" ? !account.blockStreaming : undefined, onModelSelected, }, }); @@ -731,7 +731,7 @@ export async function monitorMattermostProvider(opts: MonitorMattermostOpts = {} replyOptions: { ...replyOptions, disableBlockStreaming: - typeof account.blockStreaming === "boolean" ? !account.blockStreaming : false, + typeof account.blockStreaming === "boolean" ? !account.blockStreaming : undefined, onModelSelected, }, }),