From f14ea9f77f6336684ee16ad7c56588787f7d5c95 Mon Sep 17 00:00:00 2001
From: Dale <dbabiy@gmail.com>
Date: Sun, 8 Mar 2026 04:06:33 -0400
Subject: [PATCH] fix(signal): remove stale 'unknown' MediaKind comparisons

kindFromMime() returns MediaKind | undefined, never the string 'unknown'.
The old guard against <media:unknown> was based on prior behavior that no
longer exists. Simplify to: use <media:> when kind is defined,
fall back to <media:attachment> when attachments are present but mime is
unresolvable, and emit nothing for blank envelopes.
---
 extensions/signal/src/monitor/event-handler.ts | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/extensions/signal/src/monitor/event-handler.ts b/extensions/signal/src/monitor/event-handler.ts
index 60d710f1b9b..3db0acf8078 100644
--- a/extensions/signal/src/monitor/event-handler.ts
+++ b/extensions/signal/src/monitor/event-handler.ts
@@ -862,13 +862,12 @@ export function createSignalEventHandler(deps: SignalEventHandlerDeps) {
       placeholder = formatAttachmentSummaryPlaceholder(mediaTypes);
     } else {
       // Only set placeholder when we actually resolved a mediaType.
-      // kindFromMime(undefined) returns "unknown" which is truthy — guard against
-      // that case so null-body messages (e.g. blank reaction envelopes) aren't dispatched
-      // with <media:unknown> as the body.
+      // Guard against undefined kind (e.g. blank reaction envelopes) so null-body
+      // messages aren't dispatched with a spurious <media:…> body.
       const kind = mediaType ? kindFromMime(mediaType) : undefined;
-      if (kind && kind !== "unknown") {
+      if (kind) {
         placeholder = `<media:${kind}>`;
-      } else if (kind === "unknown" || (!kind && dataMessage.attachments?.length)) {
+      } else if (dataMessage.attachments?.length) {
         placeholder = "<media:attachment>";
       }
     }