* docs: add ACP thread-bound agents plan doc * docs: expand ACP implementation specification * feat(acp): route ACP sessions through core dispatch and lifecycle cleanup * feat(acp): add /acp commands and Discord spawn gate * ACP: add acpx runtime plugin backend * fix(subagents): defer transient lifecycle errors before announce * Agents: harden ACP sessions_spawn and tighten spawn guidance * Agents: require explicit ACP target for runtime spawns * docs: expand ACP control-plane implementation plan * ACP: harden metadata seeding and spawn guidance * ACP: centralize runtime control-plane manager and fail-closed dispatch * ACP: harden runtime manager and unify spawn helpers * Commands: route ACP sessions through ACP runtime in agent command * ACP: require persisted metadata for runtime spawns * Sessions: preserve ACP metadata when updating entries * Plugins: harden ACP backend registry across loaders * ACPX: make availability probe compatible with adapters * E2E: add manual Discord ACP plain-language smoke script * ACPX: preserve streamed spacing across Discord delivery * Docs: add ACP Discord streaming strategy * ACP: harden Discord stream buffering for thread replies * ACP: reuse shared block reply pipeline for projector * ACP: unify streaming config and adopt coalesceIdleMs * Docs: add temporary ACP production hardening plan * Docs: trim temporary ACP hardening plan goals * Docs: gate ACP thread controls by backend capabilities * ACP: add capability-gated runtime controls and /acp operator commands * Docs: remove temporary ACP hardening plan * ACP: fix spawn target validation and close cache cleanup * ACP: harden runtime dispatch and recovery paths * ACP: split ACP command/runtime internals and centralize policy * ACP: harden runtime lifecycle, validation, and observability * ACP: surface runtime and backend session IDs in thread bindings * docs: add temp plan for binding-service migration * ACP: migrate thread binding flows to SessionBindingService * ACP: address review feedback and preserve prompt wording * ACPX plugin: pin runtime dependency and prefer bundled CLI * Discord: complete binding-service migration cleanup and restore ACP plan * Docs: add standalone ACP agents guide * ACP: route harness intents to thread-bound ACP sessions * ACP: fix spawn thread routing and queue-owner stall * ACP: harden startup reconciliation and command bypass handling * ACP: fix dispatch bypass type narrowing * ACP: align runtime metadata to agentSessionId * ACP: normalize session identifier handling and labels * ACP: mark thread banner session ids provisional until first reply * ACP: stabilize session identity mapping and startup reconciliation * ACP: add resolved session-id notices and cwd in thread intros * Discord: prefix thread meta notices consistently * Discord: unify ACP/thread meta notices with gear prefix * Discord: split thread persona naming from meta formatting * Extensions: bump acpx plugin dependency to 0.1.9 * Agents: gate ACP prompt guidance behind acp.enabled * Docs: remove temp experiment plan docs * Docs: scope streaming plan to holy grail refactor * Docs: refactor ACP agents guide for human-first flow * Docs/Skill: add ACP feature-flag guidance and direct acpx telephone-game flow * Docs/Skill: add OpenCode and Pi to ACP harness lists * Docs/Skill: align ACP harness list with current acpx registry * Dev/Test: move ACP plain-language smoke script and mark as keep * Docs/Skill: reorder ACP harness lists with Pi first * ACP: split control-plane manager into core/types/utils modules * Docs: refresh ACP thread-bound agents plan * ACP: extract dispatch lane and split manager domains * ACP: centralize binding context and remove reverse deps * Infra: unify system message formatting * ACP: centralize error boundaries and session id rendering * ACP: enforce init concurrency cap and strict meta clear * Tests: fix ACP dispatch binding mock typing * Tests: fix Discord thread-binding mock drift and ACP request id * ACP: gate slash bypass and persist cleared overrides * ACPX: await pre-abort cancel before runTurn return * Extension: pin acpx runtime dependency to 0.1.11 * Docs: add pinned acpx install strategy for ACP extension * Extensions/acpx: enforce strict local pinned startup * Extensions/acpx: tighten acp-router install guidance * ACPX: retry runtime test temp-dir cleanup * Extensions/acpx: require proactive ACPX repair for thread spawns * Extensions/acpx: require restart offer after acpx reinstall * extensions/acpx: remove workspace protocol devDependency * extensions/acpx: bump pinned acpx to 0.1.13 * extensions/acpx: sync lockfile after dependency bump * ACPX: make runtime spawn Windows-safe * fix: align doctor-config-flow repair tests with default-account migration (#23580) (thanks @osolmaz)
170 lines
4.8 KiB
TypeScript
170 lines
4.8 KiB
TypeScript
import type { PluginLogger } from "openclaw/plugin-sdk";
|
|
import { ACPX_LOCAL_INSTALL_COMMAND, ACPX_PINNED_VERSION, ACPX_PLUGIN_ROOT } from "./config.js";
|
|
import { resolveSpawnFailure, spawnAndCollect } from "./runtime-internals/process.js";
|
|
|
|
const SEMVER_PATTERN = /\b\d+\.\d+\.\d+(?:-[0-9A-Za-z.-]+)?\b/;
|
|
|
|
export type AcpxVersionCheckResult =
|
|
| {
|
|
ok: true;
|
|
version: string;
|
|
expectedVersion: string;
|
|
}
|
|
| {
|
|
ok: false;
|
|
reason: "missing-command" | "missing-version" | "version-mismatch" | "execution-failed";
|
|
message: string;
|
|
expectedVersion: string;
|
|
installCommand: string;
|
|
installedVersion?: string;
|
|
};
|
|
|
|
function extractVersion(stdout: string, stderr: string): string | null {
|
|
const combined = `${stdout}\n${stderr}`;
|
|
const match = combined.match(SEMVER_PATTERN);
|
|
return match?.[0] ?? null;
|
|
}
|
|
|
|
export async function checkPinnedAcpxVersion(params: {
|
|
command: string;
|
|
cwd?: string;
|
|
expectedVersion?: string;
|
|
}): Promise<AcpxVersionCheckResult> {
|
|
const expectedVersion = params.expectedVersion ?? ACPX_PINNED_VERSION;
|
|
const cwd = params.cwd ?? ACPX_PLUGIN_ROOT;
|
|
const result = await spawnAndCollect({
|
|
command: params.command,
|
|
args: ["--version"],
|
|
cwd,
|
|
});
|
|
|
|
if (result.error) {
|
|
const spawnFailure = resolveSpawnFailure(result.error, cwd);
|
|
if (spawnFailure === "missing-command") {
|
|
return {
|
|
ok: false,
|
|
reason: "missing-command",
|
|
message: `acpx command not found at ${params.command}`,
|
|
expectedVersion,
|
|
installCommand: ACPX_LOCAL_INSTALL_COMMAND,
|
|
};
|
|
}
|
|
return {
|
|
ok: false,
|
|
reason: "execution-failed",
|
|
message: result.error.message,
|
|
expectedVersion,
|
|
installCommand: ACPX_LOCAL_INSTALL_COMMAND,
|
|
};
|
|
}
|
|
|
|
if ((result.code ?? 0) !== 0) {
|
|
const stderr = result.stderr.trim();
|
|
return {
|
|
ok: false,
|
|
reason: "execution-failed",
|
|
message: stderr || `acpx --version failed with code ${result.code ?? "unknown"}`,
|
|
expectedVersion,
|
|
installCommand: ACPX_LOCAL_INSTALL_COMMAND,
|
|
};
|
|
}
|
|
|
|
const installedVersion = extractVersion(result.stdout, result.stderr);
|
|
if (!installedVersion) {
|
|
return {
|
|
ok: false,
|
|
reason: "missing-version",
|
|
message: "acpx --version output did not include a parseable version",
|
|
expectedVersion,
|
|
installCommand: ACPX_LOCAL_INSTALL_COMMAND,
|
|
};
|
|
}
|
|
|
|
if (installedVersion !== expectedVersion) {
|
|
return {
|
|
ok: false,
|
|
reason: "version-mismatch",
|
|
message: `acpx version mismatch: found ${installedVersion}, expected ${expectedVersion}`,
|
|
expectedVersion,
|
|
installCommand: ACPX_LOCAL_INSTALL_COMMAND,
|
|
installedVersion,
|
|
};
|
|
}
|
|
|
|
return {
|
|
ok: true,
|
|
version: installedVersion,
|
|
expectedVersion,
|
|
};
|
|
}
|
|
|
|
let pendingEnsure: Promise<void> | null = null;
|
|
|
|
export async function ensurePinnedAcpx(params: {
|
|
command: string;
|
|
logger?: PluginLogger;
|
|
pluginRoot?: string;
|
|
expectedVersion?: string;
|
|
}): Promise<void> {
|
|
if (pendingEnsure) {
|
|
return await pendingEnsure;
|
|
}
|
|
|
|
pendingEnsure = (async () => {
|
|
const pluginRoot = params.pluginRoot ?? ACPX_PLUGIN_ROOT;
|
|
const expectedVersion = params.expectedVersion ?? ACPX_PINNED_VERSION;
|
|
|
|
const precheck = await checkPinnedAcpxVersion({
|
|
command: params.command,
|
|
cwd: pluginRoot,
|
|
expectedVersion,
|
|
});
|
|
if (precheck.ok) {
|
|
return;
|
|
}
|
|
|
|
params.logger?.warn(
|
|
`acpx local binary unavailable or mismatched (${precheck.message}); running plugin-local install`,
|
|
);
|
|
|
|
const install = await spawnAndCollect({
|
|
command: "npm",
|
|
args: ["install", "--omit=dev", "--no-save", `acpx@${expectedVersion}`],
|
|
cwd: pluginRoot,
|
|
});
|
|
|
|
if (install.error) {
|
|
const spawnFailure = resolveSpawnFailure(install.error, pluginRoot);
|
|
if (spawnFailure === "missing-command") {
|
|
throw new Error("npm is required to install plugin-local acpx but was not found on PATH");
|
|
}
|
|
throw new Error(`failed to install plugin-local acpx: ${install.error.message}`);
|
|
}
|
|
|
|
if ((install.code ?? 0) !== 0) {
|
|
const stderr = install.stderr.trim();
|
|
const stdout = install.stdout.trim();
|
|
const detail = stderr || stdout || `npm exited with code ${install.code ?? "unknown"}`;
|
|
throw new Error(`failed to install plugin-local acpx: ${detail}`);
|
|
}
|
|
|
|
const postcheck = await checkPinnedAcpxVersion({
|
|
command: params.command,
|
|
cwd: pluginRoot,
|
|
expectedVersion,
|
|
});
|
|
|
|
if (!postcheck.ok) {
|
|
throw new Error(`plugin-local acpx verification failed after install: ${postcheck.message}`);
|
|
}
|
|
|
|
params.logger?.info(`acpx plugin-local binary ready (version ${postcheck.version})`);
|
|
})();
|
|
|
|
try {
|
|
await pendingEnsure;
|
|
} finally {
|
|
pendingEnsure = null;
|
|
}
|
|
}
|