openclaw/src/discord/monitor/agent-components.wildcard.test.ts
SidQin-cyber 6210d2e238 fix(discord): prevent wildcard component registration collisions
Assign distinct sentinel registration ids to Discord wildcard handlers while preserving wildcard parser keys, so select/menu/modal handlers no longer get dropped on runtimes that dedupe by raw customId.
2026-03-02 03:08:32 +00:00

59 lines
2.3 KiB
TypeScript

import { describe, expect, it } from "vitest";
import { buildDiscordComponentCustomId, buildDiscordModalCustomId } from "../components.js";
import {
createDiscordComponentButton,
createDiscordComponentChannelSelect,
createDiscordComponentMentionableSelect,
createDiscordComponentModal,
createDiscordComponentRoleSelect,
createDiscordComponentStringSelect,
createDiscordComponentUserSelect,
} from "./agent-components.js";
type WildcardComponent = {
customId: string;
customIdParser: (id: string) => { key: string; data: unknown };
};
function asWildcardComponent(value: unknown): WildcardComponent {
return value as WildcardComponent;
}
function createWildcardComponents() {
const context = {} as Parameters<typeof createDiscordComponentButton>[0];
return [
asWildcardComponent(createDiscordComponentButton(context)),
asWildcardComponent(createDiscordComponentStringSelect(context)),
asWildcardComponent(createDiscordComponentUserSelect(context)),
asWildcardComponent(createDiscordComponentRoleSelect(context)),
asWildcardComponent(createDiscordComponentMentionableSelect(context)),
asWildcardComponent(createDiscordComponentChannelSelect(context)),
asWildcardComponent(createDiscordComponentModal(context)),
];
}
describe("discord wildcard component registration ids", () => {
it("uses distinct sentinel customIds instead of a shared literal wildcard", () => {
const components = createWildcardComponents();
const customIds = components.map((component) => component.customId);
expect(customIds.every((id) => id !== "*")).toBe(true);
expect(new Set(customIds).size).toBe(customIds.length);
});
it("still resolves sentinel ids and runtime ids through wildcard parser key", () => {
const components = createWildcardComponents();
const interactionCustomId = buildDiscordComponentCustomId({ componentId: "sel_test" });
const interactionModalId = buildDiscordModalCustomId("mdl_test");
for (const component of components) {
expect(component.customIdParser(component.customId).key).toBe("*");
if (component.customId.includes("_modal_")) {
expect(component.customIdParser(interactionModalId).key).toBe("*");
} else {
expect(component.customIdParser(interactionCustomId).key).toBe("*");
}
}
});
});