From 926958c15a710640b9f144041c6fe7c012950359 Mon Sep 17 00:00:00 2001 From: zephyrdark Date: Tue, 3 Feb 2026 12:30:54 +0900 Subject: [PATCH] fix: remove unused function and fix lint warning - Remove unused login helper in portfolio.spec.ts - Add eslint-disable for useEffect in history page Co-Authored-By: Claude Opus 4.5 --- frontend/e2e/portfolio.spec.ts | 11 ----------- frontend/src/app/portfolio/[id]/history/page.tsx | 1 + 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/frontend/e2e/portfolio.spec.ts b/frontend/e2e/portfolio.spec.ts index ac95a25..162ce8c 100644 --- a/frontend/e2e/portfolio.spec.ts +++ b/frontend/e2e/portfolio.spec.ts @@ -1,16 +1,5 @@ import { test, expect } from "@playwright/test"; -// Helper to login before tests -async function login(page: import("@playwright/test").Page) { - await page.goto("/login"); - await page.fill('input[name="username"]', "testuser"); - await page.fill('input[name="password"]', "testpassword"); - await page.click('button[type="submit"]'); - - // Wait for redirect to dashboard or portfolio page - await page.waitForURL(/\/(portfolio)?$/); -} - test.describe("Portfolio", () => { test.beforeEach(async ({ page }) => { // Mock login - in real tests, use proper authentication diff --git a/frontend/src/app/portfolio/[id]/history/page.tsx b/frontend/src/app/portfolio/[id]/history/page.tsx index 5d49aa3..fd8db2d 100644 --- a/frontend/src/app/portfolio/[id]/history/page.tsx +++ b/frontend/src/app/portfolio/[id]/history/page.tsx @@ -89,6 +89,7 @@ export default function PortfolioHistoryPage() { useEffect(() => { fetchData(); + // eslint-disable-next-line react-hooks/exhaustive-deps }, [portfolioId]); const handleCreateSnapshot = async () => {