Ayuriel/openclaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(signal): remove stale 'unknown' MediaKind comparisons

Browse Source 
kindFromMime() returns MediaKind | undefined, never the string 'unknown'.
The old guard against <media:unknown> was based on prior behavior that no
longer exists. Simplify to: use <media:> when kind is defined,
fall back to <media:attachment> when attachments are present but mime is
unresolvable, and emit nothing for blank envelopes.
This commit is contained in:
Dale 2026-03-08 04:06:33 -04:00 committed by root
parent 292a8ef9c4
commit f14ea9f77f
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
extensions/signal/src/monitor/event-handler.ts
View File

@ -862,13 +862,12 @@ export function createSignalEventHandler(deps: SignalEventHandlerDeps) {
placeholder = formatAttachmentSummaryPlaceholder(mediaTypes);
} else {
// Only set placeholder when we actually resolved a mediaType.
// kindFromMime(undefined) returns "unknown" which is truthy — guard against
// that case so null-body messages (e.g. blank reaction envelopes) aren't dispatched
// with <media:unknown> as the body.
// Guard against undefined kind (e.g. blank reaction envelopes) so null-body
// messages aren't dispatched with a spurious <media:…> body.
const kind = mediaType ? kindFromMime(mediaType) : undefined;
if (kind && kind !== "unknown") {
if (kind) {
placeholder = `<media:${kind}>`;
} else if (kind === "unknown" || (!kind && dataMessage.attachments?.length)) {
} else if (dataMessage.attachments?.length) {
placeholder = "<media:attachment>";
}
}